Update patch set 1

Patch Set 1:

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 1000159 <1000159@035e6965-6537-41bd-912c-053f3cf69326>
Reviewer: Gerrit User 1000008 <1000008@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
Gerrit User 1000008 2019-06-19 16:07:35 +00:00 committed by Gerrit Code Review
parent 8e67abee28
commit ce872668f5
1 changed files with 35 additions and 0 deletions

View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "f40c5b66_8df2a245",
"filename": "scripts/osmo_trap2cgi.py",
"patchSetId": 1
},
"lineNbr": 193,
"author": {
"id": 1000008
},
"writtenOn": "2019-06-19T16:07:35Z",
"side": 1,
"message": "We need to break this recursion as well.",
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": true
},
{
"key": {
"uuid": "85ca8e60_2723e2d5",
@ -51,6 +68,24 @@
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": true
},
{
"key": {
"uuid": "b027e520_e63c1125",
"filename": "scripts/osmo_trap2cgi.py",
"patchSetId": 1
},
"lineNbr": 215,
"author": {
"id": 1000008
},
"writtenOn": "2019-06-19T16:07:35Z",
"side": 1,
"message": "Yes, see also my generic comment. So I\u0027ll try to get the recursion out of this script. Maybe Max can share his ideas why he used it in the first place.",
"parentUuid": "ecc398ed_4a427df5",
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": true
}
]
}