Update patch set 5

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 1000229 \u003c1000229@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"arehbein replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"arehbein replied on the change"}
This commit is contained in:
Gerrit User 1000229 2023-02-12 20:30:22 +00:00 committed by Gerrit Code Review
parent 2cb45598cd
commit 444375fd05
1 changed files with 18 additions and 0 deletions

View File

@ -16,6 +16,24 @@
"message": "So who is creating this tmp_dummy_sock? I don\u0027t find any other reference to it in osmo-python-tests.",
"revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "844c4e63_fa7ced61",
"filename": "scripts/osmotestconfig.py",
"patchSetId": 5
},
"lineNbr": 80,
"author": {
"id": 1000229
},
"writtenOn": "2023-02-12T20:30:22Z",
"side": 1,
"message": "The files are created by the `ctrl_test_runner.py` scripts of several projects through binaries that support the `-r` option for creating command listener sockets.\n\n```\n$ ag tmp_dummy_sock\nosmo-bsc-nat/tests/ctrl_test_runner.py\n150: os.unlink(\"tmp_dummy_sock\")\n153: return [\"./src/osmo-bsc-nat/osmo-bsc-nat\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\nosmo-hnbgw/tests/ctrl_test_runner.py\n150: os.unlink(\"tmp_dummy_sock\")\n153: return [\"./src/osmo-hnbgw/osmo-hnbgw\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\ndocker-playground/osmo-bsc-master/osmo-bsc/tests/ctrl_test_runner.py\n150: os.unlink(\"tmp_dummy_sock\")\n153: return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n573: os.unlink(\"tmp_dummy_sock\")\n576: return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n610: os.unlink(\"tmp_dummy_sock\")\n613: return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\nosmo-bsc/tests/ctrl_test_runner.py\n150: os.unlink(\"tmp_dummy_sock\")\n153: return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n573: os.unlink(\"tmp_dummy_sock\")\n576: return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n610: os.unlink(\"tmp_dummy_sock\")\n613: return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\nopenbsc/openbsc/tests/ctrl_test_runner.py\n155: os.unlink(\"tmp_dummy_sock\")\n158: return [\"./src/osmo-bsc/osmo-bsc-sccplite\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n```",
"parentUuid": "14381a0f_f936dc2f",
"revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}