cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

Update notes for submitted changes 

* fix typo 's/dowlink/downlink/g'
* tbf: Move T3193 to tbf_state FSM
* Simplify tbf::set_polling()
* Move tbf ul_ack_state to osmocom FSM
* tbf.h: Improve documentation on several flags
* tbf_dl: Clarify requirements for DL ACK/NACK
* Move timer X2002 to tbf_fsm
* tbf: Use type bool for upgrade_to_multislot
* Fix typos in comments documenting fsm st chg macro
* tbf: Merge handle_ack_nack() into rcvd_dl_ack()
* Get rid of lots of code only used by tests
* Move timer X2001 to tbf_fsm
* tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_UL_DATA
* tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_DL_ASS
* replace dl_ass_state with osmocom FSM
* tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS
* tbf: Reimplement rlcmac_diag() and make it available from C
* Replace ul_ass_state with osmocom FSM
* tbf_free: Get rid of uneeded tbf_state transition
* Get rid of tbf_dl:abort()
* Move rate_ctr free to tbf subclass destructor
* Remove duplicate call to gprs_rlcmac_lost_rep
* Drop logging last mas report before freeing TBF
* Put dl_tbf::cleanup into destructor
* Drop duplicate log line
* Move T3169 and T3195 to tbf_fsm
* Move RELEASING tbf_state transition to tbf_fsm
* Move WAIT_RELEASE tbf_state transition to tbf_fsm
* Move FINISHED tbf_state transition to tbf_fsm
* tests: tbf: Fix dl_tbf polled for data without being in FLOW state
* Move FLOW tbf_state transition to tbf_fsm.
* Move NULL and ASSIGN tbf_state transition to tbf_fsm
* Revert "Revert "Stop abusing T3169""
* Revert "fix: handle NULL return of as_dl_tbf() and as_ul_tbf()"
* Revert "coverity: fix null deref from recent UL TBF leak fix"
This commit is contained in:
Gerrit Code Review 2021-08-23 16:27:59 +00:00
parent d6ed4c3940
commit faf0a88627
35 changed files with 275 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
13/1deb059ff66b64fb8bfeaa487b4be07952ade6 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25053
Project: osmo-pcu
Branch: refs/heads/master

8
28/4711d6271cc524c2d1bedda79db00a61c95eaf Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25054
Project: osmo-pcu
Branch: refs/heads/master

8
32/25290d778401ed9c977f4c86afa33bc1c9abd8 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25104
Project: osmo-pcu
Branch: refs/heads/master

8
33/e80071002c3c0bf097a71c2c8e29d445304255 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+1: osmith <osmith@sysmocom.de>
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25011
Project: osmo-pcu
Branch: refs/heads/master

8
3e/48cfd9f3a80abb6f6d51fc1c34987144fda755 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25106
Project: osmo-pcu
Branch: refs/heads/master

8
40/5d2d10ecb7bd6b84507325785214166247afcb Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25105
Project: osmo-pcu
Branch: refs/heads/master

8
43/2d4f3b89eb1b0df2a141f29cf8f7f0711e798a Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25059
Project: osmo-pcu
Branch: refs/heads/master

7
49/a2f404e82e419de0bf9af210644d1820fccfa2 Normal file
View File

@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25060
Project: osmo-pcu
Branch: refs/heads/master

8
55/f600b702f890de443f9f13a984ecf3e1970d0c Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25047
Project: osmo-pcu
Branch: refs/heads/master

8
5b/c6560efca6084a6d389e6401a9904b20295f23 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25061
Project: osmo-pcu
Branch: refs/heads/master

8
62/8d881247558805ef989e93fbc81371b5fa6caa Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25095
Project: osmo-pcu
Branch: refs/heads/master

8
62/e06f92e963f49a2afde797582c6290dc18250b Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25050
Project: osmo-pcu
Branch: refs/heads/master

8
65/bba93afa9ca5305180415371ee4a889485c84f Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+1: osmith <osmith@sysmocom.de>
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25045
Project: osmo-pcu
Branch: refs/heads/master

7
6a/d11a6990df9587ed8c54931d65254a087e4ac6 Normal file
View File

@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25056
Project: osmo-pcu
Branch: refs/heads/master

8
72/0e19e7f353834d73ffcc264a06e461671e6dd4 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+1: osmith <osmith@sysmocom.de>
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25012
Project: osmo-pcu
Branch: refs/heads/master

7
88/f34812dfbda0ae46ecc6d729d503604b346761 Normal file
View File

@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25223
Project: osmo-pcu
Branch: refs/heads/master

8
8c/4f978483537f238b1830d09f2e90a4a65f33d3 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25051
Project: osmo-pcu
Branch: refs/heads/master

8
90/7f037339865558c4faceadda90c07bb91cf1cf Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25102
Project: osmo-pcu
Branch: refs/heads/master

8
9d/67e72e852d3f50ed0e3b93d71043cef0c2d8d9 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25092
Project: osmo-pcu
Branch: refs/heads/master

8
9d/acf0b35bee54585bc9b29755824487d9262bba Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25052
Project: osmo-pcu
Branch: refs/heads/master

8
a1/61bf48bd68d8fa1e1cbeb61f9d51d1de5f344c Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25111
Project: osmo-pcu
Branch: refs/heads/master

8
ab/8fba3a202bd5c96cfcd30ec05e084abb955194 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25058
Project: osmo-pcu
Branch: refs/heads/master

9
af/e189e80209741bcead0deed33cbd1d11886401 Normal file
View File

@ -0,0 +1,9 @@
Verified+1: Jenkins Builder
Code-Review+1: osmith <osmith@sysmocom.de>
Code-Review+1: dexter <pmaier@sysmocom.de>
Code-Review+2: laforge <laforge@osmocom.org>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25093
Project: osmo-pcu
Branch: refs/heads/master

7
b0/ead922a1dda63cd30eb238c6f03e988a459f7a Normal file
View File

@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25055
Project: osmo-pcu
Branch: refs/heads/master

7
b5/fece959f1285415f8845db7094212ebad95a75 Normal file
View File

@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25222
Project: osmo-pcu
Branch: refs/heads/master

7
bc/139a4af4205e4e23272b1f3cf33c5a439d8b7e Normal file
View File

@ -0,0 +1,7 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25221
Project: osmo-pcu
Branch: refs/heads/master

8
c3/2c4a3648603e50b6ac4e2662e841d3a3c1b9c0 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25034
Project: osmo-pcu
Branch: refs/heads/master

8
c6/5c9e56e147f0179a8ace81b29e36f117235f11 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25090
Project: osmo-pcu
Branch: refs/heads/master

8
cf/b61d95369b1c4fcc4f98ba81eae98b02d7e2ab Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25048
Project: osmo-pcu
Branch: refs/heads/master

8
d0/6ec27856b10631674836d847735a44729631d3 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: dexter <pmaier@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25113
Project: osmo-pcu
Branch: refs/heads/master

8
ea/8dbddab1fc4c5ba932f070d2d2bc4126802e22 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25108
Project: osmo-pcu
Branch: refs/heads/master

8
ef/cb046ce1b922c0c466d4beb53caec263f22d50 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25046
Project: osmo-pcu
Branch: refs/heads/master

8
f4/5ede640b75be9f8bae4f55dccd481cfd762704 Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25049
Project: osmo-pcu
Branch: refs/heads/master

8
f4/8de627f4dacd867fabec8161f29e88894ee17e Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25112
Project: osmo-pcu
Branch: refs/heads/master

8
fb/c1baa13979025dbf10ba13624c03f416f0ba9e Normal file
View File

@ -0,0 +1,8 @@
Verified+1: Jenkins Builder
Code-Review+2: pespin <pespin@sysmocom.de>
Code-Review+1: osmith <osmith@sysmocom.de>
Submitted-by: pespin <pespin@sysmocom.de>
Submitted-at: Mon, 23 Aug 2021 16:27:59 +0000
Reviewed-on: https://gerrit.osmocom.org/c/osmo-pcu/+/25094
Project: osmo-pcu
Branch: refs/heads/master