cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

tests/rlcmac: Add test to showcase that decode_gsm_ra_cap() fails 

Currently code using that function in osmo-pcu is disabled, allegadly
because SGSN was sending incorrect values, but it looks more like a CSN1
issue.

Related: OS#1525, OS#3499
Change-Id: I92c86397f988afaa791871d823a45fa85054f3bb
This commit is contained in:
Pau Espin 2020-01-23 21:00:19 +01:00
parent ea39fade07
commit cdbc5dbd1c
4 changed files with 49 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gsm_rlcmac.cpp
View File

@ -5510,10 +5510,10 @@ void encode_gsm_rlcmac_downlink_data(bitvec * vector, RlcMacDownlinkDataBlock_t
}
}
void decode_gsm_ra_cap(bitvec * vector, MS_Radio_Access_capability_t *data)
int decode_gsm_ra_cap(bitvec * vector, MS_Radio_Access_capability_t *data)
{
csnStream_t ar;
unsigned readIndex = 0;
csnStreamInit(&ar, 0, 8 * vector->data_len);
/*ret =*/ csnStreamDecoder(&ar, CSNDESCR(MS_Radio_Access_capability_t), vector, readIndex, data);
return csnStreamDecoder(&ar, CSNDESCR(MS_Radio_Access_capability_t), vector, readIndex, data);
}

2
src/gsm_rlcmac.h
View File

@ -5137,5 +5137,5 @@ typedef struct
void encode_gsm_rlcmac_uplink(bitvec * vector, RlcMacUplink_t * data);
void decode_gsm_rlcmac_uplink_data(bitvec * vector, RlcMacUplinkDataBlock_t * data);
void encode_gsm_rlcmac_downlink_data(bitvec * vector, RlcMacDownlinkDataBlock_t * data);
void decode_gsm_ra_cap(bitvec * vector, MS_Radio_Access_capability_t * data);
int decode_gsm_ra_cap(bitvec * vector, MS_Radio_Access_capability_t * data);
#endif /* __PACKET_GSM_RLCMAC_H__ */

44
tests/rlcmac/RLCMACTest.cpp
View File

@ -23,9 +23,11 @@
#include <iostream>
#include <cstdlib>
#include <cstring>
#include <assert.h>
#include "csn1.h"
#include "gsm_rlcmac.h"
#include "gprs_rlcmac.h"
#include "decoding.h"
extern "C" {
extern const struct log_info gprs_log_info;
@ -38,6 +40,8 @@ extern const struct log_info gprs_log_info;
}
using namespace std;
void *tall_pcu_ctx;
void printSizeofRLCMAC()
{
printf("*** %s ***\n", __func__);
@ -203,6 +207,45 @@ void testCsnLeftAlignedVarBmpBounds(void *test_ctx)
msgb_free(m);
}
void testRAcap(void *test_ctx)
{
printf("*** %s ***\n", __func__);
MS_Radio_Access_capability_t data;
memset(&data, 0, sizeof(data));
bitvec *vector = bitvec_alloc(23, test_ctx);
int rc;
/*
MS RA capability 1
0001 .... = Access Technology Type: GSM E --note that GSM E covers GSM P (1)
.... 0010 101. .... = Length in bits: 0x15 (21)
...0 01.. RF Power Capability, GMSK Power Class: Not specified (1)
A5 Bits: Same values apply for parameters as in the immediately preceding Access capabilities field within this IE (0)
.... ...1 = Controlled early Classmark Sending: Implemented
0... .... = Pseudo Synchronisation: Not Present
.0.. .... = Voice Group Call Service: no VGCS capability or no notifications wanted
..0. .... = Voice Broadcast Service: no VBS capability or no notifications wanted
...1 .... = Multislot capability struct: Present
.... ..00 011. .... = GPRS multislot class: Max Rx-Slot/TDMA:2 Max Tx-Slot/TDMA:2 Max-Sum-Slot/TDMA:3 Tta:3 Ttb:2 Tra:3 Trb:1 Type:1 (3)
...0 .... = GPRS Extended Dynamic Allocation Capability: Not Implemented
*/
bitvec_unhex(vector, "12a5146200");
rc = decode_gsm_ra_cap(vector, &data);
printf("decode_gsm_ra_cap fails? %s\n", rc !=0 ? "yes" : "no");
#if 0
/* FIXME: OS#1525, OS#3499: csn1 fails to parse this MS RA Cap IE value */
assert (rc == 0);
/* Make sure there's 1 value (currently fails due to failed decoding) */
osmo_assert(cap->Count_MS_RA_capability_value == 1);
/* Make sure MS multislot class is parsed correctly (currently fails due
to failed decoding and count being 0) */
uint8_t ms_class = Decoding::get_ms_class_by_capability(&data);
assert(ms_class == 3);
#endif
}
int main(int argc, char *argv[])
{
void *ctx = talloc_named_const(NULL, 1, "RLCMACTest");
@ -213,5 +256,6 @@ int main(int argc, char *argv[])
testRlcMacDownlink(ctx);
testRlcMacUplink(ctx);
testCsnLeftAlignedVarBmpBounds(ctx);
testRAcap(ctx);
talloc_free(ctx);
}

2
tests/rlcmac/RLCMACTest.ok
View File

@ -123,3 +123,5 @@ vector1 = 40 0a 90 20 00 00 00 00 00 00 00 30 10 01 2a 08 00 13 2b 2b 2b 2b 2b
vector2 = 40 0a 90 20 00 00 00 00 00 00 00 30 10 01 2a 08 00 13 2b 2b 2b 2b 2b
vector1 == vector2 : TRUE
*** testCsnLeftAlignedVarBmpBounds ***
*** testRAcap ***
decode_gsm_ra_cap fails? yes