Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-11-18 18:16:31 +00:00 committed by Gerrit Code Review
parent eb0d4dd219
commit b1ccf3f5f9
1 changed files with 24 additions and 0 deletions

View File

@ -118,6 +118,30 @@
},
"revId": "454a60d7269278cecefad41db8c17c624661d331",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "fefd7001_00819862",
"filename": "src/tbf.h",
"patchSetId": 1
},
"lineNbr": 260,
"author": {
"id": 1000074
},
"writtenOn": "2022-11-18T18:16:31Z",
"side": 1,
"message": "\u003e Maybe move those internals to the private/protected part and only expose the *fi pointers?\n\nThe priv/protected stuff will disappear eventually when we move code to C.\nIn any case, the mainly used field is state_fsm.state_flags which I really need to know into cleaning because it\u0027s from old code and I may end up rewriting that.\n\n\u003e Anyways, not gonna block your patchset.\n\nYes, it\u0027s really bikeshed, whether we want to call it \"main\", \"general\" or \"state\" or whatever. There\u0027s more interesting stuff to clean up in there.\n\nAlso all this needs to be done iteratively with lots of steps, and I tend to spread burst of changes over time.\nIt\u0027s quite usual that in osmo-pcu I started doing 1 change and I end up having 10 patches cleaning up /refactoring stuff before being able to actually touch the thing I want to touch in first place.",
"parentUuid": "48202655_394a8f06",
"range": {
"startLine": 260,
"startChar": 23,
"endLine": 260,
"endChar": 31
},
"revId": "454a60d7269278cecefad41db8c17c624661d331",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}