Update patch set 1
Patch Set 1: (1 comment) Patch-set: 1 Attention: {"person_ident":"Gerrit User 1000147 \u003c1000147@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000028\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 1000028 \u003c1000028@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000028\u003e replied on the change"}
This commit is contained in:
parent
ca6d6d344d
commit
95ebd10e22
|
@ -16,6 +16,24 @@
|
|||
"message": "I\u0027m not sure if we need backwards compatibility here (keep the old define next to the new one)? But given that Pau already +1\u0027d probably not.",
|
||||
"revId": "60664a4df16a96df2eff462aff6f085c875d7551",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0c633798_06bb1a41",
|
||||
"filename": "include/osmocom/pcu/pcuif_proto.h",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 1000028
|
||||
},
|
||||
"writtenOn": "2023-08-17T15:18:16Z",
|
||||
"side": 0,
|
||||
"message": "The problem here is that osmo-pcu (current master) supports both PCUIF v.11 (the one we are currently developing) and PCUIF v.10. For v.10 we still need the old defines, structs etc.\n\nWe intend to keel the PCUIF v.10 support for a while. The problem are the TTCN3 tests. If we change them to use v.11, then latest will fail. What we could do though is dropping the v.10 support some hours before the new release. Unfortunately changes to PCUIF are very complicated because we must touch osmo-pcu, osmo-bts, osmo-bsc, and the testsuite for osmo-pcu and osmo-bsc.",
|
||||
"parentUuid": "032edab9_9717a475",
|
||||
"revId": "60664a4df16a96df2eff462aff6f085c875d7551",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue