cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

Fix GPRS PUAN encoding: wrong BSN status 

Earlier there was an incorrect encoding of BSN status in GPRS PUAN message.
This was a bottle neck for GPRS performance testing for UL. Which has been fixed
in this patch.

Related: OS#1806

Change-Id: I98e586aa5cb9200cf03e092556304211d4d459aa
This commit is contained in:
Aravind Sirsikar 2016-08-30 13:08:28 +05:30 committed by arvind.sirsikar
parent a35c911a91
commit 7c7a86c080
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/rlc.cpp
View File

@ -227,7 +227,7 @@ void gprs_rlc_ul_window::update_rbb(char *rbb)
{
int i;
for (i=0; i < ws(); i++) {
if (m_v_n.is_received(ssn()-1-i))
if (m_v_n.is_received((ssn()-1-i) & mod_sns()))
rbb[ws()-1-i] = 'R';
else
rbb[ws()-1-i] = 'I';

5
tests/types/TypesTest.cpp
View File

@ -325,10 +325,9 @@ static void test_rlc_dl_ul_basic()
/*
* SSN wrap around case
* TODO: Should not expect any BSN as nacked.
* should be fixed in subsequent patch
* Should not expect any BSN as nacked.
*/
rbb = "IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIRR";
rbb = "RRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR";
for (int i = 0; i < 128; ++i) {
ul_win.receive_bsn(i);
ul_win.raise_v_q();