Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"fixeria replied on the change"}
This commit is contained in:
Gerrit User 1000010 2022-11-18 15:32:21 +00:00 committed by Gerrit Code Review
parent cbd2410bbe
commit 776f77c1c4
1 changed files with 24 additions and 0 deletions

View File

@ -46,6 +46,30 @@
},
"revId": "454a60d7269278cecefad41db8c17c624661d331",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "e6672579_6bb423ed",
"filename": "src/tbf.h",
"patchSetId": 1
},
"lineNbr": 260,
"author": {
"id": 1000010
},
"writtenOn": "2022-11-18T15:32:21Z",
"side": 1,
"message": "But this is one is the main tbf_fsm, right? Both ul_ass_fsm and dl_ass_fsm are supplementary ones, AFAICS. IMO, it\u0027s even more confusing now: you have \u0027state_fi\u0027 and \u0027state_fsm\u0027.\n\nAnd why the internal fsm data (i.e. tbf_ul_ass_fsm_ctx, tbf_ul_ass_fsm_ctx, and tbf_fsm_ctx) is available here? Shouldn\u0027t it be dynamically allocated and assigned to fi-\u003epriv?",
"parentUuid": "eec627d2_f4417d81",
"range": {
"startLine": 260,
"startChar": 23,
"endLine": 260,
"endChar": 31
},
"revId": "454a60d7269278cecefad41db8c17c624661d331",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}