cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

alloc: Base algo A on reserved PDCHs 

Currently algorithm A bases its time slots selection on the number of
TBF actively using the PDCHs. This statistically prefers the first
time slots, especially with short living TBFs. So when the first TBF
is triggered by an uplink transfer (which generally results in a
short-lived TBF) the potentially longer living DL TBF will be bound
to the same slot. When another MS then requests an uplink TBF, it
will get the same slot (no UL TBF currently active).

This commit changes the algorithm to base its selection on reserved
slots instead.

Sponsored-by: On-Waves ehf
This commit is contained in:
Jacob Erlbeck 2015-06-30 10:24:37 +02:00
parent 83426b20a3
commit 5cd496d208
2 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/gprs_rlcmac_ts_alloc.cpp
View File

@ -241,25 +241,26 @@ int alloc_algorithm_a(struct gprs_rlcmac_bts *bts,
{
struct gprs_rlcmac_pdch *pdch;
int ts = -1;
uint8_t ul_slots, dl_slots;
int usf = -1;
int mask = 0xff;
const char *mask_reason = NULL;
struct gprs_rlcmac_tbf *ref_tbf;
LOGP(DRLCMAC, LOGL_DEBUG, "Slot Allocation (Algorithm A) for class "
"%d\n", tbf->ms_class());
if ((ref_tbf = ms->tbf(tbf->direction)))
dl_slots = ms->reserved_dl_slots();
ul_slots = ms->reserved_ul_slots();
ts = ms->first_common_ts();
if (ts >= 0) {
mask_reason = "need to reuse TS";
else if ((ref_tbf = ms->tbf(reverse(tbf->direction))))
mask_reason = ref_tbf->direction == GPRS_RLCMAC_UL_TBF ?
"not an uplink TBF" : "not a downlink TBF";
if (ref_tbf)
ts = ref_tbf->first_common_ts;
if (ts >= 0)
mask = 1 << ts;
} else if (dl_slots || ul_slots) {
mask_reason = "need to use a reserved common TS";
mask = dl_slots & ul_slots;
}
mask = find_possible_pdchs(tbf->trx, 1, mask, mask_reason);
if (!mask)
@ -296,6 +297,7 @@ int alloc_algorithm_a(struct gprs_rlcmac_bts *bts,
}
/* the only one TS is the common TS */
tbf->first_ts = tbf->first_common_ts = ts;
ms->set_reserved_slots(tbf->trx, 1 << ts, 1 << ts);
tbf->upgrade_to_multislot = 0;

2
tests/tbf/TbfTest.err
View File

@ -20,7 +20,7 @@ Allocating UL TBF: TFI=0 TRX=0 MS_CLASS=0
Slot Allocation (Algorithm A) for class 0
- Skipping TS 0, because not enabled
- Skipping TS 1, because not enabled
- Skipping TS 3, because not a downlink TBF
- Skipping TS 3, because need to reuse TS
- Skipping TS 4, because not enabled
- Skipping TS 5, because not enabled
- Skipping TS 6, because not enabled