cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

Make TBF state private 

Let's make sure no external function can mess with the TBF state.

Change-Id: I217f4c4bac21dd584c8682928a080a1a6e9507e1
This commit is contained in:
Max 2017-12-06 13:35:08 +01:00 committed by Harald Welte
parent b3a17d6074
commit 5081806f4d
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tbf.cpp
View File

@ -174,7 +174,6 @@ gprs_rlcmac_tbf::gprs_rlcmac_tbf(BTS *bts_, gprs_rlcmac_tbf_direction dir) :
n3105(0),
fT(0),
num_fT_exp(0),
state(GPRS_RLCMAC_NULL),
was_releasing(0),
upgrade_to_multislot(0),
bts(bts_),
@ -185,6 +184,7 @@ gprs_rlcmac_tbf::gprs_rlcmac_tbf(BTS *bts_, gprs_rlcmac_tbf_direction dir) :
m_ms(NULL),
m_ta(GSM48_TA_INVALID),
m_ms_class(0),
state(GPRS_RLCMAC_NULL),
m_list(this),
m_ms_list(this),
m_egprs_enabled(false)

5
src/tbf.h
View File

@ -284,10 +284,6 @@ struct gprs_rlcmac_tbf {
Meas();
} meas;
/* these should become protected but only after gprs_rlcmac_data.c
* stops to iterate over all tbf in its current form */
enum gprs_rlcmac_tbf_state state;
/* Remember if the tbf was in wait_release state when we want to
* schedule a new dl assignment */
uint8_t was_releasing;
@ -327,6 +323,7 @@ protected:
uint8_t m_ms_class;
private:
enum gprs_rlcmac_tbf_state state;
LListHead<gprs_rlcmac_tbf> m_list;
LListHead<gprs_rlcmac_tbf> m_ms_list;
bool m_egprs_enabled;