parent
c80994e072
commit
18f38992c7
|
@ -16,6 +16,24 @@
|
|||
"message": "This patch breaks compatibility with osmo-bts v1.7.1 (current latest tag).\n\n```\nDL1IF ERROR pcu_l1_if.cpp:1349 Received 1006 bytes on PCU Socket, but primitive pcu_prim-\u003eu.info_ind size is 1007, discarding\n```\n\nWe shall not merge it as-is.",
|
||||
"revId": "028c48f6eca47623b982a1628702beaf7dfcb847",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7fdb3c25_deb39758",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2023-12-11T11:46:30Z",
|
||||
"side": 1,
|
||||
"message": "Even if we make osmo-pcu v1.4.0 compatible with osmo-bts v1.7.1 and osmo-bsc v1.11.0 by lifting the primitive size checking, this would still be pretty useless because we **need to know the BTS type** in order for dummy block generation to work properly (https://gerrit.osmocom.org/c/osmo-pcu/+/35319).\n\nI think we would have to:\n\n* tag patch releases for both osmo-bts and osmo-bsc, so that both of them would speak the PCUIFv12 and indicate a BTS type to osmo-pcu;\n* either drop backwards compatibility with PCUIFv \u003c 12 (see https://cgit.osmocom.org/osmo-pcu/commit/?id\u003d46140948d9800bca6a7b4299f08b25efc1af0fa3), or keep it compatible with v10 and v11, but carefully check that it can actually work with v10 and v12.",
|
||||
"parentUuid": "81b3edcd_10edc28a",
|
||||
"revId": "028c48f6eca47623b982a1628702beaf7dfcb847",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue