cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

bts: bts_tfi_find_free(): fix -Wmaybe-uninitialized (false positive) 

We cannot see how uninitialized access is possible, but gcc v13.2.1
does complain about it.  Let's work this around by assigning an
invalid value, like trx_count_free_tfi() does.

src/bts.cpp: In function 'int bts_tfi_find_free(const gprs_rlcmac_bts*,
						gprs_rlcmac_tbf_direction,
						uint8_t*, int8_t)':
warning: 'tmp_first_tfi' may be used uninitialized [-Wmaybe-uninitialized]

Change-Id: Ia446cdf573ee25e6da6b4aa917972c63472229bb
Fixes: OS#6190
(cherry picked from commit 30a7d26c83)
This commit is contained in:
Vadim Yanitskiy 2023-09-26 20:36:51 +07:00 committed by Oliver Smith
parent 9658f02214
commit 0dbafde45b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bts.cpp
View File

@ -642,7 +642,7 @@ int bts_tfi_find_free(const struct gprs_rlcmac_bts *bts, enum gprs_rlcmac_tbf_di
/* find a TFI that is unused on all PDCH */
for (trx = trx_from; trx <= trx_to; trx++) {
uint8_t tmp_first_tfi;
uint8_t tmp_first_tfi = 0xff; /* make gcc happy */
unsigned int tmp_cnt;
tmp_cnt = trx_count_free_tfi(&bts->trx[trx], dir, &tmp_first_tfi);
if (tmp_cnt > best_cnt) {