cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity
osmo-pcu/src/bts.cpp

875 lines
26 KiB
C++
Raw Normal View History

bts: Introduce a singleton for the BTS and use it in the code Compared to the previous code there will be a branch to get the global pointer so the code will be slightly slower than the previous version but it allows us to start creating objects but still use the code from C. It is best approach I have found so far. One downside of C++ is that by default talloc will not be used (unless we override the new operator to use talloc. Right now we need to memset the C data structure by hand. The benefit of enforcing a better structure should is more important though.
2013-10-17 17:41:11 +00:00
/*
* Copyright (C) 2013 by Holger Hans Peter Freyther
*
* All Rights Reserved
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
#include <bts.h>
bts: Introduce a PollController that has the responsibility to poll For each frame indication received by the BTS the poll controller is asked to expire timedout entries.
2013-10-17 18:12:37 +00:00
#include <poll_controller.h>
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
#include <tbf.h>
encoding: Move the functions into the encoding class Add some TODO to this class. E.g. they could all work on the bitvec and the parameter handling could better.
2013-10-19 17:04:03 +00:00
#include <encoding.h>
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
#include <decoding.h>
#include <rlc.h>
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
#include <gprs_rlcmac.h>
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
#include <gprs_debug.h>
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
extern "C" {
#include <osmocom/core/talloc.h>
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
#include <osmocom/core/msgb.h>
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
}
bts: Introduce a PollController that has the responsibility to poll For each frame indication received by the BTS the poll controller is asked to expire timedout entries.
2013-10-17 18:12:37 +00:00
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
#include <arpa/inet.h>
bts/pdch: Move the adding of paging to the BTS/PDCH objects Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged.
2013-10-19 16:28:59 +00:00
#include <errno.h>
bts: Introduce a singleton for the BTS and use it in the code Compared to the previous code there will be a branch to get the global pointer so the code will be slightly slower than the previous version but it allows us to start creating objects but still use the code from C. It is best approach I have found so far. One downside of C++ is that by default talloc will not be used (unless we override the new operator to use talloc. Right now we need to memset the C data structure by hand. The benefit of enforcing a better structure should is more important though.
2013-10-17 17:41:11 +00:00
#include <string.h>
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
extern void *tall_pcu_ctx;
bts: Introduce a singleton for the BTS and use it in the code Compared to the previous code there will be a branch to get the global pointer so the code will be slightly slower than the previous version but it allows us to start creating objects but still use the code from C. It is best approach I have found so far. One downside of C++ is that by default talloc will not be used (unless we override the new operator to use talloc. Right now we need to memset the C data structure by hand. The benefit of enforcing a better structure should is more important though.
2013-10-17 17:41:11 +00:00
static BTS s_bts;
BTS* BTS::main_bts()
{
return &s_bts;
}
struct gprs_rlcmac_bts *BTS::bts_data()
{
return &m_bts;
}
struct gprs_rlcmac_bts *bts_main_data()
{
return BTS::main_bts()->bts_data();
}
BTS::BTS()
bts: Move the frame_number into the BTS sructure The current_frame is an attribute of the BTS. Move it from the pcu_l1_if.cpp into the BTS. As the next step we can trigger actions depending on the change of the frame.
2013-10-17 17:59:56 +00:00
: m_cur_fn(0)
bts: Introduce a PollController that has the responsibility to poll For each frame indication received by the BTS the poll controller is asked to expire timedout entries.
2013-10-17 18:12:37 +00:00
, m_pollController(*this)
sba: Create a SBAController that will manage the sbas for a BTS The PollController is a friend of the SBAController and is allowed to access the internal list. The list is hidden from everyone else. This is done because the calculation of timeout should belong into the PollController and not into the SBAController.
2013-10-19 18:47:12 +00:00
, m_sba(*this)
bts: Introduce a singleton for the BTS and use it in the code Compared to the previous code there will be a branch to get the global pointer so the code will be slightly slower than the previous version but it allows us to start creating objects but still use the code from C. It is best approach I have found so far. One downside of C++ is that by default talloc will not be used (unless we override the new operator to use talloc. Right now we need to memset the C data structure by hand. The benefit of enforcing a better structure should is more important though.
2013-10-17 17:41:11 +00:00
{
memset(&m_bts, 0, sizeof(m_bts));
bts/tbf: Move the lists into the BTS and do the look-up from the BTS The list belongs to the BTS. This makes cleaning this up more easy and establishes a hierachy of resources that start from the BTS. The debug_diagram code is now broken.
2013-10-19 19:10:38 +00:00
INIT_LLIST_HEAD(&m_bts.ul_tbfs);
INIT_LLIST_HEAD(&m_bts.dl_tbfs);
bts: Introduce a singleton for the BTS and use it in the code Compared to the previous code there will be a branch to get the global pointer so the code will be slightly slower than the previous version but it allows us to start creating objects but still use the code from C. It is best approach I have found so far. One downside of C++ is that by default talloc will not be used (unless we override the new operator to use talloc. Right now we need to memset the C data structure by hand. The benefit of enforcing a better structure should is more important though.
2013-10-17 17:41:11 +00:00
m_bts.bts = this;
bts: Add backpointers to the PDCH and TRX structures This will allow to kill various parameters from all the functions as we can walk back.
2013-10-20 08:14:03 +00:00
/* initialize back pointers */
for (size_t trx_no = 0; trx_no < ARRAY_SIZE(m_bts.trx); ++trx_no) {
struct gprs_rlcmac_trx *trx = &m_bts.trx[trx_no];
trx->trx_no = trx_no;
trx->bts = this;
for (size_t ts_no = 0; ts_no < ARRAY_SIZE(trx->pdch); ++ts_no) {
struct gprs_rlcmac_pdch *pdch = &trx->pdch[ts_no];
pdch->ts_no = ts_no;
pdch->trx = trx;
}
}
bts: Introduce a singleton for the BTS and use it in the code Compared to the previous code there will be a branch to get the global pointer so the code will be slightly slower than the previous version but it allows us to start creating objects but still use the code from C. It is best approach I have found so far. One downside of C++ is that by default talloc will not be used (unless we override the new operator to use talloc. Right now we need to memset the C data structure by hand. The benefit of enforcing a better structure should is more important though.
2013-10-17 17:41:11 +00:00
}
bts: Move the frame_number into the BTS sructure The current_frame is an attribute of the BTS. Move it from the pcu_l1_if.cpp into the BTS. As the next step we can trigger actions depending on the change of the frame.
2013-10-17 17:59:56 +00:00
void BTS::set_current_frame_number(int fn)
{
m_cur_fn = fn;
bts: Introduce a PollController that has the responsibility to poll For each frame indication received by the BTS the poll controller is asked to expire timedout entries.
2013-10-17 18:12:37 +00:00
m_pollController.expireTimedout(m_cur_fn);
bts: Move the frame_number into the BTS sructure The current_frame is an attribute of the BTS. Move it from the pcu_l1_if.cpp into the BTS. As the next step we can trigger actions depending on the change of the frame.
2013-10-17 17:59:56 +00:00
}
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
bts/pdch: Move the adding of paging to the BTS/PDCH objects Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged.
2013-10-19 16:28:59 +00:00
int BTS::add_paging(uint8_t chan_needed, uint8_t *identity_lv)
{
uint8_t l, trx, ts, any_tbf = 0;
struct gprs_rlcmac_tbf *tbf;
struct gprs_rlcmac_paging *pag;
uint8_t slot_mask[8];
int8_t first_ts; /* must be signed */
bts/tbf: Move the lists into the BTS and do the look-up from the BTS The list belongs to the BTS. This makes cleaning this up more easy and establishes a hierachy of resources that start from the BTS. The debug_diagram code is now broken.
2013-10-19 19:10:38 +00:00
llist_head *tbfs_lists[] = {
&m_bts.ul_tbfs,
&m_bts.dl_tbfs,
NULL
};
bts/pdch: Move the adding of paging to the BTS/PDCH objects Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged.
2013-10-19 16:28:59 +00:00
LOGP(DRLCMAC, LOGL_INFO, "Add RR paging: chan-needed=%d MI=%s\n",
chan_needed, osmo_hexdump(identity_lv + 1, identity_lv[0]));
/* collect slots to page
* Mark slots for every TBF, but only mark one of it.
* Mark only the first slot found.
* Don't mark, if TBF uses a different slot that is already marked. */
memset(slot_mask, 0, sizeof(slot_mask));
bts/tbf: Move the lists into the BTS and do the look-up from the BTS The list belongs to the BTS. This makes cleaning this up more easy and establishes a hierachy of resources that start from the BTS. The debug_diagram code is now broken.
2013-10-19 19:10:38 +00:00
for (l = 0; tbfs_lists[l]; l++) {
llist_for_each_entry(tbf, tbfs_lists[l], list) {
bts/pdch: Move the adding of paging to the BTS/PDCH objects Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged.
2013-10-19 16:28:59 +00:00
first_ts = -1;
for (ts = 0; ts < 8; ts++) {
if (tbf->pdch[ts]) {
/* remember the first slot found */
if (first_ts < 0)
first_ts = ts;
/* break, if we already marked a slot */
if ((slot_mask[tbf->trx_no] & (1 << ts)))
break;
}
}
/* mark first slot found, if none is marked already */
if (ts == 8 && first_ts >= 0) {
LOGP(DRLCMAC, LOGL_DEBUG, "- %s TBF=%d uses "
"TRX=%d TS=%d, so we mark\n",
(tbf->direction == GPRS_RLCMAC_UL_TBF)
? "UL" : "DL",
tbf->tfi, tbf->trx_no, first_ts);
slot_mask[tbf->trx_no] |= (1 << first_ts);
} else
LOGP(DRLCMAC, LOGL_DEBUG, "- %s TBF=%d uses "
"already marked TRX=%d TS=%d\n",
(tbf->direction == GPRS_RLCMAC_UL_TBF)
? "UL" : "DL",
tbf->tfi, tbf->trx_no, ts);
}
}
/* Now we have a list of marked slots. Every TBF uses at least one
* of these slots. */
/* schedule paging to all marked slots */
for (trx = 0; trx < 8; trx++) {
if (slot_mask[trx] == 0)
continue;
for (ts = 0; ts < 8; ts++) {
if ((slot_mask[trx] & (1 << ts))) {
/* schedule */
pag = talloc_zero(tall_pcu_ctx,
struct gprs_rlcmac_paging);
if (!pag)
return -ENOMEM;
pag->chan_needed = chan_needed;
memcpy(pag->identity_lv, identity_lv,
identity_lv[0] + 1);
m_bts.trx[trx].pdch[ts].add_paging(pag);
LOGP(DRLCMAC, LOGL_INFO, "Paging on PACCH of "
"TRX=%d TS=%d\n", trx, ts);
pdch: Only say we have paged when this has actually been done
2013-10-19 16:33:52 +00:00
any_tbf = 1;
bts/pdch: Move the adding of paging to the BTS/PDCH objects Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged.
2013-10-19 16:28:59 +00:00
}
}
}
if (!any_tbf)
LOGP(DRLCMAC, LOGL_INFO, "No paging, because no TBF\n");
return 0;
}
bts/tbf: Move the lists into the BTS and do the look-up from the BTS The list belongs to the BTS. This makes cleaning this up more easy and establishes a hierachy of resources that start from the BTS. The debug_diagram code is now broken.
2013-10-19 19:10:38 +00:00
/* search for active downlink or uplink tbf */
gprs_rlcmac_tbf *BTS::tbf_by_tlli(uint32_t tlli, enum gprs_rlcmac_tbf_direction dir)
{
struct gprs_rlcmac_tbf *tbf;
if (dir == GPRS_RLCMAC_UL_TBF) {
llist_for_each_entry(tbf, &m_bts.ul_tbfs, list) {
if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
&& tbf->tlli == tlli && tbf->tlli_valid)
return tbf;
}
} else {
llist_for_each_entry(tbf, &m_bts.dl_tbfs, list) {
if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
&& tbf->tlli == tlli)
return tbf;
}
}
return NULL;
}
gprs_rlcmac_tbf *BTS::tbf_by_poll_fn(uint32_t fn, uint8_t trx, uint8_t ts)
{
struct gprs_rlcmac_tbf *tbf;
/* only one TBF can poll on specific TS/FN, because scheduler can only
* schedule one downlink control block (with polling) at a FN per TS */
llist_for_each_entry(tbf, &m_bts.ul_tbfs, list) {
if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
&& tbf->poll_state == GPRS_RLCMAC_POLL_SCHED
&& tbf->poll_fn == fn && tbf->trx_no == trx
&& tbf->control_ts == ts)
return tbf;
}
llist_for_each_entry(tbf, &m_bts.dl_tbfs, list) {
if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)
&& tbf->poll_state == GPRS_RLCMAC_POLL_SCHED
&& tbf->poll_fn == fn && tbf->trx_no == trx
&& tbf->control_ts == ts)
return tbf;
}
return NULL;
}
tbf/pdch/bts: Move the tbf look-up by tfi into the BTS
2013-10-26 17:10:43 +00:00
/* lookup TBF Entity (by TFI) */
gprs_rlcmac_tbf *BTS::tbf_by_tfi(uint8_t tfi, uint8_t trx,
enum gprs_rlcmac_tbf_direction dir)
{
struct gprs_rlcmac_tbf *tbf;
if (tfi >= 32 || trx >= 8)
return NULL;
if (dir == GPRS_RLCMAC_UL_TBF)
tbf = m_bts.trx[trx].ul_tbf[tfi];
else
tbf = m_bts.trx[trx].dl_tbf[tfi];
if (!tbf)
return NULL;
if (tbf->state_is_not(GPRS_RLCMAC_RELEASING))
return tbf;
return NULL;
}
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
/*
* PDCH code below. TODO: move to a separate file
*/
/* After receiving these frames, we send ack/nack. */
#define SEND_ACK_AFTER_FRAMES 20
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
void gprs_rlcmac_pdch::enable()
{
/* TODO: Check if there are still allocated resources.. */
INIT_LLIST_HEAD(&paging_list);
m_is_enabled = 1;
}
void gprs_rlcmac_pdch::disable()
{
/* TODO.. kick free_resources once we know the TRX/TS we are on */
m_is_enabled = 0;
}
sba: Create a SBAController that will manage the sbas for a BTS The PollController is a friend of the SBAController and is allowed to access the internal list. The list is hidden from everyone else. This is done because the calculation of timeout should belong into the PollController and not into the SBAController.
2013-10-19 18:47:12 +00:00
/* TODO: kill the parameter and make a pdch belong to a trx.. to a bts.. */
pdch: Simplify the reset code, rename variables to XYZ_no Simplify the reset code now that the PDCH can know where it is located. Rename the variables in the sba to trx_no and ts_no as it stores the number and not the actual thing.
2013-10-20 14:37:05 +00:00
void gprs_rlcmac_pdch::free_resources()
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
{
struct gprs_rlcmac_paging *pag;
/* we are not enabled. there should be no resources */
if (!is_enabled())
return;
/* kick all TBF on slot */
gprs_rlcmac_tbf::free_all(this);
/* flush all pending paging messages */
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
while ((pag = dequeue_paging()))
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
talloc_free(pag);
pdch: Simplify the reset code, rename variables to XYZ_no Simplify the reset code now that the PDCH can know where it is located. Rename the variables in the sba to trx_no and ts_no as it stores the number and not the actual thing.
2013-10-20 14:37:05 +00:00
trx->bts->sba()->free_resources(this);
pdch: Move enable/disable into the PDCH code When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later.
2013-10-19 15:37:48 +00:00
}
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
struct gprs_rlcmac_paging *gprs_rlcmac_pdch::dequeue_paging()
{
struct gprs_rlcmac_paging *pag;
if (llist_empty(&paging_list))
return NULL;
pag = llist_entry(paging_list.next, struct gprs_rlcmac_paging, list);
llist_del(&pag->list);
return pag;
}
struct msgb *gprs_rlcmac_pdch::packet_paging_request()
{
struct gprs_rlcmac_paging *pag;
struct msgb *msg;
unsigned wp = 0, len;
/* no paging, no message */
pag = dequeue_paging();
if (!pag)
return NULL;
LOGP(DRLCMAC, LOGL_DEBUG, "Scheduling paging\n");
/* alloc message */
msg = msgb_alloc(23, "pag ctrl block");
if (!msg) {
talloc_free(pag);
return NULL;
}
bitvec *pag_vec = bitvec_alloc(23);
if (!pag_vec) {
msgb_free(msg);
talloc_free(pag);
return NULL;
}
encoding: Move the functions into the encoding class Add some TODO to this class. E.g. they could all work on the bitvec and the parameter handling could better.
2013-10-19 17:04:03 +00:00
wp = Encoding::write_packet_paging_request(pag_vec);
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
/* loop until message is full */
while (pag) {
/* try to add paging */
if ((pag->identity_lv[1] & 0x07) == 4) {
/* TMSI */
LOGP(DRLCMAC, LOGL_DEBUG, "- TMSI=0x%08x\n",
ntohl(*((uint32_t *)(pag->identity_lv + 1))));
len = 1 + 1 + 1 + 32 + 2 + 1;
if (pag->identity_lv[0] != 5) {
LOGP(DRLCMAC, LOGL_ERROR, "TMSI paging with "
"MI != 5 octets!\n");
goto continue_next;
}
} else {
/* MI */
LOGP(DRLCMAC, LOGL_DEBUG, "- MI=%s\n",
osmo_hexdump(pag->identity_lv + 1,
pag->identity_lv[0]));
len = 1 + 1 + 1 + 4 + (pag->identity_lv[0]<<3) + 2 + 1;
if (pag->identity_lv[0] > 8) {
LOGP(DRLCMAC, LOGL_ERROR, "Paging with "
"MI > 8 octets!\n");
goto continue_next;
}
}
if (wp + len > 184) {
LOGP(DRLCMAC, LOGL_DEBUG, "- Does not fit, so schedule "
"next time\n");
/* put back paging record, because does not fit */
llist_add_tail(&pag->list, &paging_list);
break;
}
encoding: Move the functions into the encoding class Add some TODO to this class. E.g. they could all work on the bitvec and the parameter handling could better.
2013-10-19 17:04:03 +00:00
Encoding::write_repeated_page_info(pag_vec, wp, pag->identity_lv[0],
pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well.
2013-10-19 16:15:44 +00:00
pag->identity_lv + 1, pag->chan_needed);
continue_next:
talloc_free(pag);
pag = dequeue_paging();
}
bitvec_pack(pag_vec, msgb_put(msg, 23));
RlcMacDownlink_t * mac_control_block = (RlcMacDownlink_t *)talloc_zero(tall_pcu_ctx, RlcMacDownlink_t);
LOGP(DRLCMAC, LOGL_DEBUG, "+++++++++++++++++++++++++ TX : Packet Paging Request +++++++++++++++++++++++++\n");
decode_gsm_rlcmac_downlink(pag_vec, mac_control_block);
LOGPC(DCSN1, LOGL_NOTICE, "\n");
LOGP(DRLCMAC, LOGL_DEBUG, "------------------------- TX : Packet Paging Request -------------------------\n");
bitvec_free(pag_vec);
talloc_free(mac_control_block);
return msg;
}
bts/pdch: Move the adding of paging to the BTS/PDCH objects Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged.
2013-10-19 16:28:59 +00:00
void gprs_rlcmac_pdch::add_paging(struct gprs_rlcmac_paging *pag)
{
llist_add(&pag->list, &paging_list);
}
pdch: Instead of passing bts, trx, ts use the pdch All dispatching will go through the PDCH. This will clean a lot of the look-ups inside the gprs_rlcmac_data.c and continue with adding structure to the pcu code.
2013-10-26 14:42:38 +00:00
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
/* receive UL data block
*
* The blocks are defragmented and forwarded as LLC frames, if complete.
*/
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
int gprs_rlcmac_pdch::rcv_data_block_acknowledged(uint8_t *data, uint8_t len, int8_t rssi)
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
{
struct gprs_rlcmac_tbf *tbf;
struct rlc_ul_header *rh = (struct rlc_ul_header *)data;
uint16_t mod_sns, mod_sns_half, offset_v_q, offset_v_r, index;
int rc;
switch (len) {
case 54:
/* omitting spare bits */
len = 53;
break;
case 40:
/* omitting spare bits */
len = 39;
break;
case 34:
/* omitting spare bits */
len = 33;
break;
case 23:
break;
default:
LOGP(DRLCMACUL, LOGL_ERROR, "Dropping data block with invalid"
"length: %d)\n", len);
return -EINVAL;
}
/* find TBF inst from given TFI */
tbf/pdch/bts: Move the tbf look-up by tfi into the BTS
2013-10-26 17:10:43 +00:00
tbf = bts()->tbf_by_tfi(rh->tfi, trx_no(), GPRS_RLCMAC_UL_TBF);
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
if (!tbf) {
LOGP(DRLCMACUL, LOGL_NOTICE, "UL DATA unknown TBF=%d\n",
rh->tfi);
return 0;
}
tbf->state_flags |= (1 << GPRS_RLCMAC_FLAG_UL_DATA);
LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA TBF=%d received (V(Q)=%d .. "
"V(R)=%d)\n", rh->tfi, tbf->dir.ul.v_q, tbf->dir.ul.v_r);
/* process RSSI */
gprs_rlcmac_rssi(tbf, rssi);
/* get TLLI */
if (!tbf->tlli_valid) {
struct gprs_rlcmac_tbf *dl_tbf, *ul_tbf;
/* no TLLI yet */
if (!rh->ti) {
LOGP(DRLCMACUL, LOGL_NOTICE, "UL DATA TBF=%d without "
"TLLI, but no TLLI received yet\n", rh->tfi);
return 0;
}
rc = Decoding::tlli_from_ul_data(data, len, &tbf->tlli);
if (rc) {
LOGP(DRLCMACUL, LOGL_NOTICE, "Failed to decode TLLI "
"of UL DATA TBF=%d.\n", rh->tfi);
return 0;
}
LOGP(DRLCMACUL, LOGL_INFO, "Decoded premier TLLI=0x%08x of "
"UL DATA TBF=%d.\n", tbf->tlli, rh->tfi);
pdch: Remove the the bts parameter from rcv_data_block_acknowledged
2013-10-26 16:39:36 +00:00
if ((dl_tbf = bts()->tbf_by_tlli(tbf->tlli, GPRS_RLCMAC_DL_TBF))) {
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
LOGP(DRLCMACUL, LOGL_NOTICE, "Got RACH from "
"TLLI=0x%08x while DL TBF=%d still exists. "
"Killing pending DL TBF\n", tbf->tlli,
dl_tbf->tfi);
tbf_free(dl_tbf);
}
/* tbf_by_tlli will not find your TLLI, because it is not
* yet marked valid */
pdch: Remove the the bts parameter from rcv_data_block_acknowledged
2013-10-26 16:39:36 +00:00
if ((ul_tbf = bts()->tbf_by_tlli(tbf->tlli, GPRS_RLCMAC_UL_TBF))) {
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
LOGP(DRLCMACUL, LOGL_NOTICE, "Got RACH from "
"TLLI=0x%08x while UL TBF=%d still exists. "
"Killing pending UL TBF\n", tbf->tlli,
ul_tbf->tfi);
tbf_free(ul_tbf);
}
/* mark TLLI valid now */
tbf->tlli_valid = 1;
/* store current timing advance */
pdch: Remove the the bts parameter from rcv_data_block_acknowledged
2013-10-26 16:39:36 +00:00
bts()->timing_advance()->remember(tbf->tlli, tbf->ta);
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
/* already have TLLI, but we stille get another one */
} else if (rh->ti) {
uint32_t tlli;
rc = Decoding::tlli_from_ul_data(data, len, &tlli);
if (rc) {
LOGP(DRLCMACUL, LOGL_NOTICE, "Failed to decode TLLI "
"of UL DATA TBF=%d.\n", rh->tfi);
return 0;
}
if (tlli != tbf->tlli) {
LOGP(DRLCMACUL, LOGL_NOTICE, "TLLI mismatch on UL "
"DATA TBF=%d. (Ignoring due to contention "
"resolution)\n", rh->tfi);
return 0;
}
}
mod_sns = tbf->sns - 1;
mod_sns_half = (tbf->sns >> 1) - 1;
/* restart T3169 */
pdch: Remove the the bts parameter from rcv_data_block_acknowledged
2013-10-26 16:39:36 +00:00
tbf_timer_start(tbf, 3169, bts_data()->t3169, 0);
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
/* Increment RX-counter */
tbf->dir.ul.rx_counter++;
/* current block relative to lowest unreceived block */
offset_v_q = (rh->bsn - tbf->dir.ul.v_q) & mod_sns;
/* If out of window (may happen if blocks below V(Q) are received
* again. */
if (offset_v_q >= tbf->ws) {
LOGP(DRLCMACUL, LOGL_DEBUG, "- BSN %d out of window "
"%d..%d (it's normal)\n", rh->bsn, tbf->dir.ul.v_q,
(tbf->dir.ul.v_q + tbf->ws - 1) & mod_sns);
return 0;
}
/* Write block to buffer and set receive state array. */
index = rh->bsn & mod_sns_half; /* memory index of block */
memcpy(tbf->rlc_block[index], data, len); /* Copy block. */
tbf->rlc_block_len[index] = len;
tbf->dir.ul.v_n[index] = 'R'; /* Mark received block. */
LOGP(DRLCMACUL, LOGL_DEBUG, "- BSN %d storing in window (%d..%d)\n",
rh->bsn, tbf->dir.ul.v_q,
(tbf->dir.ul.v_q + tbf->ws - 1) & mod_sns);
/* Raise V(R) to highest received sequence number not received. */
offset_v_r = (rh->bsn + 1 - tbf->dir.ul.v_r) & mod_sns;
if (offset_v_r < (tbf->sns >> 1)) { /* Positive offset, so raise. */
while (offset_v_r--) {
if (offset_v_r) /* all except the received block */
tbf->dir.ul.v_n[tbf->dir.ul.v_r & mod_sns_half]
= 'N'; /* Mark block as not received */
tbf->dir.ul.v_r = (tbf->dir.ul.v_r + 1) & mod_sns;
/* Inc V(R). */
}
LOGP(DRLCMACUL, LOGL_DEBUG, "- Raising V(R) to %d\n",
tbf->dir.ul.v_r);
}
pdch/tbf: Add another todo item for badly placed code...
2013-10-26 17:05:42 +00:00
#warning "Move to TBF and remove the index side effect.."
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
/* Raise V(Q) if possible, and retrieve LLC frames from blocks.
* This is looped until there is a gap (non received block) or
* the window is empty.*/
while (tbf->dir.ul.v_q != tbf->dir.ul.v_r && tbf->dir.ul.v_n[
(index = tbf->dir.ul.v_q & mod_sns_half)] == 'R') {
LOGP(DRLCMACUL, LOGL_DEBUG, "- Taking block %d out, raising "
"V(Q) to %d\n", tbf->dir.ul.v_q,
(tbf->dir.ul.v_q + 1) & mod_sns);
/* get LLC data from block */
tbf->assemble_forward_llc(tbf->rlc_block[index], tbf->rlc_block_len[index]);
/* raise V(Q), because block already received */
tbf->dir.ul.v_q = (tbf->dir.ul.v_q + 1) & mod_sns;
}
/* Check CV of last frame in buffer */
if (tbf->state_is(GPRS_RLCMAC_FLOW) /* still in flow state */
&& tbf->dir.ul.v_q == tbf->dir.ul.v_r) { /* if complete */
struct rlc_ul_header *last_rh = (struct rlc_ul_header *)
tbf->rlc_block[(tbf->dir.ul.v_r - 1) & mod_sns_half];
LOGP(DRLCMACUL, LOGL_DEBUG, "- No gaps in received block, "
"last block: BSN=%d CV=%d\n", last_rh->bsn,
last_rh->cv);
if (last_rh->cv == 0) {
LOGP(DRLCMACUL, LOGL_DEBUG, "- Finished with UL "
"TBF\n");
tbf_new_state(tbf, GPRS_RLCMAC_FINISHED);
/* Reset N3103 counter. */
tbf->dir.ul.n3103 = 0;
}
}
/* If TLLI is included or if we received half of the window, we send
* an ack/nack */
if (rh->si || rh->ti || tbf->state_is(GPRS_RLCMAC_FINISHED)
|| (tbf->dir.ul.rx_counter % SEND_ACK_AFTER_FRAMES) == 0) {
if (rh->si) {
LOGP(DRLCMACUL, LOGL_NOTICE, "- Scheduling Ack/Nack, "
"because MS is stalled.\n");
}
if (rh->ti) {
LOGP(DRLCMACUL, LOGL_DEBUG, "- Scheduling Ack/Nack, "
"because TLLI is included.\n");
}
if (tbf->state_is(GPRS_RLCMAC_FINISHED)) {
LOGP(DRLCMACUL, LOGL_DEBUG, "- Scheduling Ack/Nack, "
"because last block has CV==0.\n");
}
if ((tbf->dir.ul.rx_counter % SEND_ACK_AFTER_FRAMES) == 0) {
LOGP(DRLCMACUL, LOGL_DEBUG, "- Scheduling Ack/Nack, "
"because %d frames received.\n",
SEND_ACK_AFTER_FRAMES);
}
if (tbf->ul_ack_state == GPRS_RLCMAC_UL_ACK_NONE) {
#ifdef DEBUG_DIAGRAM
if (rh->si)
debug_diagram(bts->bts, tbf->diag, "sched UL-ACK stall");
if (rh->ti)
debug_diagram(bts->bts, tbf->diag, "sched UL-ACK TLLI");
if (tbf->state_is(GPRS_RLCMAC_FINISHED))
debug_diagram(bts->bts, tbf->diag, "sched UL-ACK CV==0");
if ((tbf->dir.ul.rx_counter % SEND_ACK_AFTER_FRAMES) == 0)
debug_diagram(bts->bts, tbf->diag, "sched UL-ACK n=%d",
tbf->dir.ul.rx_counter);
#endif
/* trigger sending at next RTS */
tbf->ul_ack_state = GPRS_RLCMAC_UL_ACK_SEND_ACK;
} else {
/* already triggered */
LOGP(DRLCMACUL, LOGL_DEBUG, "- Sending Ack/Nack is "
"already triggered, don't schedule!\n");
}
}
return 0;
}
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
/* Received Uplink RLC control block. */
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
int gprs_rlcmac_pdch::rcv_control_block(
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
bitvec *rlc_block, uint32_t fn)
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
{
int8_t tfi = 0; /* must be signed */
uint32_t tlli = 0;
struct gprs_rlcmac_tbf *tbf;
struct gprs_rlcmac_sba *sba;
int rc;
RlcMacUplink_t * ul_control_block = (RlcMacUplink_t *)talloc_zero(tall_pcu_ctx, RlcMacUplink_t);
LOGP(DRLCMAC, LOGL_DEBUG, "+++++++++++++++++++++++++ RX : Uplink Control Block +++++++++++++++++++++++++\n");
decode_gsm_rlcmac_uplink(rlc_block, ul_control_block);
LOGPC(DCSN1, LOGL_NOTICE, "\n");
LOGP(DRLCMAC, LOGL_DEBUG, "------------------------- RX : Uplink Control Block -------------------------\n");
switch (ul_control_block->u.MESSAGE_TYPE) {
case MT_PACKET_CONTROL_ACK:
tlli = ul_control_block->u.Packet_Control_Acknowledgement.TLLI;
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
tbf = bts()->tbf_by_poll_fn(fn, trx_no(), ts_no);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (!tbf) {
LOGP(DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with "
"unknown FN=%u TLL=0x%08x (TRX %d TS %d)\n",
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
fn, tlli, trx_no(), ts_no);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
break;
}
tfi = tbf->tfi;
if (tlli != tbf->tlli) {
LOGP(DRLCMAC, LOGL_INFO, "Phone changed TLLI to "
"0x%08x\n", tlli);
tbf->tlli = tlli;
}
LOGP(DRLCMAC, LOGL_DEBUG, "RX: [PCU <- BTS] TFI: %u TLLI: 0x%08x Packet Control Ack\n", tbf->tfi, tbf->tlli);
tbf->poll_state = GPRS_RLCMAC_POLL_NONE;
/* check if this control ack belongs to packet uplink ack */
if (tbf->ul_ack_state == GPRS_RLCMAC_UL_ACK_WAIT_ACK) {
LOGP(DRLCMAC, LOGL_DEBUG, "TBF: [UPLINK] END TFI: %u TLLI: 0x%08x \n", tbf->tfi, tbf->tlli);
tbf->ul_ack_state = GPRS_RLCMAC_UL_ACK_NONE;
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
debug_diagram(bts(), tbf->diag, "got CTL-ACK (fin)");
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if ((tbf->state_flags &
(1 << GPRS_RLCMAC_FLAG_TO_UL_ACK))) {
tbf->state_flags &=
~(1 << GPRS_RLCMAC_FLAG_TO_UL_ACK);
LOGP(DRLCMAC, LOGL_NOTICE, "Recovered uplink "
"ack for UL TBF=%d\n", tbf->tfi);
}
tbf_free(tbf);
break;
}
if (tbf->dl_ass_state == GPRS_RLCMAC_DL_ASS_WAIT_ACK) {
LOGP(DRLCMAC, LOGL_DEBUG, "TBF: [UPLINK] DOWNLINK ASSIGNED TFI: %u TLLI: 0x%08x \n", tbf->tfi, tbf->tlli);
/* reset N3105 */
tbf->n3105 = 0;
tbf->dl_ass_state = GPRS_RLCMAC_DL_ASS_NONE;
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
debug_diagram(bts(), tbf->diag, "got CTL-ACK DL-ASS");
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (tbf->direction == GPRS_RLCMAC_UL_TBF)
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
tbf = bts()->tbf_by_tlli(tbf->tlli,
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
GPRS_RLCMAC_DL_TBF);
if (!tbf) {
LOGP(DRLCMAC, LOGL_ERROR, "Got ACK, but DL "
"TBF is gone\n");
break;
}
tbf_new_state(tbf, GPRS_RLCMAC_FLOW);
/* stop pending assignment timer */
tbf: Move the timer routine into the class The timer is used for various timeouts and there is still external client code that is calling it. In a perfect world the client code would indicate that an event has happened and the internal timer will be stopped. The best compromise is the "stop_t3191" method. It allows to add semantic verification that the timer has been running.
2013-10-26 16:01:35 +00:00
tbf->stop_timer();
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if ((tbf->state_flags &
(1 << GPRS_RLCMAC_FLAG_TO_DL_ASS))) {
tbf->state_flags &=
~(1 << GPRS_RLCMAC_FLAG_TO_DL_ASS);
LOGP(DRLCMAC, LOGL_NOTICE, "Recovered downlink "
"assignment for DL TBF=%d\n", tbf->tfi);
}
tbf_assign_control_ts(tbf);
break;
}
if (tbf->ul_ass_state == GPRS_RLCMAC_UL_ASS_WAIT_ACK) {
LOGP(DRLCMAC, LOGL_DEBUG, "TBF: [DOWNLINK] UPLINK ASSIGNED TFI: %u TLLI: 0x%08x \n", tbf->tfi, tbf->tlli);
/* reset N3105 */
tbf->n3105 = 0;
tbf->ul_ass_state = GPRS_RLCMAC_UL_ASS_NONE;
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
debug_diagram(bts(), tbf->diag, "got CTL-AC UL-ASS");
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (tbf->direction == GPRS_RLCMAC_DL_TBF)
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
tbf = bts()->tbf_by_tlli(tbf->tlli,
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
GPRS_RLCMAC_UL_TBF);
if (!tbf) {
LOGP(DRLCMAC, LOGL_ERROR, "Got ACK, but UL "
"TBF is gone\n");
break;
}
tbf_new_state(tbf, GPRS_RLCMAC_FLOW);
if ((tbf->state_flags &
(1 << GPRS_RLCMAC_FLAG_TO_UL_ASS))) {
tbf->state_flags &=
~(1 << GPRS_RLCMAC_FLAG_TO_UL_ASS);
LOGP(DRLCMAC, LOGL_NOTICE, "Recovered uplink "
"assignment for UL TBF=%d\n", tbf->tfi);
}
tbf_assign_control_ts(tbf);
break;
}
LOGP(DRLCMAC, LOGL_ERROR, "Error: received PACET CONTROL ACK "
"at no request\n");
break;
case MT_PACKET_DOWNLINK_ACK_NACK:
tfi = ul_control_block->u.Packet_Downlink_Ack_Nack.DOWNLINK_TFI;
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
tbf = bts()->tbf_by_poll_fn(fn, trx_no(), ts_no);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (!tbf) {
LOGP(DRLCMAC, LOGL_NOTICE, "PACKET DOWNLINK ACK with "
"unknown FN=%u TFI=%d (TRX %d TS %d)\n",
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
fn, tfi, trx_no(), ts_no);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
break;
}
if (tbf->tfi != tfi) {
LOGP(DRLCMAC, LOGL_NOTICE, "PACKET DOWNLINK ACK with "
"wrong TFI=%d, ignoring!\n", tfi);
break;
}
tbf->state_flags |= (1 << GPRS_RLCMAC_FLAG_DL_ACK);
if ((tbf->state_flags & (1 << GPRS_RLCMAC_FLAG_TO_DL_ACK))) {
tbf->state_flags &= ~(1 << GPRS_RLCMAC_FLAG_TO_DL_ACK);
LOGP(DRLCMAC, LOGL_NOTICE, "Recovered downlink ack "
"for DL TBF=%d\n", tbf->tfi);
}
/* reset N3105 */
tbf->n3105 = 0;
tbf: Move the timer routine into the class The timer is used for various timeouts and there is still external client code that is calling it. In a perfect world the client code would indicate that an event has happened and the internal timer will be stopped. The best compromise is the "stop_t3191" method. It allows to add semantic verification that the timer has been running.
2013-10-26 16:01:35 +00:00
tbf->stop_t3191();
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
tlli = tbf->tlli;
LOGP(DRLCMAC, LOGL_DEBUG, "RX: [PCU <- BTS] TFI: %u TLLI: 0x%08x Packet Downlink Ack/Nack\n", tbf->tfi, tbf->tlli);
tbf->poll_state = GPRS_RLCMAC_POLL_NONE;
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
debug_diagram(bts(), tbf->diag, "got DL-ACK");
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
rc = gprs_rlcmac_downlink_ack(tbf,
ul_control_block->u.Packet_Downlink_Ack_Nack.Ack_Nack_Description.FINAL_ACK_INDICATION,
ul_control_block->u.Packet_Downlink_Ack_Nack.Ack_Nack_Description.STARTING_SEQUENCE_NUMBER,
ul_control_block->u.Packet_Downlink_Ack_Nack.Ack_Nack_Description.RECEIVED_BLOCK_BITMAP);
if (rc == 1) {
tbf_free(tbf);
break;
}
/* check for channel request */
if (ul_control_block->u.Packet_Downlink_Ack_Nack.Exist_Channel_Request_Description) {
LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF in ack "
"message, so we provide one:\n");
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
tbf_alloc_ul(bts_data(), tbf->trx_no, tbf->ms_class, tbf->tlli, tbf->ta, tbf);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
/* schedule uplink assignment */
tbf->ul_ass_state = GPRS_RLCMAC_UL_ASS_SEND_ASS;
}
break;
case MT_PACKET_RESOURCE_REQUEST:
if (ul_control_block->u.Packet_Resource_Request.ID.UnionType) {
tlli = ul_control_block->u.Packet_Resource_Request.ID.u.TLLI;
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
tbf = bts()->tbf_by_tlli(tlli, GPRS_RLCMAC_UL_TBF);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (tbf) {
LOGP(DRLCMACUL, LOGL_NOTICE, "Got RACH from "
"TLLI=0x%08x while UL TBF=%d still "
"exists. Killing pending DL TBF\n",
tlli, tbf->tfi);
tbf_free(tbf);
tbf = NULL;
}
if (!tbf) {
uint8_t ms_class = 0;
struct gprs_rlcmac_tbf *dl_tbf;
uint8_t ta;
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
if ((dl_tbf = bts()->tbf_by_tlli(tlli, GPRS_RLCMAC_DL_TBF))) {
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
LOGP(DRLCMACUL, LOGL_NOTICE, "Got RACH from "
"TLLI=0x%08x while DL TBF=%d still exists. "
"Killing pending DL TBF\n", tlli,
dl_tbf->tfi);
tbf_free(dl_tbf);
}
LOGP(DRLCMAC, LOGL_DEBUG, "MS requests UL TBF "
"in packet ressource request of single "
"block, so we provide one:\n");
sba/pdch: Use thepdch to look up a sba for a frame number
2013-10-26 16:56:43 +00:00
sba = bts()->sba()->find(this, fn);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (!sba) {
LOGP(DRLCMAC, LOGL_NOTICE, "MS requests UL TBF "
"in packet ressource request of single "
"block, but there is no resource request "
"scheduled!\n");
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
rc = bts()->timing_advance()->recall(tlli);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (rc >= 0)
ta = rc;
else
ta = 0;
} else {
ta = sba->ta;
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
bts()->timing_advance()->remember(tlli, ta);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
llist_del(&sba->list);
talloc_free(sba);
}
if (ul_control_block->u.Packet_Resource_Request.Exist_MS_Radio_Access_capability)
ms_class = Decoding::get_ms_class_by_capability(&ul_control_block->u.Packet_Resource_Request.MS_Radio_Access_capability);
if (!ms_class)
LOGP(DRLCMAC, LOGL_NOTICE, "MS does not give us a class.\n");
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
tbf = tbf_alloc_ul(bts_data(), trx_no(), ms_class, tlli, ta, NULL);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (!tbf)
break;
/* set control ts to current MS's TS, until assignment complete */
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
LOGP(DRLCMAC, LOGL_DEBUG, "Change control TS to %d until assinment is complete.\n", ts_no);
tbf->control_ts = ts_no;
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
/* schedule uplink assignment */
tbf->ul_ass_state = GPRS_RLCMAC_UL_ASS_SEND_ASS;
debug_diagram(bts->bts, tbf->diag, "Res. REQ");
break;
}
tfi = tbf->tfi;
} else {
if (ul_control_block->u.Packet_Resource_Request.ID.u.Global_TFI.UnionType) {
tfi = ul_control_block->u.Packet_Resource_Request.ID.u.Global_TFI.u.DOWNLINK_TFI;
tbf/pdch/bts: Move the tbf look-up by tfi into the BTS
2013-10-26 17:10:43 +00:00
tbf = bts()->tbf_by_tfi(tfi, trx_no(), GPRS_RLCMAC_DL_TBF);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (!tbf) {
LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESSOURCE REQ unknown downlink TBF=%d\n", tlli);
break;
}
} else {
tfi = ul_control_block->u.Packet_Resource_Request.ID.u.Global_TFI.u.UPLINK_TFI;
tbf/pdch/bts: Move the tbf look-up by tfi into the BTS
2013-10-26 17:10:43 +00:00
tbf = bts()->tbf_by_tfi(tfi, trx_no(), GPRS_RLCMAC_UL_TBF);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (!tbf) {
LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESSOURCE REQ unknown uplink TBF=%d\n", tlli);
break;
}
}
tlli = tbf->tlli;
}
LOGP(DRLCMAC, LOGL_ERROR, "RX: [PCU <- BTS] %s TFI: %u TLLI: 0x%08x FIXME: Packet ressource request\n", (tbf->direction == GPRS_RLCMAC_UL_TBF) ? "UL" : "DL", tbf->tfi, tbf->tlli);
break;
case MT_PACKET_MEASUREMENT_REPORT:
sba/pdch: Use thepdch to look up a sba for a frame number
2013-10-26 16:56:43 +00:00
sba = bts()->sba()->find(this, fn);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
if (!sba) {
LOGP(DRLCMAC, LOGL_NOTICE, "MS send measurement "
"in packet ressource request of single "
"block, but there is no resource request "
"scheduled!\n");
} else {
pdch: Remove the bts argument from rcv_control_block
2013-10-26 16:45:19 +00:00
bts()->timing_advance()->remember(ul_control_block->u.Packet_Measurement_Report.TLLI, sba->ta);
pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks.
2013-10-26 15:38:37 +00:00
llist_del(&sba->list);
talloc_free(sba);
}
gprs_rlcmac_meas_rep(&ul_control_block->u.Packet_Measurement_Report);
break;
default:
LOGP(DRLCMAC, LOGL_NOTICE, "RX: [PCU <- BTS] unknown control block received\n");
}
talloc_free(ul_control_block);
return 1;
}
pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF.
2013-10-26 15:32:04 +00:00
pdch: Move the dispatch of gprs_rlcmac_rcv_block into the pdch
2013-10-26 14:54:10 +00:00
/* received RLC/MAC block from L1 */
pdch: Instead of passing bts, trx, ts use the pdch All dispatching will go through the PDCH. This will clean a lot of the look-ups inside the gprs_rlcmac_data.c and continue with adding structure to the pcu code.
2013-10-26 14:42:38 +00:00
int gprs_rlcmac_pdch::rcv_block(uint8_t *data, uint8_t len, uint32_t fn, int8_t rssi)
{
pdch: Move the dispatch of gprs_rlcmac_rcv_block into the pdch
2013-10-26 14:54:10 +00:00
unsigned payload = data[0] >> 6;
bitvec *block;
int rc = 0;
switch (payload) {
case GPRS_RLCMAC_DATA_BLOCK:
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
rc = rcv_data_block_acknowledged(data, len, rssi);
pdch: Move the dispatch of gprs_rlcmac_rcv_block into the pdch
2013-10-26 14:54:10 +00:00
break;
case GPRS_RLCMAC_CONTROL_BLOCK:
block = bitvec_alloc(len);
if (!block)
return -ENOMEM;
bitvec_unpack(block, data);
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers.
2013-10-26 16:53:16 +00:00
rc = rcv_control_block(block, fn);
pdch: Move the dispatch of gprs_rlcmac_rcv_block into the pdch
2013-10-26 14:54:10 +00:00
bitvec_free(block);
break;
case GPRS_RLCMAC_CONTROL_BLOCK_OPT:
LOGP(DRLCMAC, LOGL_NOTICE, "GPRS_RLCMAC_CONTROL_BLOCK_OPT block payload is not supported.\n");
break;
default:
LOGP(DRLCMAC, LOGL_NOTICE, "Unknown RLCMAC block payload(%u).\n", payload);
rc = -EINVAL;
}
return rc;
pdch: Instead of passing bts, trx, ts use the pdch All dispatching will go through the PDCH. This will clean a lot of the look-ups inside the gprs_rlcmac_data.c and continue with adding structure to the pcu code.
2013-10-26 14:42:38 +00:00
}