osmo-msc/9428e1a8484f00d7f45e98fbc04...

68 lines
2.1 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "3f89f8ed_d64313dc",
"filename": "src/libmsc/codec_mapping.c",
"patchSetId": 1
},
"lineNbr": 8,
"author": {
"id": 1000004
},
"writtenOn": "2022-11-14T19:43:46Z",
"side": 1,
"message": "AGPL-3.0+",
"revId": "9428e1a8484f00d7f45e98fbc04a46bb25f26caa",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "18eb9461_d96d7db9",
"filename": "src/libmsc/codec_mapping.c",
"patchSetId": 1
},
"lineNbr": 29,
"author": {
"id": 1000010
},
"writtenOn": "2022-11-13T15:49:03Z",
"side": 1,
"message": "I don\u0027t know for sure what the \u0027O\u0027 means, but according to 3GPP TS 45.002, section 3.2.1, O-TCH/F and O-TCH/H are full/half rate channels employing 8-PSK modulation (on \"normal\" TCH channels it\u0027s GMSK). Perhaps \u0027O\u0027 means \u0027Octal\u0027? An 8-PSK modulated burst carries three times more bits than a GMSK modulated burst, so you basically get three times higher bit rate. If I remember correctly, such channels are used for AMR-WB (wide band).",
"range": {
"startLine": 29,
"startChar": 4,
"endLine": 29,
"endChar": 65
},
"revId": "9428e1a8484f00d7f45e98fbc04a46bb25f26caa",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "e90e76da_e2e57647",
"filename": "src/libmsc/codec_mapping.c",
"patchSetId": 1
},
"lineNbr": 29,
"author": {
"id": 1000004
},
"writtenOn": "2022-11-14T19:42:01Z",
"side": 1,
"message": "in any case, just to be clear: OFR/OHR are not supported in our stack so far.",
"parentUuid": "18eb9461_d96d7db9",
"range": {
"startLine": 29,
"startChar": 4,
"endLine": 29,
"endChar": 65
},
"revId": "9428e1a8484f00d7f45e98fbc04a46bb25f26caa",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}