111 lines
4.1 KiB
Plaintext
111 lines
4.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "db4f8ffe_cd2242fd",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-04-03T19:03:28Z",
|
|
"side": 1,
|
|
"message": "Fixes: ae98b97382285420ba81549bc874b9fea5e7daa9",
|
|
"revId": "c19f8fe917eedc095dbbac03a629307ef7f93c5a",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "38ec6d3f_8a242e2c",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-03T23:27:07Z",
|
|
"side": 1,
|
|
"message": "never seen this header pointing at a commit hash before. \"Fixes:\" is about issue numbers. AFAIK we hardly ever use this header. I\u0027ve never used it before and it has not been indicated that i should, so where is this coming from?",
|
|
"parentUuid": "db4f8ffe_cd2242fd",
|
|
"revId": "c19f8fe917eedc095dbbac03a629307ef7f93c5a",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "75f1c51f_e5e2f42d",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-04-04T11:03:47Z",
|
|
"side": 1,
|
|
"message": "This is super usual in projects such as linux kernel, see:\n\n git log | grep \"^Fixes: \"\n \nThis is useful to programatically find fixes for a commit you are eg. cherry-picking into another (stable) branch.\n\nI tend to use it when I\u0027m fixing some bug and the patch causing it is known.",
|
|
"parentUuid": "38ec6d3f_8a242e2c",
|
|
"revId": "c19f8fe917eedc095dbbac03a629307ef7f93c5a",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ae0c33e2_bd6ef57a",
|
|
"filename": "src/libmsc/msc_a.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-04-03T19:03:28Z",
|
|
"side": 1,
|
|
"message": "Can we please try refactoring this function? I see \"if (conn_accepted)\" spread like in 4 different places now.\nWithout knowing this, code, looks like stuff could be moved around to really simplify the logic here.\nThat would have probably also helped back in time when the bug was introduced.",
|
|
"revId": "c19f8fe917eedc095dbbac03a629307ef7f93c5a",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1e89b76a_e1b1e176",
|
|
"filename": "src/libmsc/msc_a.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-03T23:27:07Z",
|
|
"side": 1,
|
|
"message": "the argument goes both ways. if you prefer the other way, then i guess you can suggest a refactoring. i\u0027m not going to spend time on it, because IMHO this is bad style:\n\n if (conn_accepted) {\n update_counters(fi, true);\n ...\n } else {\n update_counters(fi, false);\n ...\n }\n \ninstead of just\n\n update_counters(fi, conn_accepted);\n \nas we have now.\n\nresolving because it\u0027s about code prior to this patch.",
|
|
"parentUuid": "ae0c33e2_bd6ef57a",
|
|
"revId": "c19f8fe917eedc095dbbac03a629307ef7f93c5a",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "80bb0660_a2739f1f",
|
|
"filename": "src/libmsc/msc_a.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 165,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2024-04-03T23:31:29Z",
|
|
"side": 1,
|
|
"message": "and because it\u0027s a bikeshed not even about the current patch, SCNR \u003d)",
|
|
"parentUuid": "1e89b76a_e1b1e176",
|
|
"revId": "c19f8fe917eedc095dbbac03a629307ef7f93c5a",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
],
|
|
"submitRequirementResults": []
|
|
} |