109 lines
3.7 KiB
Plaintext
109 lines
3.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "40c6667a_1ef67a3c",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-12T14:00:22Z",
|
|
"side": 1,
|
|
"message": "Did you think about",
|
|
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "66f0fe9d_3aafa16c",
|
|
"filename": "src/libvlr/vlr_access_req_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 662,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-12T14:00:22Z",
|
|
"side": 1,
|
|
"message": "did you think about adding a check for \"(!try_ciphering \u0026\u0026 ciphering_required)\" ? Because if you get that here it already means something is wrong in config and can be rejected?",
|
|
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c755ddfa_44b9aee2",
|
|
"filename": "src/libvlr/vlr_access_req_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 662,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2022-10-26T16:03:28Z",
|
|
"side": 1,
|
|
"message": "it can never happen, see the callers in gsm_04_08.c. But i can add an assert.\n\nin general, we don\u0027t assert / guard against everything in non-public API, otherwise we would have e.g. assertions for non-NULL pointers absolutely everywhere.\nit makes sense to not clutter the code with code paths that can never happen.",
|
|
"parentUuid": "66f0fe9d_3aafa16c",
|
|
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3d433852_efe60f0c",
|
|
"filename": "src/libvlr/vlr_access_req_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 662,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:12:50Z",
|
|
"side": 1,
|
|
"message": "Yeah I meant an assert for instance.\nAs you want, I think it also makes easier to understand certain conditions are not to be taken into account when looking at code.",
|
|
"parentUuid": "c755ddfa_44b9aee2",
|
|
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "704a92da_59e410d0",
|
|
"filename": "src/libvlr/vlr_lu_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 1479,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-12T15:08:28Z",
|
|
"side": 1,
|
|
"message": "Comment explaining the difference between try_ciphering and ciphering_required would be helpful: it\u0027s not obvious that it\u0027s explained in the commit message for one of those flags.",
|
|
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "6b71d232_2963348d",
|
|
"filename": "src/libvlr/vlr_lu_fsm.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 1479,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2022-10-27T10:37:08Z",
|
|
"side": 1,
|
|
"message": "I think the variable/argument names are rather clear (now)",
|
|
"parentUuid": "704a92da_59e410d0",
|
|
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |