osmo-msc/3311ce84a92f876586fc3f8b941...

57 lines
1.7 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "e184c39d_77447f8b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-12T14:03:13Z",
"side": 1,
"message": "I find all this \"try\" names really misleading, as it seems the function is doing some sort of action \"try do this\".",
"revId": "3311ce84a92f876586fc3f8b94102ba75a54f05a",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "2f771522_6373eb41",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000005
},
"writtenOn": "2022-10-26T16:05:34Z",
"side": 1,
"message": "hm that\u0027s true, what naming do you suggest?",
"parentUuid": "e184c39d_77447f8b",
"revId": "3311ce84a92f876586fc3f8b94102ba75a54f05a",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "af84d35e_7aff5407",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:16:14Z",
"side": 1,
"message": "you changed is_cmc_smc_required -\u003e try_cmc_smc.\nWhat about is_cmc_smc_required -\u003e is_cmc_smc_to_be_requested?\nOr \"is_cmc_smc_to_be_attempted\".\nI know they are long but they are far more understandable.",
"parentUuid": "2f771522_6373eb41",
"revId": "3311ce84a92f876586fc3f8b94102ba75a54f05a",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}