250 lines
7.6 KiB
Plaintext
250 lines
7.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "84078fec_c7fe2773",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 163,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-01T09:17:06Z",
|
|
"side": 1,
|
|
"message": "Not sure what doyouwin with this change here. In fact, it looks more confusing.",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4b37e93c_e70e7273",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 163,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-08-05T15:44:39Z",
|
|
"side": 1,
|
|
"message": "See the follow-up comment.",
|
|
"parentUuid": "84078fec_c7fe2773",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f40092de_aad2f148",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 242,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-01T09:17:06Z",
|
|
"side": 1,
|
|
"message": "Sound like you want to move this block to some API to free the \"struct esme\" and put it by the side of the struct definition.",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b5393444_d82d7513",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 242,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-08-05T15:44:39Z",
|
|
"side": 1,
|
|
"message": "Yes, the common part is in \"struct_esme\" while the MSC-specific parts are in \"struct osmo_esme\" which now includes the link (*esme) to it.",
|
|
"parentUuid": "f40092de_aad2f148",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "892fd606_e03b5193",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 330,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-01T09:17:06Z",
|
|
"side": 1,
|
|
"message": "IIUC this calls can go now to some other file containing \"struct esme\" APIs.",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "91e052d1_e49d17ab",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 330,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-08-05T15:44:39Z",
|
|
"side": 1,
|
|
"message": "They will in a follow-up patch. I\u0027ve decided to split renaming into separate patch to make it easier to review.",
|
|
"parentUuid": "892fd606_e03b5193",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7e0aada6_1c683ad9",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 384,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-01T09:17:06Z",
|
|
"side": 1,
|
|
"message": "this can be probably changed to \"struct esme\"",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ea2debab_e0f654c2",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 384,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-08-05T15:44:39Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "7e0aada6_1c683ad9",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1f4dc500_2077f7eb",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 864,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-01T09:17:06Z",
|
|
"side": 1,
|
|
"message": "THis can be moved to a \"struct esme\" API in a different file?",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "dda4375e_653ef377",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 864,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-08-05T15:44:39Z",
|
|
"side": 1,
|
|
"message": "It\u0027ll be removed in follow-up patch as part of migration to libosmo-netif",
|
|
"parentUuid": "1f4dc500_2077f7eb",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "594105a8_6c8e0bb4",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 895,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-01T09:17:06Z",
|
|
"side": 1,
|
|
"message": "Move to a different \"struct esme\" API? esme_init()",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "16bcf348_a9655ed0",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 895,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-08-05T15:50:32Z",
|
|
"side": 1,
|
|
"message": "ESME stands for External Short Message Entities so it\u0027s tied to the SMPP connection. I can move it to esme_init() but I don\u0027t see any benefits since the only caller would be this callback anyway.",
|
|
"parentUuid": "594105a8_6c8e0bb4",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "03cac104_84808772",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 895,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-08-05T16:06:18Z",
|
|
"side": 1,
|
|
"message": "If there\u0027s only a user of the struct emse struct then I\u0027m not sure I\u0027m following the need to move it into an own library.\nIf you are moving it to a libray for whatever reason, I\u0027d expect to move/enclose as much implementation in there, not do it only half way.",
|
|
"parentUuid": "16bcf348_a9655ed0",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "45556b44_66b8fbe9",
|
|
"filename": "src/libmsc/smpp_smsc.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 895,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-08-08T09:07:42Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "03cac104_84808772",
|
|
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |