672 lines
20 KiB
Plaintext
672 lines
20 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7ebe887b_ad124956",
|
|
"filename": "src/libsmpputil/smpp_msc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 847,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "why is this check added now?",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3fa9e4c2_f44d41de",
|
|
"filename": "src/libsmpputil/smpp_msc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 847,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T14:36:06Z",
|
|
"side": 1,
|
|
"message": "Hmm.. yepp, it can be dropped.",
|
|
"parentUuid": "7ebe887b_ad124956",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "827d4d94_8a9fb4fe",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 238,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "how can use be negative?",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b2de89d6_568ed65c",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 238,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T16:05:58Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "827d4d94_8a9fb4fe",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f2536112_0b0eb65f",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 347,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "not return value to check?",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "93570318_5cef1c82",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 347,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T14:56:26Z",
|
|
"side": 1,
|
|
"message": "Yes?",
|
|
"parentUuid": "f2536112_0b0eb65f",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b572a5a8_fa3652fe",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 760,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "you are casting unsigned long to \"uint32_t\". Better keep unsigned long?",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bd987a53_ba352839",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 760,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T14:36:06Z",
|
|
"side": 1,
|
|
"message": "I think it\u0027s better to use the type which matches exactly the size from SMPP spec - 4 bytes.",
|
|
"parentUuid": "b572a5a8_fa3652fe",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "13927ea8_da495010",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 772,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "move the commend in the line above better.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "77b679c0_ace97187",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 772,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T14:56:26Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "13927ea8_da495010",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4f744e45_a7e2c84e",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 775,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "does msgb_reset also clear esme-\u003eread_msg-\u003ecb[0]? we need to ensure it is 0 here.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cfac68ba_d4b88654",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 775,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T14:56:26Z",
|
|
"side": 1,
|
|
"message": "It does.",
|
|
"parentUuid": "4f744e45_a7e2c84e",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "17cf7e74_3916a0a6",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 791,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "why are you returning -EBADF here if the fd is not closed? This is wrong.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e8cd7473_39bf61fa",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 791,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:11:27Z",
|
|
"side": 1,
|
|
"message": "Which value would you prefer?",
|
|
"parentUuid": "17cf7e74_3916a0a6",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "87acba4a_fdaf05b6",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 791,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-27T15:34:48Z",
|
|
"side": 1,
|
|
"message": "whatever not -EBADF, which has a special meaning in osmocom ofd callbacks (means not to continue using the fd after returning from the callback in the event the READ and WRITE events are flagged).",
|
|
"parentUuid": "e8cd7473_39bf61fa",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5a0fbee5_158f3b3c",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 791,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:46:54Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "87acba4a_fdaf05b6",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ccc7f6e3_f2d1eb1a",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 799,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "This whole block can be moved under the \"esme-\u003eread_msg-\u003ecb[0] \u003d smpp_size;\" statement above, then it is only checked once instead of each time we receive data and the code is clear.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b975f9bb_a81c7633",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 799,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T16:05:58Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "ccc7f6e3_f2d1eb1a",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9a159fd7_4a7055a7",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 803,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "unable to resize message buffer to %u bytes.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4db9f2a0_9b507368",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 803,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:11:27Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "9a159fd7_4a7055a7",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fddefff1_066f7386",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 825,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "Do we really need a second level callback function? Why not merging this function and the one above and have a goto path for the error paths as we usually do?\nI was first confused because you were returning -EBADF in the read callback function above.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ceeb2be8_9ad8ceda",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 825,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:46:54Z",
|
|
"side": 1,
|
|
"message": "Indeed, better rename it and make static. Though I think it\u0027s better to keep it as a separate function since it makes it easier to read.",
|
|
"parentUuid": "fddefff1_066f7386",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "86f1073a_4fa4d24e",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 843,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "wrong indentation.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "76a34670_78ce7a6b",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 843,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:11:27Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "86f1073a_4fa4d24e",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d6084949_932b6847",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 851,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "I foresee some problems with this and esme_destroy. I\u0027ll look at it closly when you fix the other stuff.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "16c3bf07_cdb7dc48",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 851,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:11:27Z",
|
|
"side": 1,
|
|
"message": "Could you formulate them as unit/ttcn3 test? That would be most helpful.",
|
|
"parentUuid": "d6084949_932b6847",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9fe1950c_2c4962e0",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 949,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "This should be improve in a follow up patch to probably pass NULL instead of \"0.0.0.0\" in order to support IPv6.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4930c917_0d8811c2",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 949,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:11:27Z",
|
|
"side": 1,
|
|
"message": "Agree but I think it\u0027s better to track IPv6 support via separate ticket. I\u0027m pretty sure it\u0027ll require more than 1-line change.",
|
|
"parentUuid": "9fe1950c_2c4962e0",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c6874098_3d2eeea5",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 949,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-27T15:34:48Z",
|
|
"side": 1,
|
|
"message": "Ack",
|
|
"parentUuid": "4930c917_0d8811c2",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "98f9e91f_48ea9cfa",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 985,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "you most probably want to set sms-\u003elink\u003dNULL here from code I saw above.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f914e08c_49c1f6fa",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 985,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:11:27Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "98f9e91f_48ea9cfa",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4c943b1f_19391996",
|
|
"filename": "src/libsmpputil/smpp_smsc.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 985,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:46:54Z",
|
|
"side": 1,
|
|
"message": "Actually, assigning NULL in here breaks the ext tests.",
|
|
"parentUuid": "f914e08c_49c1f6fa",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1998658e_38c5f2af",
|
|
"filename": "src/libsmpputil/smpp_vty.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 83,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "Idea: You can probably add an smsc_is_running() API or whatever which checks this internally.",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "beb57292_189b425c",
|
|
"filename": "src/libsmpputil/smpp_vty.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 83,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:20:37Z",
|
|
"side": 1,
|
|
"message": "Sure, if it was used more than once. For a single call I don\u0027t think it\u0027s worth it.",
|
|
"parentUuid": "1998658e_38c5f2af",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b1a08b27_fc25b615",
|
|
"filename": "src/libsmpputil/smpp_vty.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 190,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-26T16:39:14Z",
|
|
"side": 1,
|
|
"message": "I wonder why do we want to have listen_port set to 0 at any time, why not set it to SMPP_PORT by default?",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1491977c_8ebd6fc6",
|
|
"filename": "src/libsmpputil/smpp_vty.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 190,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T15:20:37Z",
|
|
"side": 1,
|
|
"message": "I think there were some odd corner case where we couldn\u0027t distinguish between user not setting port in config and user setting port to default value and it broke vty tests.",
|
|
"parentUuid": "b1a08b27_fc25b615",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d22ec4a2_c356af4f",
|
|
"filename": "src/libsmpputil/smpp_vty.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 190,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-27T15:34:48Z",
|
|
"side": 1,
|
|
"message": "not sure how that would break VTY tests. If user doesn\u0027t set it, then default port should be used.",
|
|
"parentUuid": "1491977c_8ebd6fc6",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0c26441a_f6b9ed37",
|
|
"filename": "src/libsmpputil/smpp_vty.c",
|
|
"patchSetId": 49
|
|
},
|
|
"lineNbr": 190,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-27T16:07:51Z",
|
|
"side": 1,
|
|
"message": "Fine by me. Add me as reviewer if you decide to implement this.",
|
|
"parentUuid": "d22ec4a2_c356af4f",
|
|
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |