cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity
osmo-msc/src/libvlr
History
Neels Hofmeyr fa391ee86c vlr_access_req_fsm.c: use osmo_strlcpy and avoid compiler error 
gcc 8.1.0:
../../../../src/osmo-msc/src/libvlr/vlr_access_req_fsm.c:679:3: error: ‘strncpy’ output may be truncated copying 15 bytes from a string of length 31 [-Werror=stringop-truncation]
   strncpy(par->imsi, mi_string, sizeof(par->imsi)-1);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The Mobile Identity is a union of various kinds, but the IMSI is at most 15
digits, so truncation is "intended". I hope other layers validate the correct
length of an IMSI MI.

Change-Id: I0a17a188fc91e42e252ae4bf1d6cd0bf0e5eb077
 		2018-07-26 20:31:55 +02:00
..
Makefile.am cosmetic: use enum ranap_nsap_addr_enc instead of int 2018-04-16 01:50:46 +02:00
vlr.c VLR: reject overlong IMSIs in ID RESP messages 2018-06-25 19:21:57 +00:00
vlr_access_req_fsm.c vlr_access_req_fsm.c: use osmo_strlcpy and avoid compiler error 2018-07-26 20:31:55 +02:00
vlr_access_req_fsm.h Add libvlr implementation 2017-07-21 18:32:03 +02:00
vlr_auth_fsm.c refactor VLR FSM result handling 2018-04-12 19:40:00 +00:00
vlr_auth_fsm.h refactor VLR FSM result handling 2018-04-12 19:40:00 +00:00
vlr_core.h GSUP: check osmo_gsup_encode() result 2018-02-08 09:29:50 +00:00
vlr_lu_fsm.c implement periodic Location Update expiry in the VLR 2018-05-23 14:55:00 +02:00
vlr_lu_fsm.h Add libvlr implementation 2017-07-21 18:32:03 +02:00