Commit Graph

827 Commits

Author SHA1 Message Date
Harald Welte 3e0f6173f1 some more comments 2009-07-09 23:52:59 +02:00
Holger Hans Peter Freyther 3d57183910 abis_rsl.c: Clarify from which specification this table comes from
It appears to be the table of TS 05.02.
2009-07-09 20:43:16 +02:00
Holger Hans Peter Freyther fe1afedfb9 Merge branch 'holger/ipacess' 2009-07-09 00:16:29 +02:00
Holger Hans Peter Freyther a7cd9fc0d1 ipacess-config: Handle NVATTR NACKs in ipaccess-config
Currently we send the attribute changes in a send and forget
fashion. But sometimes the nanoBTS is sending us a NACK, e.g
with a invalid unit id. Start handling the NACK and provide
an error message to the user. The error message is not yet
describing the cause of the error but this is a slight progress
to the previous silent failure.
2009-07-08 23:13:58 +02:00
Harald Welte d5651d5ced Merge commit 'origin/master' 2009-07-05 14:19:06 +02:00
Harald Welte f0465bd6cb Merge branch 'master' into sms 2009-07-05 14:10:01 +02:00
Harald Welte c2e302dc84 Store classmark1/2/3 in equipment SQL table
For further evaluation/analysis, this patch stores the classmark 1, 2 and 3
values of every equipment in the SQL database.  We can use this non-volatile
data to determine the supported features for each handset that we've ever
seen on our network.
2009-07-05 14:08:13 +02:00
Harald Welte be3e3784dc further SMS work
* implement ID based lookup of gsm_subscriber from database
* look-up recipient and sender subscribers from database
2009-07-05 14:06:41 +02:00
Harald Welte 51cda55981 remove unused variable 2009-07-05 14:05:30 +02:00
Harald Welte b9c758b2ac more SMS improvements
* describe data structures in gsm_04_11.h
* increae LCHAN RELEASE TIMEOUT for case of long SMS
* convert header field in sql table from NUMERIC to BLOB
* initial handling for validity period
* send RP ERROR messages with meaningful RP CAUSE in case of error
2009-07-05 14:02:46 +02:00
Harald Welte 53833f6fd8 remove SI3 and SI4 rest octets
As Dieter has pointed out, we currently send incorrect information
in the rest octets, particularly about our GPRS capability.  Since
the format of the rest octets is highly complex, and we don't
actually need any of those features yet, we might just fill them
with padding.
2009-07-05 13:41:40 +02:00
Harald Welte 5a691b5290 fix measurement report parsing of MEAS VALID logic
As Dieter points out, the logic level is inverted. 0 means valid.
2009-07-05 04:05:44 +02:00
Harald Welte 87f5d637c5 more layering /abstraction of sms protocol 2009-07-04 17:39:00 +02:00
Holger Hans Peter Freyther 42b40072dc ipaccess-config: Add --help to the ipaccess-config
Just a beginning...
2009-07-04 11:53:10 +02:00
Harald Welte 6c1a21367b Merge branch 'master' into sms 2009-07-04 10:38:11 +02:00
Harald Welte 24516ea2d6 make sure we always schedule a location updating reject
IT sems that if a MS uses the TMSI of a previous network, we did not start
the reject timer.  Thanks to Andreas Eversberg.
2009-07-04 10:18:00 +02:00
Harald Welte 4a3464c565 remove bogus extra check for data->imsi[0] in mncc_send
As Andreas points out, we already check for this condition some 10 lines
below, no need to check twice.
2009-07-04 10:11:24 +02:00
Harald Welte 73be3aafec remove superfluous check for lchan->use > 0
If we receive one of those strange BS-11 "Cause 22" errors,  we don't need
to check if the lchan use counter is > 0.  If it was 0, the lchan gets
released anyway.
2009-07-04 10:05:51 +02:00
Harald Welte 81543bcdd2 release channel on ERROR INDICATION
This was proposed by Andreas Eversberg.  I made it conditional on the T200
timer expired cause, as I'm not sure if we really should give up that quickly
on other errors such as just simply receiving an unsolicited response.
2009-07-04 09:40:05 +02:00
Harald Welte 1a5c6bd88c gsm48 lchan signal handling: use correct pointer
As Andreas Eversberg has pointed out, we need to use signal_data
rather than handler_data.
2009-07-04 09:35:21 +02:00
Harald Welte dd2b434b20 make sure misdn plugin handles DL_UNITDATA_IND
This reportedly fixes the problem that we didn't see MEASurement REPort
messages from the BS-11.
2009-07-04 09:28:00 +02:00
Harald Welte 8a396b73e1 Merge branch 'master' into sms 2009-07-04 09:21:47 +02:00
Harald Welte 63aba29ef7 update wireshark patches to current svn (28938) 2009-07-04 04:11:21 +02:00
Harald Welte 450129f72e support parsing of ip.access 12.21 test reports 2009-07-03 12:46:47 +02:00
Harald Welte a0c0b57c28 add more TLV parser definitiosn for IPA NM attributes 2009-07-03 12:46:27 +02:00
Harald Welte 684b1a875a add code to ipaccess-config set nanoBST NVRAM attributes 2009-07-03 11:26:45 +02:00
Harald Welte 1cc3fa8102 wireshark: more work on completing abis_oml plugin 2009-07-01 17:43:36 +02:00
Harald Welte 89cdce2ec0 Merge branch 'master' into sms 2009-07-01 16:57:39 +02:00
Harald Welte 1a9913060f Merge branch 'master' of gitosis@bs11-abis.gnumonks.org:openbsc 2009-07-01 11:24:18 +02:00
Harald Welte 8dc1a6811e updated version of wireshark ipaccess RSL plugin (just cosmetic changes) 2009-07-01 11:22:01 +02:00
Harald Welte 9446d329f0 ip.access test numbers 2009-07-01 11:03:54 +02:00
Harald Welte d2f11f2923 add more ipaccess 12.21 OML extension definitions 2009-07-01 09:56:21 +02:00
Andreas Eversberg 8226fa7016 the pointer "tall_bsc_ctx" belongs to the gsm_data.c file not to include file. 2009-06-29 15:19:38 +02:00
Harald Welte 7b98d1336e Merge branch 'master' of gitosis@bs11-abis.gnumonks.org:openbsc 2009-06-29 13:07:06 +02:00
Harald Welte 042401c627 ipaccess-find: remove compile-time specified local ip address 2009-06-29 10:43:04 +02:00
Harald Welte eab33356d0 fix various RSL msgb memory leaks in error paths 2009-06-27 03:09:53 +02:00
Harald Welte a0368540ab cosmetic cleanup of LOCATION UPDATE REQ print-out 2009-06-27 03:09:45 +02:00
Harald Welte 10d0e67e2c add new DMEAS debug category for measurement reporting
disable it by default
2009-06-27 03:09:38 +02:00
Harald Welte a39c689f96 fix various RSL msgb memory leaks in error paths 2009-06-27 03:09:08 +02:00
Harald Welte dd1ae39641 cosmetic cleanup of LOCATION UPDATE REQ print-out 2009-06-27 02:58:43 +02:00
Harald Welte dfeaf18472 add new DMEAS debug category for measurement reporting
disable it by default
2009-06-27 02:53:10 +02:00
Harald Welte 53888bfd6c Merge branch 'master' into sms
Conflicts:
	openbsc/include/openbsc/gsm_data.h
	openbsc/src/bsc_hack.c
	openbsc/src/vty_interface.c
2009-06-26 20:34:09 +02:00
Harald Welte 6bfda782b9 make tests compile again after talloc branch changes 2009-06-26 20:30:46 +02:00
Harald Welte 470ec29b0d use taloc_zero() rather than talloc() and explisit memset() 2009-06-26 20:25:23 +02:00
Harald Welte c05677b036 fix two segfaults
* when paging callback is called, we need to consider a failed paging
  operation (i.e. lchan == NULL)
* we have to zero-initialize every transaction that is allocated
2009-06-26 20:17:06 +02:00
Harald Welte 9b11e8741d zero-initialize some more memory that we allocate 2009-06-26 19:42:28 +02:00
Harald Welte 678bdeac1f add FIXME about memory leak every time we close telnet 2009-06-26 19:42:14 +02:00
Harald Welte 316c825fcd fix MNCC memory leak
after passing the mncc structure (contained in msgb) to the mncc layer,
we have to release its memory.  This leak was discovered as a direct result of
using talloc.
2009-06-26 19:40:48 +02:00
Harald Welte 966636f39f use named variant when allocating msgb's
when we generate a talloc report (SIGUSR1), we can now see which system
allocated a given msgb, this helps memory leak debugging
2009-06-26 19:39:35 +02:00
Harald Welte f16571635a Merge branch 'master' into talloc 2009-06-26 18:19:53 +02:00