Update patch set 15

Patch Set 15:

(1 comment)

Patch-set: 15
This commit is contained in:
Gerrit User 1000159 2022-08-05 15:50:32 +00:00 committed by Gerrit Code Review
parent 2b8b75bd4c
commit f557b2df8e
1 changed files with 18 additions and 0 deletions

View File

@ -191,6 +191,24 @@
"message": "Move to a different \"struct esme\" API? esme_init()",
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "16bcf348_a9655ed0",
"filename": "src/libmsc/smpp_smsc.c",
"patchSetId": 7
},
"lineNbr": 895,
"author": {
"id": 1000159
},
"writtenOn": "2022-08-05T15:50:32Z",
"side": 1,
"message": "ESME stands for External Short Message Entities so it\u0027s tied to the SMPP connection. I can move it to esme_init() but I don\u0027t see any benefits since the only caller would be this callback anyway.",
"parentUuid": "594105a8_6c8e0bb4",
"revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}