cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2: Code-Review+2

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+2
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Someone else replied on a comment you posted"}
This commit is contained in:
Gerrit User 1000004 2022-10-27 10:37:08 +00:00 committed by Gerrit Code Review
parent 49269915cc
commit e29a114633
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
59d74b3956772e07becca87cd3dd7f9848c48d8c
View File

@ -86,6 +86,24 @@
"message": "Comment explaining the difference between try_ciphering and ciphering_required would be helpful: it\u0027s not obvious that it\u0027s explained in the commit message for one of those flags.",
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "6b71d232_2963348d",
"filename": "src/libvlr/vlr_lu_fsm.c",
"patchSetId": 1
},
"lineNbr": 1479,
"author": {
"id": 1000004
},
"writtenOn": "2022-10-27T10:37:08Z",
"side": 1,
"message": "I think the variable/argument names are rather clear (now)",
"parentUuid": "704a92da_59e410d0",
"revId": "59d74b3956772e07becca87cd3dd7f9848c48d8c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}