cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 20 

Patch Set 20:

(2 comments)

Patch-set: 20
Label: Code-Review=0
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"neels replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"}
This commit is contained in:
Gerrit User 1000005 2022-09-13 21:43:58 +00:00 committed by Gerrit Code Review
parent b0ec3ab7ac
commit d9f5d0738e
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
23a00eb820e440d3fcb2bea87afd90fd24329777
View File

@ -17,6 +17,24 @@
"revId": "23a00eb820e440d3fcb2bea87afd90fd24329777",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "a92f05af_e8da2e61",
"filename": "include/osmocom/smpp/smpp.h",
"patchSetId": 19
},
"lineNbr": 14,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-13T21:43:58Z",
"side": 1,
"message": "does that mean you disagree here?",
"parentUuid": "75e5796c_038ce042",
"revId": "23a00eb820e440d3fcb2bea87afd90fd24329777",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -52,6 +70,24 @@
"revId": "23a00eb820e440d3fcb2bea87afd90fd24329777",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "b06a9b74_d636e9bd",
"filename": "include/osmocom/smpp/smpp_smsc.h",
"patchSetId": 19
},
"lineNbr": 32,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-13T21:43:58Z",
"side": 1,
"message": "there is a point at which hiding struct details is more of a hindrance than helping. When a struct is not public API of a library, IMHO it is better to openly share the structs than using opaque structs with tons of functions for every struct access, and dynamic allocations that cannot be optimized by the compiler.",
"parentUuid": "b0d5c58f_47d2fa14",
"revId": "23a00eb820e440d3fcb2bea87afd90fd24329777",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {