cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

osmux: fix access to uninitialized memory area in scheduled_tx_*_cb 

mgcp_send() needs some initialized address when printing a log message.
Nothing really serious but let's calm down valgrind.
This commit is contained in:
Pablo Neira Ayuso 2014-08-28 19:50:01 +02:00
parent 7a83f4d264
commit caa0aace21
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
openbsc/src/libmgcp/mgcp_osmux.c
View File

@ -210,7 +210,10 @@ endpoint_lookup(struct mgcp_config *cfg, int cid,
static void scheduled_tx_net_cb(struct msgb *msg, void *data)
{
struct mgcp_endpoint *endp = data;
struct sockaddr_in addr;
struct sockaddr_in addr = {
.sin_addr = endp->net_end.addr,
.sin_port = endp->net_end.rtp_port,
};
mgcp_send(endp, MGCP_DEST_NET, 1, &addr, (char *)msg->data, msg->len);
msgb_free(msg);
@ -219,7 +222,10 @@ static void scheduled_tx_net_cb(struct msgb *msg, void *data)
static void scheduled_tx_bts_cb(struct msgb *msg, void *data)
{
struct mgcp_endpoint *endp = data;
struct sockaddr_in addr;
struct sockaddr_in addr = {
.sin_addr = endp->bts_end.addr,
.sin_port = endp->bts_end.rtp_port,
};
mgcp_send(endp, MGCP_DEST_BTS, 1, &addr, (char *)msg->data, msg->len);
msgb_free(msg);