cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

ipaccess: The proxy code checked the array but not the element 

Array compared against 0 (NO_EFFECT)
array_null: Comparing an array to null is not useful: "ipbc->bsc_rsl_conn".

Fixes: Coverity CID 1040718
This commit is contained in:
Holger Hans Peter Freyther 2013-07-14 08:47:06 +02:00
parent 3aedba66bd
commit c9251fa8c9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openbsc/src/ipaccess/ipaccess-proxy.c
View File

@ -647,7 +647,7 @@ static void reconn_tmr_cb(void *data)
logp_ipbc_uid(DLINP, LOGL_NOTICE, ipbc, priv_nr >> 8);
LOGPC(DLINP, LOGL_NOTICE, "RSL Trying to reconnect\n");
ipbc->bsc_rsl_conn[i] = connect_bsc(&sin, priv_nr, ipbc);
if (!ipbc->bsc_rsl_conn)
if (!ipbc->bsc_rsl_conn[i])
goto reschedule;
logp_ipbc_uid(DLINP, LOGL_NOTICE, ipbc, priv_nr >> 8);
LOGPC(DLINP, LOGL_NOTICE, "RSL Reconnected\n");