cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 49 

Patch Set 49:

(17 comments)

Patch-set: 49
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-10-26 16:39:14 +00:00 committed by Gerrit Code Review
parent a08276d2d0
commit 98225b51eb
2 changed files with 297 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

276
7d7fc04e8126aab46d6b5ab63e618f93d775b128 Normal file
View File

@ -0,0 +1,276 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7ebe887b_ad124956",
"filename": "src/libsmpputil/smpp_msc.c",
"patchSetId": 49
},
"lineNbr": 847,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "why is this check added now?",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "827d4d94_8a9fb4fe",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 238,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "how can use be negative?",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "f2536112_0b0eb65f",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 347,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "not return value to check?",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "b572a5a8_fa3652fe",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 760,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "you are casting unsigned long to \"uint32_t\". Better keep unsigned long?",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "13927ea8_da495010",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 772,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "move the commend in the line above better.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4f744e45_a7e2c84e",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 775,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "does msgb_reset also clear esme-\u003eread_msg-\u003ecb[0]? we need to ensure it is 0 here.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "17cf7e74_3916a0a6",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 791,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "why are you returning -EBADF here if the fd is not closed? This is wrong.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "ccc7f6e3_f2d1eb1a",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 799,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "This whole block can be moved under the \"esme-\u003eread_msg-\u003ecb[0] \u003d smpp_size;\" statement above, then it is only checked once instead of each time we receive data and the code is clear.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "9a159fd7_4a7055a7",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 803,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "unable to resize message buffer to %u bytes.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "fddefff1_066f7386",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 825,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "Do we really need a second level callback function? Why not merging this function and the one above and have a goto path for the error paths as we usually do?\nI was first confused because you were returning -EBADF in the read callback function above.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "86f1073a_4fa4d24e",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 843,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "wrong indentation.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "d6084949_932b6847",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 851,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "I foresee some problems with this and esme_destroy. I\u0027ll look at it closly when you fix the other stuff.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "9fe1950c_2c4962e0",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 949,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "This should be improve in a follow up patch to probably pass NULL instead of \"0.0.0.0\" in order to support IPv6.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "98f9e91f_48ea9cfa",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 985,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "you most probably want to set sms-\u003elink\u003dNULL here from code I saw above.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1998658e_38c5f2af",
"filename": "src/libsmpputil/smpp_vty.c",
"patchSetId": 49
},
"lineNbr": 83,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "Idea: You can probably add an smsc_is_running() API or whatever which checks this internally.",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "b1a08b27_fc25b615",
"filename": "src/libsmpputil/smpp_vty.c",
"patchSetId": 49
},
"lineNbr": 190,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 1,
"message": "I wonder why do we want to have listen_port set to 0 at any time, why not set it to SMPP_PORT by default?",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

21
bb624162ead2524ef4e1c72358a329ab1f2a9406 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "17cecaf8_e7993d7b",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 166,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-26T16:39:14Z",
"side": 0,
"message": "Nice bug here setting to null before calling put on it. Better submit a patch preior to this one just fixing this.",
"revId": "bb624162ead2524ef4e1c72358a329ab1f2a9406",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}