cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 52 

Patch Set 52:

(3 comments)

Patch-set: 52
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-10-27 15:34:48 +00:00 committed by Gerrit Code Review
parent d71a67b774
commit 7b77108693
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
7d7fc04e8126aab46d6b5ab63e618f93d775b128
View File

@ -227,6 +227,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "87acba4a_fdaf05b6",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 791,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-27T15:34:48Z",
"side": 1,
"message": "whatever not -EBADF, which has a special meaning in osmocom ofd callbacks (means not to continue using the fd after returning from the callback in the event the READ and WRITE events are flagged).",
"parentUuid": "e8cd7473_39bf61fa",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -401,6 +419,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "c6874098_3d2eeea5",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 949,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-27T15:34:48Z",
"side": 1,
"message": "Ack",
"parentUuid": "4930c917_0d8811c2",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -505,6 +541,24 @@
"parentUuid": "b1a08b27_fc25b615",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "d22ec4a2_c356af4f",
"filename": "src/libsmpputil/smpp_vty.c",
"patchSetId": 49
},
"lineNbr": 190,
"author": {
"id": 1000074
},
"writtenOn": "2022-10-27T15:34:48Z",
"side": 1,
"message": "not sure how that would break VTY tests. If user doesn\u0027t set it, then default port should be used.",
"parentUuid": "1491977c_8ebd6fc6",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}