cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

libmsc/msc_a.c: fix: remove dummy allstate_action of msc_a_fsm 

Since [1] has been merged to libosmocore, it was discovered that
the 'msc_a' FSM has a dummy 'allstate_action' handler assigned,
but 'allstate_event_mask' is 0x00 at the same time.

It basically doesn't make any sense, and moreover does cause
warnings and build failures.

[1] https://git.osmocom.org/libosmocore/commit/?id=b3f94eb39e19366c3458643ee329a73155d46ff8
[1] https://gerrit.osmocom.org/#/c/libosmocore/+/14361/

Change-Id: Ieb81b7a07ced1c40ba70d2adb0df68160ee62118
This commit is contained in:
Vadim Yanitskiy 2019-06-16 00:11:09 +07:00
parent 49d45f1e85
commit 6539bfb8e3
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/libmsc/msc_a.c
View File

@ -809,16 +809,6 @@ static void msc_a_fsm_released(struct osmo_fsm_inst *fi, uint32_t event, void *d
osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, fi);
}
void msc_a_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data)
{
//struct msc_a *a = msc_a_fi_priv(fi);
switch (event) {
default:
return;
}
}
void msc_a_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause)
{
struct msc_a *msc_a = msc_a_fi_priv(fi);
@ -991,9 +981,6 @@ static struct osmo_fsm msc_a_fsm = {
.num_states = ARRAY_SIZE(msc_a_fsm_states),
.log_subsys = DMSC,
.event_names = msc_a_fsm_event_names,
.allstate_action = msc_a_fsm_allstate_action,
.allstate_event_mask = 0
,
.timer_cb = msc_a_fsm_timer_cb,
.cleanup = msc_a_fsm_cleanup,
};