cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 50 

Patch Set 50:

(6 comments)

Patch-set: 50
This commit is contained in:
Gerrit User 1000159 2022-10-27 15:11:27 +00:00 committed by Gerrit Code Review
parent 55166b5fce
commit 59824c10ee
1 changed files with 108 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

108
7d7fc04e8126aab46d6b5ab63e618f93d775b128
View File

@ -209,6 +209,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "e8cd7473_39bf61fa",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 791,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:11:27Z",
"side": 1,
"message": "Which value would you prefer?",
"parentUuid": "17cf7e74_3916a0a6",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -243,6 +261,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "4db9f2a0_9b507368",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 803,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:11:27Z",
"side": 1,
"message": "Done",
"parentUuid": "9a159fd7_4a7055a7",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -277,6 +313,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "76a34670_78ce7a6b",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 843,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:11:27Z",
"side": 1,
"message": "Done",
"parentUuid": "86f1073a_4fa4d24e",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -294,6 +348,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "16c3bf07_cdb7dc48",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 851,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:11:27Z",
"side": 1,
"message": "Could you formulate them as unit/ttcn3 test? That would be most helpful.",
"parentUuid": "d6084949_932b6847",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -311,6 +383,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4930c917_0d8811c2",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 949,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:11:27Z",
"side": 1,
"message": "Agree but I think it\u0027s better to track IPv6 support via separate ticket. I\u0027m pretty sure it\u0027ll require more than 1-line change.",
"parentUuid": "9fe1950c_2c4962e0",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -328,6 +418,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "f914e08c_49c1f6fa",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 985,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:11:27Z",
"side": 1,
"message": "Done",
"parentUuid": "98f9e91f_48ea9cfa",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {