Update patch set 1

Patch Set 1:

(3 comments)

Patch-set: 1
CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
Gerrit User 1000074 2024-03-26 10:26:25 +00:00 committed by Gerrit Code Review
parent 34176dc3c6
commit 433e785c78
1 changed files with 51 additions and 0 deletions

View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "344f85e7_d4a0d87a",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 15,
"author": {
"id": 1000074
},
"writtenOn": "2024-03-26T10:26:25Z",
"side": 1,
"message": "we do the same in osmo-pcu with tbfs btw (ms_merge_and_clear_ms()).",
"revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
@ -16,6 +33,40 @@
"message": "are we sure this code path only gets triggered after authentication [assuming authentication is enabled]? I just want to prevent any attacker spoofing some IMSI and then the MSC/VLR would evict the old (valid) subscriber at the expense of the new (invalid, spoofed) one.",
"revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "16cfd6af_fe5db9e1",
"filename": "src/libmsc/paging.c",
"patchSetId": 1
},
"lineNbr": 147,
"author": {
"id": 1000074
},
"writtenOn": "2024-03-26T10:26:25Z",
"side": 1,
"message": "Shouldn\u0027t this happen only \"if discarding_vsub-\u003ecs.is_paging\"?",
"revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "ca39f788_f7e3f283",
"filename": "src/libvlr/vlr.c",
"patchSetId": 1
},
"lineNbr": 597,
"author": {
"id": 1000074
},
"writtenOn": "2024-03-26T10:26:25Z",
"side": 1,
"message": "I\u0027d rpobably move all this code to its own function \"vsub_join()\" or alike.",
"revId": "3da4715f718dc8b695244ef4d9376f3724a9bb94",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}