Update patch set 7

Patch Set 7: (6 comments) Patch-set: 7 CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
2022-08-01 09:17:06 +00:00 · 2022-08-01 09:17:06 +00:00 · 3f19632313
parent b43beff8db
commit 3f19632313
1 changed files with 106 additions and 0 deletions
--- a/106
+++ b/106
@ -0,0 +1,106 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "84078fec_c7fe2773",
+        "filename": "src/libmsc/smpp_smsc.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 163,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2022-08-01T09:17:06Z",
+      "side": 1,
+      "message": "Not sure what doyouwin with this change here. In fact, it looks more confusing.",
+      "revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f40092de_aad2f148",
+        "filename": "src/libmsc/smpp_smsc.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 242,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2022-08-01T09:17:06Z",
+      "side": 1,
+      "message": "Sound like you want to move this block to some API to free the \"struct esme\" and put it by the side of the struct definition.",
+      "revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "892fd606_e03b5193",
+        "filename": "src/libmsc/smpp_smsc.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 330,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2022-08-01T09:17:06Z",
+      "side": 1,
+      "message": "IIUC this calls can go now to some other file containing \"struct esme\" APIs.",
+      "revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "7e0aada6_1c683ad9",
+        "filename": "src/libmsc/smpp_smsc.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 384,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2022-08-01T09:17:06Z",
+      "side": 1,
+      "message": "this can be probably changed to \"struct esme\"",
+      "revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1f4dc500_2077f7eb",
+        "filename": "src/libmsc/smpp_smsc.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 864,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2022-08-01T09:17:06Z",
+      "side": 1,
+      "message": "THis can be moved to a \"struct esme\" API in a different file?",
+      "revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "594105a8_6c8e0bb4",
+        "filename": "src/libmsc/smpp_smsc.c",
+        "patchSetId": 7
+      },
+      "lineNbr": 895,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2022-08-01T09:17:06Z",
+      "side": 1,
+      "message": "Move to a different \"struct esme\" API? esme_init()",
+      "revId": "d1c3e7abbd365bd30f344fcfc85716ebcbbf6d84",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}