cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

bsc_scan_msc_msg: check protocol discriminator 

The function assumed an MM protocol discriminator without verifying it.
This commit is contained in:
Neels Hofmeyr 2016-03-14 16:15:02 +01:00 committed by Holger Hans Peter Freyther
parent 8c515272c3
commit 10cd11345c
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openbsc/src/osmo-bsc/osmo_bsc_filter.c
View File

@ -336,6 +336,7 @@ int bsc_scan_msc_msg(struct gsm_subscriber_connection *conn, struct msgb *msg)
struct gsm_network *net;
struct gsm48_loc_area_id *lai;
struct gsm48_hdr *gh;
uint8_t pdisc;
uint8_t mtype;
int length = msgb_l3len(msg);
@ -347,6 +348,10 @@ int bsc_scan_msc_msg(struct gsm_subscriber_connection *conn, struct msgb *msg)
gh = (struct gsm48_hdr *) msgb_l3(msg);
length -= (const char *)&gh->data[0] - (const char *)gh;
pdisc = gsm48_hdr_pdisc(gh);
if (pdisc != GSM48_PDISC_MM)
return 0;
mtype = gsm48_hdr_msg_type(gh);
net = conn->bts->network;
msc = conn->sccp_con->msc;