Update patch set 51

Patch Set 51:

(2 comments)

Patch-set: 51
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Max replied on the change"}
This commit is contained in:
Gerrit User 1000159 2022-10-27 15:20:37 +00:00 committed by Gerrit Code Review
parent cc801db40c
commit 0f47c206d1
1 changed files with 36 additions and 0 deletions

View File

@ -453,6 +453,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "beb57292_189b425c",
"filename": "src/libsmpputil/smpp_vty.c",
"patchSetId": 49
},
"lineNbr": 83,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:20:37Z",
"side": 1,
"message": "Sure, if it was used more than once. For a single call I don\u0027t think it\u0027s worth it.",
"parentUuid": "1998658e_38c5f2af",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -469,6 +487,24 @@
"message": "I wonder why do we want to have listen_port set to 0 at any time, why not set it to SMPP_PORT by default?",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1491977c_8ebd6fc6",
"filename": "src/libsmpputil/smpp_vty.c",
"patchSetId": 49
},
"lineNbr": 190,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T15:20:37Z",
"side": 1,
"message": "I think there were some odd corner case where we couldn\u0027t distinguish between user not setting port in config and user setting port to default value and it broke vty tests.",
"parentUuid": "b1a08b27_fc25b615",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}