Update patch set 16
Patch Set 16: Code-Review+1 (2 comments) Patch-set: 16 Reviewer: Gerrit User 1000028 <1000028@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"dexter replied on the change"}
This commit is contained in:
parent
8eef127a39
commit
08fbe8baef
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "9bfea814_fea04819",
|
||||
"filename": "src/utils/Makefile.am",
|
||||
"patchSetId": 16
|
||||
},
|
||||
"lineNbr": 44,
|
||||
"author": {
|
||||
"id": 1000028
|
||||
},
|
||||
"writtenOn": "2022-08-08T09:22:27Z",
|
||||
"side": 0,
|
||||
"message": "I guess there is some conflict with LIBOSMOCRE_LIBS so it had to be replaced?",
|
||||
"revId": "62977d048487837f73f4eb9dfcfeb0be194050b0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7350f0fc_32a6d534",
|
||||
"filename": "src/libsmpputil/smpp_smsc.c",
|
||||
"patchSetId": 16
|
||||
},
|
||||
"lineNbr": 878,
|
||||
"author": {
|
||||
"id": 1000028
|
||||
},
|
||||
"writtenOn": "2022-08-08T09:22:27Z",
|
||||
"side": 1,
|
||||
"message": "maybe memset everything to zero first?",
|
||||
"revId": "b152d94f6826352af10d400bdb17f73dd4b0bae4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue