cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity
osmo-msc/tests/db/db_test.c

287 lines
8.9 KiB
C
Raw Normal View History

db: add GPL headers and integrate with autofoo
2008-12-27 01:07:07 +00:00
/* (C) 2008 by Jan Luebbe <jluebbe@debian.org>
subscr: Make db_create_subscriber fail on duplicates The issue of db_create_subscriber updating an already existing subscr is that the same subscriber will then have two entries in the active subscribers list. In general this will break assumptions that a subscr can be compared by comparing the pointer. In the case of the VTY this was not an issue as the created subscr was immediately destroyed again but it is better to avoid this problem. Change the VTY command to find the subscriber and then call sync to have the updated time set. The side-effect is we will now have two queries for the subscriber. Once through subscr_get_by_imsi and once through db_create_subscriber. Change the db_create_subscriber to fail if a subscriber already exists, and add a testcase for this behavior and do not updated the 'updated' timestamp of an already existing subscriber. Add a testcase for this behavior. Related: OS Issue #1657
2016-04-01 18:21:03 +00:00
* (C) 2009-2016 by Holger Hans Peter Freyther <zecke@selfish.org>
db: Add more tests for retrieving subscribers from a DB.
2014-03-08 17:48:49 +00:00
* (C) 2014 by Alexander Chemeris <Alexander.Chemeris@fairwaves.co>
db: add GPL headers and integrate with autofoo
2008-12-27 01:07:07 +00:00
* All Rights Reserved
*
* This program is free software; you can redistribute it and/or modify
License change: We are now AGPLv3+ instead of GPLv2+ The reason for this is quite simple: We want to make sure anyone running a customized version of OpenBSC to operate a network will have to release all custom modifiations to the source code.
2011-01-01 14:25:50 +00:00
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation; either version 3 of the License, or
db: add GPL headers and integrate with autofoo
2008-12-27 01:07:07 +00:00
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
License change: We are now AGPLv3+ instead of GPLv2+ The reason for this is quite simple: We want to make sure anyone running a customized version of OpenBSC to operate a network will have to release all custom modifiations to the source code.
2011-01-01 14:25:50 +00:00
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
db: add GPL headers and integrate with autofoo
2008-12-27 01:07:07 +00:00
*
*/
rename include/openbsc to include/osmocom/msc Change-Id: I1f96a1285bbd1b4607614856bca935d5c26e2da9
2017-09-04 13:04:35 +00:00
#include <osmocom/msc/debug.h>
#include <osmocom/msc/db.h>
#include <osmocom/msc/gsm_subscriber.h>
#include <osmocom/msc/gsm_04_11.h>
#include <osmocom/msc/mgcp.h>
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
#include <osmocom/core/application.h>
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
#include <stdio.h>
rewrite db backend
2008-12-27 15:59:25 +00:00
#include <string.h>
Fix compilation issues on OS X - mainly #include file changes (Lars Immisch)
2009-05-21 07:23:02 +00:00
#include <stdlib.h>
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
#include <stdbool.h>
db: Add more tests for retrieving subscribers from a DB.
2014-03-08 17:48:49 +00:00
#include <inttypes.h>
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
static struct gsm_network dummy_net;
msc: Add and use gsm_subscriber_group Currently every subcriber object directly refers to the gsm_network which contains a flag shared by every related subscriber (keep_subscr). This adds a dependency on gsm_network even if only the function defined in gsm_subscriber_base.c are used. This patch adds a new struct gsm_subscriber_group which contains the keep_subscr flag and a back reference to the network object. The latter is not dereferenced in gsm_subscriber_base.c, so it can safely be set to NULL when only that part of the gsm_subscriber API is being used. It also changes that API to use gsm_subscriber_group instead of gsm_network parameters. Since there are some places where a pointer to the gsm_network is needed but where only a gsm_subscriber is available, a 'net' back pointer is added to the group struct, too. Nevertheless subscr group and network could be separated completely, but this is not the topic of this commit. Sponsored-by: On-Waves ehf
2014-12-03 08:28:24 +00:00
static struct gsm_subscriber_group dummy_sgrp;
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
#define SUBSCR_PUT(sub) \
msc: Add and use gsm_subscriber_group Currently every subcriber object directly refers to the gsm_network which contains a flag shared by every related subscriber (keep_subscr). This adds a dependency on gsm_network even if only the function defined in gsm_subscriber_base.c are used. This patch adds a new struct gsm_subscriber_group which contains the keep_subscr flag and a back reference to the network object. The latter is not dereferenced in gsm_subscriber_base.c, so it can safely be set to NULL when only that part of the gsm_subscriber API is being used. It also changes that API to use gsm_subscriber_group instead of gsm_network parameters. Since there are some places where a pointer to the gsm_network is needed but where only a gsm_subscriber is available, a 'net' back pointer is added to the group struct, too. Nevertheless subscr group and network could be separated completely, but this is not the topic of this commit. Sponsored-by: On-Waves ehf
2014-12-03 08:28:24 +00:00
sub->group = &dummy_sgrp; \
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
subscr_put(sub);
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
#define COMPARE(original, copy) \
if (original->id != copy->id) \
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("Ids do not match in %s:%d %llu %llu\n", \
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
__FUNCTION__, __LINE__, original->id, copy->id); \
if (original->lac != copy->lac) \
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("LAC do not match in %s:%d %d %d\n", \
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
__FUNCTION__, __LINE__, original->lac, copy->lac); \
if (original->authorized != copy->authorized) \
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("Authorize do not match in %s:%d %d %d\n", \
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
__FUNCTION__, __LINE__, original->authorized, \
copy->authorized); \
if (strcmp(original->imsi, copy->imsi) != 0) \
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("IMSIs do not match in %s:%d '%s' '%s'\n", \
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
__FUNCTION__, __LINE__, original->imsi, copy->imsi); \
[tmsi] Make the tmsi a 4 octet number tmsi is four octets long, there is no need to make it a string and then jump through hoops to convert it to a number. Keep the database using it as a string to benefit from the NULL handling of the db. Introduce the reserved tmsi which has all bits set to 1 according to GSM 03.03 §2.4 and start checking for it and make sure the db code will never allocate such a tmsi.
2009-08-19 10:53:57 +00:00
if (original->tmsi != copy->tmsi) \
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("TMSIs do not match in %s:%d '%u' '%u'\n", \
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
__FUNCTION__, __LINE__, original->tmsi, copy->tmsi); \
if (strcmp(original->name, copy->name) != 0) \
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("names do not match in %s:%d '%s' '%s'\n", \
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
__FUNCTION__, __LINE__, original->name, copy->name); \
if (strcmp(original->extension, copy->extension) != 0) \
Fix copy-paste error in console output in db_test.
2013-10-04 00:42:24 +00:00
printf("Extensions do not match in %s:%d '%s' '%s'\n", \
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
__FUNCTION__, __LINE__, original->extension, copy->extension); \
db: Add testcase for storing/loading/comparing a sms Use the already created subscriber, create a sms and read it back from the subscriber.
2014-03-07 18:08:03 +00:00
/*
* Create/Store a SMS and then try to load it.
*/
static void test_sms(void)
{
int rc;
struct gsm_sms *sms;
struct gsm_subscriber *subscr;
subscr = db_get_subscriber(GSM_SUBSCRIBER_IMSI, "9993245423445");
OSMO_ASSERT(subscr);
msc: Add and use gsm_subscriber_group Currently every subcriber object directly refers to the gsm_network which contains a flag shared by every related subscriber (keep_subscr). This adds a dependency on gsm_network even if only the function defined in gsm_subscriber_base.c are used. This patch adds a new struct gsm_subscriber_group which contains the keep_subscr flag and a back reference to the network object. The latter is not dereferenced in gsm_subscriber_base.c, so it can safely be set to NULL when only that part of the gsm_subscriber API is being used. It also changes that API to use gsm_subscriber_group instead of gsm_network parameters. Since there are some places where a pointer to the gsm_network is needed but where only a gsm_subscriber is available, a 'net' back pointer is added to the group struct, too. Nevertheless subscr group and network could be separated completely, but this is not the topic of this commit. Sponsored-by: On-Waves ehf
2014-12-03 08:28:24 +00:00
subscr->group = &dummy_sgrp;
db: Add testcase for storing/loading/comparing a sms Use the already created subscriber, create a sms and read it back from the subscriber.
2014-03-07 18:08:03 +00:00
sms = sms_alloc();
sms->receiver = subscr_get(subscr);
sms->src.ton = 0x23;
sms->src.npi = 0x24;
memcpy(sms->src.addr, "1234", strlen("1234") + 1);
sms->dst.ton = 0x32;
sms->dst.npi = 0x42;
memcpy(sms->dst.addr, subscr->extension, sizeof(subscr->extension));
memcpy(sms->text, "Text123", strlen("Text123") + 1);
memcpy(sms->user_data, "UserData123", strlen("UserData123") + 1);
sms->user_data_len = strlen("UserData123");
/* random values */
sms->reply_path_req = 1;
sms->status_rep_req = 2;
sms->ud_hdr_ind = 3;
sms->protocol_id = 4;
sms->data_coding_scheme = 5;
rc = db_sms_store(sms);
sms_free(sms);
OSMO_ASSERT(rc == 0);
/* now query */
sms = db_sms_get_unsent_for_subscr(subscr);
OSMO_ASSERT(sms);
OSMO_ASSERT(sms->receiver == subscr);
OSMO_ASSERT(sms->reply_path_req == 1);
OSMO_ASSERT(sms->status_rep_req == 2);
OSMO_ASSERT(sms->ud_hdr_ind == 3);
OSMO_ASSERT(sms->protocol_id == 4);
OSMO_ASSERT(sms->data_coding_scheme == 5);
OSMO_ASSERT(sms->src.ton == 0x23);
OSMO_ASSERT(sms->src.npi == 0x24);
OSMO_ASSERT(sms->dst.ton == 0x32);
OSMO_ASSERT(sms->dst.npi == 0x42);
OSMO_ASSERT(strcmp((char *) sms->text, "Text123") == 0);
OSMO_ASSERT(sms->user_data_len == strlen("UserData123"));
OSMO_ASSERT(strcmp((char *) sms->user_data, "UserData123") == 0);
db: Extend the test to mark a SMS as delivered and verify it Mark the SMS as delivered, then free it and try to get an undelivered SMS to that subscriber again and make sure it is failing.
2014-12-25 16:27:15 +00:00
/* Mark the SMS as delivered */
db_sms_mark_delivered(sms);
sms_free(sms);
sms = db_sms_get_unsent_for_subscr(subscr);
OSMO_ASSERT(!sms);
db: Add testcase for storing/loading/comparing a sms Use the already created subscriber, create a sms and read it back from the subscriber.
2014-03-07 18:08:03 +00:00
subscr_put(subscr);
}
db: Add testcase for the db migration.
2014-03-08 15:41:37 +00:00
static void test_sms_migrate(void)
{
struct gsm_subscriber *rcv_subscr;
struct gsm_sms *sms;
static const uint8_t user_data_1[] = {
0x41, 0xf1, 0xd8, 0x05, 0x22, 0x96, 0xcd, 0x2e,
0x90, 0xf1, 0xfd, 0x06, 0x00 };
static const uint8_t user_data_2[] = {
0x41, 0xf1, 0xd8, 0x05, 0x22, 0x96, 0xcd, 0x2e,
0xd0, 0xf1, 0xfd, 0x06, 0x00 };
rcv_subscr = db_get_subscriber(GSM_SUBSCRIBER_IMSI, "901010000001111");
msc: Add and use gsm_subscriber_group Currently every subcriber object directly refers to the gsm_network which contains a flag shared by every related subscriber (keep_subscr). This adds a dependency on gsm_network even if only the function defined in gsm_subscriber_base.c are used. This patch adds a new struct gsm_subscriber_group which contains the keep_subscr flag and a back reference to the network object. The latter is not dereferenced in gsm_subscriber_base.c, so it can safely be set to NULL when only that part of the gsm_subscriber API is being used. It also changes that API to use gsm_subscriber_group instead of gsm_network parameters. Since there are some places where a pointer to the gsm_network is needed but where only a gsm_subscriber is available, a 'net' back pointer is added to the group struct, too. Nevertheless subscr group and network could be separated completely, but this is not the topic of this commit. Sponsored-by: On-Waves ehf
2014-12-03 08:28:24 +00:00
rcv_subscr->group = &dummy_sgrp;
db: Add testcase for the db migration.
2014-03-08 15:41:37 +00:00
sms = db_sms_get(&dummy_net, 1);
OSMO_ASSERT(sms->id == 1);
OSMO_ASSERT(sms->receiver == rcv_subscr);
OSMO_ASSERT(strcmp(sms->text, "Abc. Def. Foo") == 0);
OSMO_ASSERT(sms->user_data_len == ARRAY_SIZE(user_data_1));
OSMO_ASSERT(memcmp(sms->user_data, user_data_1, ARRAY_SIZE(user_data_1)) == 0);
sms_free(sms);
sms = db_sms_get(&dummy_net, 2);
OSMO_ASSERT(sms->id == 2);
OSMO_ASSERT(sms->receiver == rcv_subscr);
OSMO_ASSERT(strcmp(sms->text, "Abc. Def. Goo") == 0);
OSMO_ASSERT(sms->user_data_len == ARRAY_SIZE(user_data_2));
OSMO_ASSERT(memcmp(sms->user_data, user_data_2, ARRAY_SIZE(user_data_2)) == 0);
sms_free(sms);
subscr_put(rcv_subscr);
}
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
static void test_subs(const char *imsi, char *imei1, char *imei2, bool make_ext)
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
{
Cleanup db test Move copy-pasted code into separate function to make writing more tests easier. Related: OS#1658 Change-Id: I9e39af85718514dd0f081d41c234c9dda77c4b27 Reviewed-on: https://gerrit.osmocom.org/43 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger@freyther.de>
2016-05-11 11:05:13 +00:00
struct gsm_subscriber *alice = NULL, *alice_db;
db: Add more tests for retrieving subscribers from a DB.
2014-03-08 17:48:49 +00:00
char scratch_str[256];
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
alice = db_create_subscriber(imsi, GSM_MIN_EXTEN, GSM_MAX_EXTEN,
make_ext);
Cleanup db test Move copy-pasted code into separate function to make writing more tests easier. Related: OS#1658 Change-Id: I9e39af85718514dd0f081d41c234c9dda77c4b27 Reviewed-on: https://gerrit.osmocom.org/43 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger@freyther.de>
2016-05-11 11:05:13 +00:00
db_subscriber_assoc_imei(alice, imei1);
if (imei2)
db_subscriber_assoc_imei(alice, imei2);
db_subscriber_alloc_tmsi(alice);
alice->lac=42;
db_sync_subscriber(alice);
/* Get by TMSI */
snprintf(scratch_str, sizeof(scratch_str), "%"PRIu32, alice->tmsi);
alice_db = db_get_subscriber(GSM_SUBSCRIBER_TMSI, scratch_str);
COMPARE(alice, alice_db);
SUBSCR_PUT(alice_db);
/* Get by IMSI */
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
alice_db = db_get_subscriber(GSM_SUBSCRIBER_IMSI, imsi);
Cleanup db test Move copy-pasted code into separate function to make writing more tests easier. Related: OS#1658 Change-Id: I9e39af85718514dd0f081d41c234c9dda77c4b27 Reviewed-on: https://gerrit.osmocom.org/43 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger@freyther.de>
2016-05-11 11:05:13 +00:00
COMPARE(alice, alice_db);
SUBSCR_PUT(alice_db);
/* Get by id */
snprintf(scratch_str, sizeof(scratch_str), "%llu", alice->id);
alice_db = db_get_subscriber(GSM_SUBSCRIBER_ID, scratch_str);
COMPARE(alice, alice_db);
SUBSCR_PUT(alice_db);
/* Get by extension */
alice_db = db_get_subscriber(GSM_SUBSCRIBER_EXTENSION, alice->extension);
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
if (alice_db) {
if (!make_ext)
printf("FAIL: bogus extension created for IMSI %s\n",
imsi);
COMPARE(alice, alice_db);
SUBSCR_PUT(alice_db);
} else if (make_ext)
printf("FAIL: no subscriber extension for IMSI %s\n", imsi);
Cleanup db test Move copy-pasted code into separate function to make writing more tests easier. Related: OS#1658 Change-Id: I9e39af85718514dd0f081d41c234c9dda77c4b27 Reviewed-on: https://gerrit.osmocom.org/43 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger@freyther.de>
2016-05-11 11:05:13 +00:00
SUBSCR_PUT(alice);
}
int main()
{
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("Testing subscriber database code.\n");
osmo_init_logging(&log_info);
db: Fix next fall-out with make distcheck
2014-05-01 05:53:42 +00:00
log_set_print_filename(osmo_stderr_target, 0);
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
msc: Add and use gsm_subscriber_group Currently every subcriber object directly refers to the gsm_network which contains a flag shared by every related subscriber (keep_subscr). This adds a dependency on gsm_network even if only the function defined in gsm_subscriber_base.c are used. This patch adds a new struct gsm_subscriber_group which contains the keep_subscr flag and a back reference to the network object. The latter is not dereferenced in gsm_subscriber_base.c, so it can safely be set to NULL when only that part of the gsm_subscriber API is being used. It also changes that API to use gsm_subscriber_group instead of gsm_network parameters. Since there are some places where a pointer to the gsm_network is needed but where only a gsm_subscriber is available, a 'net' back pointer is added to the group struct, too. Nevertheless subscr group and network could be separated completely, but this is not the topic of this commit. Sponsored-by: On-Waves ehf
2014-12-03 08:28:24 +00:00
dummy_net.subscr_group = &dummy_sgrp;
dummy_sgrp.net = &dummy_net;
Revert "[db] Keep track of the current gsm_network" This was a stupid decision. We will have to assign the network at some other place. The problem will be a problem when we have two gsm_networks in one process and the same subscriber is traveling in both networks.
2009-06-06 13:54:20 +00:00
if (db_init("hlr.sqlite3")) {
rewrite db backend
2008-12-27 15:59:25 +00:00
printf("DB: Failed to init database. Please check the option settings.\n");
return 1;
}
printf("DB: Database initialized.\n");
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
rewrite db backend
2008-12-27 15:59:25 +00:00
if (db_prepare()) {
printf("DB: Failed to prepare database.\n");
return 1;
}
printf("DB: Database prepared.\n");
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
rewrite db backend
2008-12-27 15:59:25 +00:00
struct gsm_subscriber *alice = NULL;
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
struct gsm_subscriber *alice_db;
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
char *alice_imsi = "3243245432345";
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
alice = db_create_subscriber(alice_imsi, GSM_MIN_EXTEN, GSM_MAX_EXTEN,
true);
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
db_sync_subscriber(alice);
db: Remove the struct gsm_network from the database layer The database code should not know about the network. Move the setting of the network pointer into the subscriber layer.
2013-10-04 06:35:11 +00:00
alice_db = db_get_subscriber(GSM_SUBSCRIBER_IMSI, alice->imsi);
Change the subscriber and database backend gsm_subscriber is now refcounted, the db backend is leaking a lot less, db_get_subscriber will allocate the subscr record now, subscr_* will look up a subscriber in the list of currently active subscribers and add an ref to this one. The db test cases pass, more testing will be when next to the bts
2009-01-01 18:02:05 +00:00
COMPARE(alice, alice_db);
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
SUBSCR_PUT(alice_db);
SUBSCR_PUT(alice);
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
test_subs("3693245423445", "1234567890", NULL, true);
test_subs("9993245423445", "1234567890", "6543560920", true);
test_subs("3123122223445", "1234567890", NULL, false);
test_subs("9123121223445", "1234567890", "6543560920", false);
rewrite db backend
2008-12-27 15:59:25 +00:00
subscr: Make db_create_subscriber fail on duplicates The issue of db_create_subscriber updating an already existing subscr is that the same subscriber will then have two entries in the active subscribers list. In general this will break assumptions that a subscr can be compared by comparing the pointer. In the case of the VTY this was not an issue as the created subscr was immediately destroyed again but it is better to avoid this problem. Change the VTY command to find the subscriber and then call sync to have the updated time set. The side-effect is we will now have two queries for the subscriber. Once through subscr_get_by_imsi and once through db_create_subscriber. Change the db_create_subscriber to fail if a subscriber already exists, and add a testcase for this behavior and do not updated the 'updated' timestamp of an already existing subscriber. Add a testcase for this behavior. Related: OS Issue #1657
2016-04-01 18:21:03 +00:00
/* create it again and see it fails */
Make random MSISDN assignment optional Previously if subscriber was automatically created it got assigned random MSISDN number. Make it optional (defaulting to previous behavior) by adding following: * new optional no-extension argument for subscriber-create-on-demand vty command * db unit tests * vty test Note: using the db made with new code might result in subscribers with empty extension. Such subscribers cannot be deleted using old code. Make sure not to mix db versions or manually fix it by editing sqlite with external program. Fixes: OS#1658 Change-Id: Ibbc2e88e4722b08854ebc631485f19ed56443cbb
2016-06-30 08:25:49 +00:00
alice = db_create_subscriber(alice_imsi, GSM_MIN_EXTEN, GSM_MAX_EXTEN,
true);
subscr: Make db_create_subscriber fail on duplicates The issue of db_create_subscriber updating an already existing subscr is that the same subscriber will then have two entries in the active subscribers list. In general this will break assumptions that a subscr can be compared by comparing the pointer. In the case of the VTY this was not an issue as the created subscr was immediately destroyed again but it is better to avoid this problem. Change the VTY command to find the subscriber and then call sync to have the updated time set. The side-effect is we will now have two queries for the subscriber. Once through subscr_get_by_imsi and once through db_create_subscriber. Change the db_create_subscriber to fail if a subscriber already exists, and add a testcase for this behavior and do not updated the 'updated' timestamp of an already existing subscriber. Add a testcase for this behavior. Related: OS Issue #1657
2016-04-01 18:21:03 +00:00
OSMO_ASSERT(!alice);
db: Add testcase for storing/loading/comparing a sms Use the already created subscriber, create a sms and read it back from the subscriber.
2014-03-07 18:08:03 +00:00
test_sms();
db: Add testcase for the db migration.
2014-03-08 15:41:37 +00:00
test_sms_migrate();
db: Add testcase for storing/loading/comparing a sms Use the already created subscriber, create a sms and read it back from the subscriber.
2014-03-07 18:08:03 +00:00
rewrite db backend
2008-12-27 15:59:25 +00:00
db_fini();
db: Fix the test code * Initialize logging * use a dummy net before calling subcr_put as the keep in ram option is going to be set.
2012-01-06 13:27:08 +00:00
printf("Done\n");
rewrite db backend
2008-12-27 15:59:25 +00:00
return 0;
add first sketch of a DB backend
2008-12-27 00:45:41 +00:00
}
[tests] Change the db_test to link to the libopenbsc.a This should keep the test compiling in the future. It will link to the libopenbsc.a to get all symbols. We do this in the other tests too.
2009-04-12 05:37:07 +00:00
/* stubs */
subscr: Dump the pending requests to help with debugging state.
2010-12-29 10:07:22 +00:00
void vty_out() {}
Use libvlr in libmsc (large refactoring) Original libvlr code is by Harald Welte <laforge@gnumonks.org>, polished and tweaked by Neels Hofmeyr <nhofmeyr@sysmocom.de>. This is a long series of trial-and-error development collapsed in one patch. This may be split in smaller commits if reviewers prefer that. If we can keep it as one, we have saved ourselves the additional separation work. SMS: The SQL based lookup of SMS for attached subscribers no longer works since the SQL database no longer has the subscriber data. Replace with a round-robin on the SMS recipient MSISDNs paired with a VLR subscriber RAM lookup whether the subscriber is currently attached. If there are many SMS for not-attached subscribers in the SMS database, this will become inefficient: a DB hit returns a pending SMS, the RAM lookup will reveal that the subscriber is not attached, after which the DB is hit for the next SMS. It would become more efficient e.g. by having an MSISDN based hash list for the VLR subscribers and by marking non-attached SMS recipients in the SMS database so that they can be excluded with the SQL query already. There is a sanity limit to do at most 100 db hits per attempt to find a pending SMS. So if there are more than 100 stored SMS waiting for their recipients to actually attach to the MSC, it may take more than one SMS queue trigger to deliver SMS for subscribers that are actually attached. This is not very beautiful, but is merely intended to carry us over to a time when we have a proper separate SMSC entity. Introduce gsm_subscriber_connection ref-counting in libmsc. Remove/Disable VTY and CTRL commands to create subscribers, which is now a task of the OsmoHLR. Adjust the python tests accordingly. Remove VTY cmd subscriber-keep-in-ram. Use OSMO_GSUP_PORT = 4222 instead of 2222. See I4222e21686c823985be8ff1f16b1182be8ad6175. So far use the LAC from conn->bts, will be replaced by conn->lac in Id3705236350d5f69e447046b0a764bbabc3d493c. Related: OS#1592 OS#1974 Change-Id: I639544a6cdda77a3aafc4e3446a55393f60e4050
2016-06-19 16:06:02 +00:00
void vlr_subscr_disconnected() {}
void vlr_subscr_rx_tmsi_reall_compl() {}
void vlr_subscr_rx_id_resp() {}
void vlr_subscr_rx_auth_resp() {}
void vlr_loc_update() {}
void vlr_proc_acc_req() {}
void vlr_init() {}
Implement IuCS (large refactoring and addition) osmo-nitb becomes osmo-msc add DIUCS debug log constant add iucs.[hc] add msc vty, remove nitb vty add libiudummy, to avoid linking Iu deps in tests Use new msc_tx_dtap() instead of gsm0808_submit_dtap() libmgcp: add mgcpgw client API bridge calls via mgcpgw Enable MSC specific CTRL commands, bsc_base_ctrl_cmds_install() still needs to be split up. Change-Id: I5b5b6a9678b458affa86800afb1ec726e66eed88
2016-05-20 19:59:55 +00:00
unsigned int mgcpgw_client_next_endpoint(struct mgcpgw_client *client)
{ return 0; }
struct msgb *mgcp_msg_crcx(struct mgcpgw_client *mgcp,
uint16_t rtp_endpoint, unsigned int call_id,
enum mgcp_connection_mode mode)
{ return NULL; }
struct msgb *mgcp_msg_mdcx(struct mgcpgw_client *mgcp,
uint16_t rtp_endpoint, const char *rtp_conn_addr,
uint16_t rtp_port, enum mgcp_connection_mode mode)
{ return NULL; }
int mgcpgw_client_tx(struct mgcpgw_client *mgcp, struct msgb *msg,
mgcp_response_cb_t response_cb, void *priv)
{ return -EINVAL; }
const char *mgcpgw_client_remote_addr_str(struct mgcpgw_client *mgcp)
{ return "0.0.0.0"; }
uint32_t mgcpgw_client_remote_addr_n(struct mgcpgw_client *mgcp)
{ return 0; }
int mgcp_response_parse_params(struct mgcp_response *r)
{ return -EINVAL; }
struct RANAP_Cause;
int iu_tx_release(struct ue_conn_ctx *ctx, const struct RANAP_Cause *cause)
{ return 0; }