osmo-mgw/f94b829feb831544e9373c489ca...

110 lines
3.3 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "45061c23_9c6b5db1",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 1000074
},
"writtenOn": "2023-12-11T09:40:59Z",
"side": 1,
"message": "I?m not following here. I don\u0027t understand why failing when the other side has no codecs set.",
"revId": "f94b829feb831544e9373c489ca01112220d70f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1327b37f_24e71f52",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 1000005
},
"writtenOn": "2023-12-21T00:25:41Z",
"side": 1,
"message": "only because that is what osmo-mgw is currently doing, and I don\u0027t want to change too many things at once. updating the commit log...",
"parentUuid": "45061c23_9c6b5db1",
"revId": "f94b829feb831544e9373c489ca01112220d70f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "2fd663fd_ee666d22",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 21,
"author": {
"id": 1000005
},
"writtenOn": "2024-01-05T04:13:35Z",
"side": 1,
"message": "Done",
"parentUuid": "1327b37f_24e71f52",
"revId": "f94b829feb831544e9373c489ca01112220d70f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "41f41a41_69ec2572",
"filename": "src/libosmo-mgcp/mgcp_codec.c",
"patchSetId": 1
},
"lineNbr": 478,
"author": {
"id": 1000074
},
"writtenOn": "2023-12-11T09:40:59Z",
"side": 1,
"message": "you definetly want to print the endpoint or conns here.",
"revId": "f94b829feb831544e9373c489ca01112220d70f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "9af95248_9addc983",
"filename": "src/libosmo-mgcp/mgcp_codec.c",
"patchSetId": 1
},
"lineNbr": 478,
"author": {
"id": 1000074
},
"writtenOn": "2024-01-02T10:04:08Z",
"side": 1,
"message": "This one has not been addressed.",
"parentUuid": "41f41a41_69ec2572",
"revId": "f94b829feb831544e9373c489ca01112220d70f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "a7f1fb18_7f893f77",
"filename": "src/libosmo-mgcp/mgcp_codec.c",
"patchSetId": 1
},
"lineNbr": 478,
"author": {
"id": 1000005
},
"writtenOn": "2024-01-04T23:33:09Z",
"side": 1,
"message": "or i can drop this log again, it was from debugging.\nbtw, it seems osmo-mgw does a lot of context-less logging in MGCP and SDP.\n\nre unadressed: I probably just pushed a later patch, causing a new patch set here too -- no intention to skip CR still marked unresolved",
"parentUuid": "9af95248_9addc983",
"revId": "f94b829feb831544e9373c489ca01112220d70f9",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}