98 lines
3.2 KiB
Plaintext
98 lines
3.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "34973814_525a87f3",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2023-04-25T19:44:37Z",
|
|
"side": 1,
|
|
"message": "by call agent, do you mean like BSC and MSC? So far I see call agent as meaning a PBX like freeswitch or kamailio. Maybe \u0027MGCP client\u0027?",
|
|
"range": {
|
|
"startLine": 9,
|
|
"startChar": 36,
|
|
"endLine": 9,
|
|
"endChar": 46
|
|
},
|
|
"revId": "348312445f7deb4228f9fd073111b405dd88af5c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "11fa5b13_7187e1f3",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2023-04-26T15:20:34Z",
|
|
"side": 1,
|
|
"message": "As far as I understand a call agent is any entity that controls an MGW, it can be a BSC, MSC or a PBX.",
|
|
"parentUuid": "34973814_525a87f3",
|
|
"range": {
|
|
"startLine": 9,
|
|
"startChar": 36,
|
|
"endLine": 9,
|
|
"endChar": 46
|
|
},
|
|
"revId": "348312445f7deb4228f9fd073111b405dd88af5c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "97bfe5d5_311c677a",
|
|
"filename": "src/libosmo-mgcp/mgcp_network.c",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 1168,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2023-04-25T19:44:37Z",
|
|
"side": 1,
|
|
"message": "I guess when we drop packets that would be LOGL_ERROR; only problem is with spamming 20 LOGL_ERROR per second... so maybe NOTICE? definitely DEBUG seems too insignificant when this is the single point of failure for establishing a voice call.\n\n(I was thinking before about a mechanism in the MGW, where we sort of remember that previous RTP packets of an endp had identical errors, and we log an error only once, or maybe only once every ten seconds. Just thinking here, does not need to be part of this patch.)",
|
|
"range": {
|
|
"startLine": 1168,
|
|
"startChar": 29,
|
|
"endLine": 1168,
|
|
"endChar": 34
|
|
},
|
|
"revId": "348312445f7deb4228f9fd073111b405dd88af5c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "eb90af28_86187357",
|
|
"filename": "src/libosmo-mgcp/mgcp_network.c",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 1168,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2023-04-26T15:20:34Z",
|
|
"side": 1,
|
|
"message": "I think in this case LOGL_NOTICE it is not a too big problem. mgcp_patch_pt() only fails on short RTP packets or if the codec decision is not made properly.",
|
|
"parentUuid": "97bfe5d5_311c677a",
|
|
"range": {
|
|
"startLine": 1168,
|
|
"startChar": 29,
|
|
"endLine": 1168,
|
|
"endChar": 34
|
|
},
|
|
"revId": "348312445f7deb4228f9fd073111b405dd88af5c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |