123 lines
3.3 KiB
Plaintext
123 lines
3.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "587ddad9_c963b35b",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 9,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-01-02T09:59:30Z",
|
|
"side": 1,
|
|
"message": "fmtp strings",
|
|
"revId": "667800ca4c0aa7f1227e8172f68ae66fe0045b10",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b9932791_b59f7fb2",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-01-02T09:59:30Z",
|
|
"side": 1,
|
|
"message": "fmtp",
|
|
"revId": "667800ca4c0aa7f1227e8172f68ae66fe0045b10",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f309cfe4_370a2d23",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2023-12-23T07:00:35Z",
|
|
"side": 1,
|
|
"message": "minor nitpick: the subject states \"ftmp.h\" while in reality it\u0027s more than a header.",
|
|
"revId": "667800ca4c0aa7f1227e8172f68ae66fe0045b10",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "9e999c8b_6926c495",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-01-02T09:59:30Z",
|
|
"side": 1,
|
|
"message": "Only minor stuff needs improving/fixing, feel free to merge it once you fix those.",
|
|
"revId": "667800ca4c0aa7f1227e8172f68ae66fe0045b10",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "eb0de39f_5f52c1e6",
|
|
"filename": "src/libosmo-mgcp-client/fmtp.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 29,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-01-02T09:59:30Z",
|
|
"side": 1,
|
|
"message": "fmtp being nonull should be checked only once at start.",
|
|
"revId": "667800ca4c0aa7f1227e8172f68ae66fe0045b10",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "97ac2864_6c03457c",
|
|
"filename": "src/libosmo-mgcp-client/fmtp.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 41,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-01-02T09:59:30Z",
|
|
"side": 1,
|
|
"message": "IIUC res contains \"0,2,4,7\" here, maybe worth saying that.",
|
|
"revId": "667800ca4c0aa7f1227e8172f68ae66fe0045b10",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "cad9b599_1fe5110a",
|
|
"filename": "src/libosmo-mgcp-client/fmtp.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 89,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-01-02T09:59:30Z",
|
|
"side": 1,
|
|
"message": "did you check in SDP spec if int range is enough?",
|
|
"revId": "667800ca4c0aa7f1227e8172f68ae66fe0045b10",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |