145 lines
4.4 KiB
Plaintext
145 lines
4.4 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f8984686_c8f541bf",
|
|
"filename": "src/libosmo-mgcp/mgcp_network.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 509,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-04-06T12:20:44Z",
|
|
"side": 1,
|
|
"message": "so you decided to drop the return code while still logging an ERROR. WHY?",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f8e569a8_0e2f5fe9",
|
|
"filename": "src/libosmo-mgcp/mgcp_network.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 509,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2023-04-06T14:05:17Z",
|
|
"side": 1,
|
|
"message": "The caller is not doing anything meaningful with it but maybe it is better to drop the packet than sending it with a wrong PT.",
|
|
"parentUuid": "f8984686_c8f541bf",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "81b7c544_21635a0a",
|
|
"filename": "src/libosmo-mgcp/mgcp_network.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 509,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-04-06T14:41:21Z",
|
|
"side": 1,
|
|
"message": "ACK. I\u0027m not saying you fix it in this commit, but you should at least not making it worst in this commit.",
|
|
"parentUuid": "f8e569a8_0e2f5fe9",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "59799fe7_89329e4d",
|
|
"filename": "src/libosmo-mgcp/mgcp_network.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 1166,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-04-06T12:20:44Z",
|
|
"side": 1,
|
|
"message": "all this code path failing looks buggy. Looks like it was buggy before, but now it looks even worse?",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5f1a8dad_f78b9f05",
|
|
"filename": "src/libosmo-mgcp/mgcp_network.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 1166,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2023-04-06T14:05:17Z",
|
|
"side": 1,
|
|
"message": "Technically nothing has changed but I can see mgcp_send() might need some refactoring.",
|
|
"parentUuid": "59799fe7_89329e4d",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "0471b13a_8cc51dee",
|
|
"filename": "src/libosmo-mgcp/mgcp_vty.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 703,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-04-06T12:20:44Z",
|
|
"side": 1,
|
|
"message": "These are still missing the deprecated warnings?",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1d51d7a3_c34582df",
|
|
"filename": "src/libosmo-mgcp/mgcp_vty.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 703,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2023-04-13T12:40:19Z",
|
|
"side": 1,
|
|
"message": "I have added \"vty_out(vty, \"%% Deprecated \u0027allow-transcoding\u0027 config no longer has any effect%s\", VTY_NEWLINE);\" below, is this not correct?",
|
|
"parentUuid": "0471b13a_8cc51dee",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4888bcf7_4234d095",
|
|
"filename": "src/libosmo-mgcp/mgcp_vty.c",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 703,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-04-13T13:46:00Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "1d51d7a3_c34582df",
|
|
"revId": "b5f8566a80dd6b6c494d05d0607d68bce53fd204",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |