cellular-infrastructure
/
osmo-mgw
mirror of https://gerrit.osmocom.org/osmo-mgw
10
0
Fork 0
Code Issues Releases Wiki Activity
osmo-mgw/tests/mgcp_client/mgcp_client_test.err

188 lines
6.4 KiB
Plaintext
Raw Normal View History

mgcp_client: add MGW name as logging context Usually only one MGCP client per application is present. Then the log lines from mgcp_client.c will be distinguishable without additional information. When the application is using a pool of MGWs, then the various MGCP Client instances become hard to distinguish. - Add a possibility to set a description (name) for each MGW pool member. When no description is set, use the domain name. - Output the pool member name on each log line in mgcp_client.c and mgcp_client_pool.c Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Related: SYS#5091
2021-09-03 15:50:51 +00:00
DLMGCP MGW(mgw) MGCP client: using endpoint domain '@mgw'
mgcp_client: simpler error handling add_sdp(), add_lco(): - do not msgb_free() within these functions. Just return error, and move the msgb_free() to the caller. - when failing to write to the msgb, directly return error. Change-Id: I904d56f56053952c2ebbbe5dca744fafa32b333e
2023-03-30 14:53:13 +00:00
DLMGCP MGW(mgw) Message buffer too small, can not generate MGCP message (SDP)
mgcp_client: mgcp_msg_gen: add more error logs While adding CSD, this failed for me in add_lco without a descriptive log message, so add more error messages. Related: OS#4393 Change-Id: I4873a2db95525aab3e13046b645dd8f90e951466
2023-02-22 15:30:02 +00:00
DLMGCP MGW(mgw) Failed to add SDP, can not generate MGCP message
mgcp_client: add transaction cleanup So far, if an MGCP message is sent, the transaction gets enqueued, but there is no way to end the transaction other than receiving a valid reply. So, if the caller decides that the transaction timed out and tears down the priv pointer passed to mgcp_client_tx, and if then a late reply arrives, the callback will dereference the invalid priv pointer and cause a segfault. Hence it is possible to crash an mgcp_client program by sending a late response. Furthermore, if no reply ever arrives, we would keep the pending response in the list forever, amounting to a "memory leak". Add mgcp_client_cancel() to discard a pending transaction. The caller can now decide to discard a pending response when it sees fit (e.g. the caller's timeout expired). This needs to be added to OsmoMSC and OsmoBSC. Add mgcp_msg_trans_id() to provide an obvious way to obtain the transaction id from a generated MGCP message. No public API is broken; but refine the negative return code from mgcp_client_rx(): return -ENOENT if no such transaction ID is found, and still -1 if decoding failed. This is mainly for mgcp_client_test. Implement a test for mgcp_client_cancel() in mgcp_client_test.c. Tweak internal mgcp_client_response_pending_get() to take only the transaction id as argument instead of the entire mgcp message struct. Found-by: dexter Related: OS#2695 OS#2696 Change-Id: I16811e168a46a82a05943252a737b3434143f4bd
2017-11-30 12:43:11 +00:00
test_mgcp_client_cancel():
mgcp_client: add MGW name as logging context Usually only one MGCP client per application is present. Then the log lines from mgcp_client.c will be distinguishable without additional information. When the application is using a pool of MGWs, then the various MGCP Client instances become hard to distinguish. - Add a possibility to set a description (name) for each MGW pool member. When no description is set, use the domain name. - Output the pool member name on each log line in mgcp_client.c and mgcp_client_pool.c Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Related: SYS#5091
2021-09-03 15:50:51 +00:00
DLMGCP MGW(mgw) MGCP client: using endpoint domain '@mgw'
mgcp_client: add transaction cleanup So far, if an MGCP message is sent, the transaction gets enqueued, but there is no way to end the transaction other than receiving a valid reply. So, if the caller decides that the transaction timed out and tears down the priv pointer passed to mgcp_client_tx, and if then a late reply arrives, the callback will dereference the invalid priv pointer and cause a segfault. Hence it is possible to crash an mgcp_client program by sending a late response. Furthermore, if no reply ever arrives, we would keep the pending response in the list forever, amounting to a "memory leak". Add mgcp_client_cancel() to discard a pending transaction. The caller can now decide to discard a pending response when it sees fit (e.g. the caller's timeout expired). This needs to be added to OsmoMSC and OsmoBSC. Add mgcp_msg_trans_id() to provide an obvious way to obtain the transaction id from a generated MGCP message. No public API is broken; but refine the negative return code from mgcp_client_rx(): return -ENOENT if no such transaction ID is found, and still -1 if decoding failed. This is mainly for mgcp_client_test. Implement a test for mgcp_client_cancel() in mgcp_client_test.c. Tweak internal mgcp_client_response_pending_get() to take only the transaction id as argument instead of the entire mgcp message struct. Found-by: dexter Related: OS#2695 OS#2696 Change-Id: I16811e168a46a82a05943252a737b3434143f4bd
2017-11-30 12:43:11 +00:00
- composed msg with trans_id=1
- not in queue yet, cannot cancel yet
mgcp_client: add MGW name as logging context Usually only one MGCP client per application is present. Then the log lines from mgcp_client.c will be distinguishable without additional information. When the application is using a pool of MGWs, then the various MGCP Client instances become hard to distinguish. - Add a possibility to set a description (name) for each MGW pool member. When no description is set, use the domain name. - Output the pool member name on each log line in mgcp_client.c and mgcp_client_pool.c Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Related: SYS#5091
2021-09-03 15:50:51 +00:00
DLMGCP MGW(mgw) Cannot cancel, no such transaction: 1
mgcp_client: add transaction cleanup So far, if an MGCP message is sent, the transaction gets enqueued, but there is no way to end the transaction other than receiving a valid reply. So, if the caller decides that the transaction timed out and tears down the priv pointer passed to mgcp_client_tx, and if then a late reply arrives, the callback will dereference the invalid priv pointer and cause a segfault. Hence it is possible to crash an mgcp_client program by sending a late response. Furthermore, if no reply ever arrives, we would keep the pending response in the list forever, amounting to a "memory leak". Add mgcp_client_cancel() to discard a pending transaction. The caller can now decide to discard a pending response when it sees fit (e.g. the caller's timeout expired). This needs to be added to OsmoMSC and OsmoBSC. Add mgcp_msg_trans_id() to provide an obvious way to obtain the transaction id from a generated MGCP message. No public API is broken; but refine the negative return code from mgcp_client_rx(): return -ENOENT if no such transaction ID is found, and still -1 if decoding failed. This is mainly for mgcp_client_test. Implement a test for mgcp_client_cancel() in mgcp_client_test.c. Tweak internal mgcp_client_response_pending_get() to take only the transaction id as argument instead of the entire mgcp message struct. Found-by: dexter Related: OS#2695 OS#2696 Change-Id: I16811e168a46a82a05943252a737b3434143f4bd
2017-11-30 12:43:11 +00:00
- enqueue
- cancel succeeds
mgcp_client: add MGW name as logging context Usually only one MGCP client per application is present. Then the log lines from mgcp_client.c will be distinguishable without additional information. When the application is using a pool of MGWs, then the various MGCP Client instances become hard to distinguish. - Add a possibility to set a description (name) for each MGW pool member. When no description is set, use the domain name. - Output the pool member name on each log line in mgcp_client.c and mgcp_client_pool.c Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Related: SYS#5091
2021-09-03 15:50:51 +00:00
DLMGCP MGW(mgw) Canceled transaction 1
mgcp_client: add transaction cleanup So far, if an MGCP message is sent, the transaction gets enqueued, but there is no way to end the transaction other than receiving a valid reply. So, if the caller decides that the transaction timed out and tears down the priv pointer passed to mgcp_client_tx, and if then a late reply arrives, the callback will dereference the invalid priv pointer and cause a segfault. Hence it is possible to crash an mgcp_client program by sending a late response. Furthermore, if no reply ever arrives, we would keep the pending response in the list forever, amounting to a "memory leak". Add mgcp_client_cancel() to discard a pending transaction. The caller can now decide to discard a pending response when it sees fit (e.g. the caller's timeout expired). This needs to be added to OsmoMSC and OsmoBSC. Add mgcp_msg_trans_id() to provide an obvious way to obtain the transaction id from a generated MGCP message. No public API is broken; but refine the negative return code from mgcp_client_rx(): return -ENOENT if no such transaction ID is found, and still -1 if decoding failed. This is mainly for mgcp_client_test. Implement a test for mgcp_client_cancel() in mgcp_client_test.c. Tweak internal mgcp_client_response_pending_get() to take only the transaction id as argument instead of the entire mgcp message struct. Found-by: dexter Related: OS#2695 OS#2696 Change-Id: I16811e168a46a82a05943252a737b3434143f4bd
2017-11-30 12:43:11 +00:00
- late response gets discarded
mgcp-client: Add keepalive feature The `keepalive` feature in libosmo-mgcp-client allows scheduling periodical queries on the MGCP layer in order to make sure it is reachable and hence obtain information on the state of the MGCP link. This patch only uses it to print the status on the VTY, but it will be used too in a follow-up commit by the MGW Pool when picking an MGW from the pool: MGWs whose link is considered to be DOWN are skipped. The feature consists of: - A `keepalive request-interval` which will trigger a transmission of an MGCP AuditEndpoint command targeting endpoint with name `keepalive request-endpoint`. This interval is updated every time any message is transmitted in the MGCP link, meaning the MGCP AuditEndpoint message is only triggered if no message has been transmitted since `keepalive request-interval` seconds ago. - A `keepalive timeout` considering the MGW to be non-reachable (link DOWN) if no message is received over that amount of time. The `keepalive` parameters are to be preferrably configured so that "keepalive request-interval" * 2 < "keepalive timeout". Example VTY configuration of `keepalive` feature in libosmo-mgcp-client: ---- mgw 0 ... keepalive request-interval 20 <1> keepalive request-endpoint null <2> keepalive timeout 50 <3> ---- <1> Transmit an MGCP AuditEndpoint message to the MGW if no message has been sent to it over last 10 seconds <2> The MGCP AuditEndpoint targets the `null` endpoint. This is a special endpoint available at OsmoMGW for those purposes, but any available endpoint can be configured and used instead. <3> Consider the MGCP link to be DOWN if no message is received from the MGW over the last 50 seconds NOTE: The `keepalive` feature is disabled by default, and must be explicitly configured in order to enable it. Related: SYS#6481 Change-Id: I3dc74c78548d017f272da863d5282dc5e0020ca3
2023-06-14 10:20:49 +00:00
DLMGCP MGW(mgw) MGCP link to MGW now considered UP
mgcp_client: add MGW name as logging context Usually only one MGCP client per application is present. Then the log lines from mgcp_client.c will be distinguishable without additional information. When the application is using a pool of MGWs, then the various MGCP Client instances become hard to distinguish. - Add a possibility to set a description (name) for each MGW pool member. When no description is set, use the domain name. - Output the pool member name on each log line in mgcp_client.c and mgcp_client_pool.c Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Related: SYS#5091
2021-09-03 15:50:51 +00:00
DLMGCP MGW(mgw) MGCP client: Rx 200 1 OK
DLMGCP MGW(mgw) Cannot find matching MGCP transaction for trans_id 1
mgcp_client: add transaction cleanup So far, if an MGCP message is sent, the transaction gets enqueued, but there is no way to end the transaction other than receiving a valid reply. So, if the caller decides that the transaction timed out and tears down the priv pointer passed to mgcp_client_tx, and if then a late reply arrives, the callback will dereference the invalid priv pointer and cause a segfault. Hence it is possible to crash an mgcp_client program by sending a late response. Furthermore, if no reply ever arrives, we would keep the pending response in the list forever, amounting to a "memory leak". Add mgcp_client_cancel() to discard a pending transaction. The caller can now decide to discard a pending response when it sees fit (e.g. the caller's timeout expired). This needs to be added to OsmoMSC and OsmoBSC. Add mgcp_msg_trans_id() to provide an obvious way to obtain the transaction id from a generated MGCP message. No public API is broken; but refine the negative return code from mgcp_client_rx(): return -ENOENT if no such transaction ID is found, and still -1 if decoding failed. This is mainly for mgcp_client_test. Implement a test for mgcp_client_cancel() in mgcp_client_test.c. Tweak internal mgcp_client_response_pending_get() to take only the transaction id as argument instead of the entire mgcp message struct. Found-by: dexter Related: OS#2695 OS#2696 Change-Id: I16811e168a46a82a05943252a737b3434143f4bd
2017-11-30 12:43:11 +00:00
- canceling again does nothing
mgcp_client: add MGW name as logging context Usually only one MGCP client per application is present. Then the log lines from mgcp_client.c will be distinguishable without additional information. When the application is using a pool of MGWs, then the various MGCP Client instances become hard to distinguish. - Add a possibility to set a description (name) for each MGW pool member. When no description is set, use the domain name. - Output the pool member name on each log line in mgcp_client.c and mgcp_client_pool.c Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Related: SYS#5091
2021-09-03 15:50:51 +00:00
DLMGCP MGW(mgw) Cannot cancel, no such transaction: 1
mgcp_client: add transaction cleanup So far, if an MGCP message is sent, the transaction gets enqueued, but there is no way to end the transaction other than receiving a valid reply. So, if the caller decides that the transaction timed out and tears down the priv pointer passed to mgcp_client_tx, and if then a late reply arrives, the callback will dereference the invalid priv pointer and cause a segfault. Hence it is possible to crash an mgcp_client program by sending a late response. Furthermore, if no reply ever arrives, we would keep the pending response in the list forever, amounting to a "memory leak". Add mgcp_client_cancel() to discard a pending transaction. The caller can now decide to discard a pending response when it sees fit (e.g. the caller's timeout expired). This needs to be added to OsmoMSC and OsmoBSC. Add mgcp_msg_trans_id() to provide an obvious way to obtain the transaction id from a generated MGCP message. No public API is broken; but refine the negative return code from mgcp_client_rx(): return -ENOENT if no such transaction ID is found, and still -1 if decoding failed. This is mainly for mgcp_client_test. Implement a test for mgcp_client_cancel() in mgcp_client_test.c. Tweak internal mgcp_client_response_pending_get() to take only the transaction id as argument instead of the entire mgcp message struct. Found-by: dexter Related: OS#2695 OS#2696 Change-Id: I16811e168a46a82a05943252a737b3434143f4bd
2017-11-30 12:43:11 +00:00
test_mgcp_client_cancel() done
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
test_sdp_section_start() test [0]:
body: ""
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
DLMGCP MGCP response contains no SDP parameters
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
got audio_port=0
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
test_sdp_section_start() test [1]:
body: "\n\n"
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
got audio_port=0
test_sdp_section_start() test [2]:
body: "\r\n\r\n"
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
got audio_port=0
test_sdp_section_start() test [3]:
body: "\n\r\n\r"
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
got audio_port=0
test_sdp_section_start() test [4]:
body: "some mgcp header data\r\nand header params\n\nm=audio 23\r\n"
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
got audio_port=23
test_sdp_section_start() test [5]:
body: "some mgcp header data\r\nand header params\r\n\r\nm=audio 23\r\n"
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
got audio_port=23
test_sdp_section_start() test [6]:
body: "some mgcp header data\r\nand header params\n\r\n\rm=audio 23\r\n"
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
got audio_port=23
test_sdp_section_start() test [7]:
body: "some mgcp header data\r\nand header params\n\r\nm=audio 23\r\n"
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
DLMGCP MGCP response contains no SDP parameters
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
got audio_port=0
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
test_sdp_section_start() test [8]:
body: "some mgcp header data\r\nand header params\r\n\rm=audio 23\r\n"
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
DLMGCP MGCP response contains no SDP parameters
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
got audio_port=0
mgcp_client: show failure by MGCP SDP section parsing test To show how the current code fails, add test_sdp_section_start() to mgcp_client_test.c, and temporarily accept failing output. This will be fixed in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98. Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
2018-02-21 14:36:45 +00:00
test_sdp_section_start() test [9]:
body: "some mgcp header data\r\nand header params\n\r\rm=audio 23\r\n"
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
DLMGCP MGCP response contains no SDP parameters
got rc=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
got audio_ip=""
accept MGCP without SDP SDP is an optional part of MGCP messages. Do not fail when there is no SDP part. Practically this is useful to compose simpler MGCP responses from TTCN3 tests. osmo-mgw itself always includes SDP, so there is no real impact on operating libosmo-mgcp-client with osmo-mgw from osmo-bsc or osmo-msc. Change-Id: I608001626459ea72415fb142f857550bbb90c683
2019-09-19 01:06:46 +00:00
got audio_port=0
mgcp_client: Allow submitting and parsing IPv6 addr in SDP Existing mgcp_client_test code required the '.' to trigger the same code path, since with this commit we do extra checks and without a dot the address is not accepted as IPv4 by osmo_ip_str_type(). Change-Id: I936bf57d37f5f0607dfe7fc66c37e424c3793f9b
2020-08-28 18:21:55 +00:00
test_sdp_section_start() test [10]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP4 1.2.3.4\r\n"
got rc=0
got audio_ip="1.2.3.4"
got audio_port=0
test_sdp_section_start() test [11]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP6 2001:db8:1::ab9:c0a8:102\r\n"
got rc=0
got audio_ip="2001:db8:1::ab9:c0a8:102"
got audio_port=0
test_sdp_section_start() test [12]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP6 1.2.3.4\r\n"
DLMGCP Failed to parse MGCP response header (audio ip)
got rc=-22
test_sdp_section_start() test [13]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP4 ::1\r\n"
DLMGCP Failed to parse MGCP response header (audio ip)
got rc=-22
test_sdp_section_start() test [14]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP4 notanip\r\n"
DLMGCP Failed to parse MGCP response header (audio ip)
got rc=-22
test_sdp_section_start() test [15]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP4 1.2.3.4.5.6\r\n"
DLMGCP Failed to parse MGCP response header (audio ip)
got rc=-22
test_sdp_section_start() test [16]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP4 1.2 .3\r\n"
DLMGCP Failed to parse MGCP response header (audio ip)
got rc=-22
test_sdp_section_start() test [17]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP4 1.2 .3\r\n"
DLMGCP Failed to parse MGCP response header (audio ip)
got rc=-22
test_sdp_section_start() test [18]:
body: "some mgcp header data\r\nand header params\r\n\r\nc=IN IP4 \r\n"
DLMGCP Failed to parse MGCP response header (audio ip)
got rc=-22
client: add features to generate and parse codec information The current implementation does not support any way to influence the codec that is negotiated via SDP or LCO. The client statically negotitates AMR on an invalid payload type number. Also we ignore any codec information in the responses. - Add struct members to allow setting of user defined codec information. - Add struct members to retrieve parsed codec info from responses. - Add code to generate codec information in SDP - Add code to parse SDP codec info in MGCP responses Change-Id: I78e72d41b73acfcb40599a0ff4823f17c3642059 Related: OS#2728 Related: OS#3334
2018-06-07 16:51:31 +00:00
DLMGCP ptmap contains illegal mapping: codec=113 maps to pt=2
DLMGCP ptmap contains illegal mapping: codec=0 maps to pt=100
DLMGCP ptmap contains illegal mapping: codec=113 maps to pt=2
DLMGCP ptmap contains illegal mapping: codec=0 maps to pt=100
mgcp_client: add MGW name as logging context Usually only one MGCP client per application is present. Then the log lines from mgcp_client.c will be distinguishable without additional information. When the application is using a pool of MGWs, then the various MGCP Client instances become hard to distinguish. - Add a possibility to set a description (name) for each MGW pool member. When no description is set, use the domain name. - Output the pool member name on each log line in mgcp_client.c and mgcp_client_pool.c Change-Id: I53ff5445c8e5faffa4ef908ffb1fdb1f47ea2904 Related: SYS#5091
2021-09-03 15:50:51 +00:00
DLMGCP MGW(mgw) MGCP client: using endpoint domain '@mgw'
DLMGCP MGW(mgw) Cannot compose MGCP e1-endpoint name (ds/e1-15/s-1/su128-0@mgw), rate(128)/offset(0) combination is invalid!
DLMGCP MGW(mgw) Cannot compose MGCP e1-endpoint name (ds/e1-15/s-1/su8-16@mgw), rate(8)/offset(16) combination is invalid!
DLMGCP MGW(mgw) Cannot compose MGCP e1-endpoint name (ds/e1-15/s-0/su8-2@mgw), E1-timeslot number (0) is invalid!
DLMGCP MGW(mgw) Cannot compose MGCP e1-endpoint name (ds/e1-15/s-64/su8-2@mgw), E1-timeslot number (64) is invalid!
mgcp_client_test: add test_parse_response() Change-Id: I842ce65a9a70f313570857b7df53727cc572b9e6
2023-12-22 01:48:04 +00:00
test_parse_response() test [0]:
body: "200 2 OK\r\nI: foo\r\n\r\nv=0\r\no=- name 23 IN IP4 0.0.0.0\r\ns=-\r\nc=IN IP4 1.2.3.4\r\nt=0 0\r\nm=audio 23 RTP/AVP 112 3\r\na=rtpmap:112 AMR/8000\r\na=ptime:20\r\n"
got rc=0
got audio_ip="1.2.3.4"
got audio_port=23
112 AMR/8000/1
3 GSM/8000/1
test_parse_response() test [1]:
body: "200 2 OK\r\nI: foo\r\n\r\nv=0\r\no=- name 23 IN IP4 0.0.0.0\r\ns=-\r\nc=IN IP4 1.2.3.4\r\nt=0 0\r\nm=audio 23 RTP/AVP 112 3\r\na=rtpmap:112 AMR/8000\r\na=rtpmap:3 GSM/8000\r\na=ptime:20\r\n"
got rc=0
got audio_ip="1.2.3.4"
got audio_port=23
112 AMR/8000/1
3 GSM/8000/1
test_parse_response() test [2]:
body: "200 2 OK\r\nI: foo\r\n\r\nv=0\r\no=- name 23 IN IP4 0.0.0.0\r\ns=-\r\nc=IN IP4 1.2.3.4\r\nt=0 0\r\nm=audio 23 RTP/AVP 3\r\na=rtpmap:112 AMR/8000\r\na=ptime:20\r\n"
DLMGCP error in MGCP message: 'a=rtpmap:112' has no matching entry in 'm=audio ... 112'
got rc=0
got audio_ip="1.2.3.4"
got audio_port=23
3 GSM/8000/1
112 AMR/8000/1
test_parse_response() test [3]:
body: "200 2 OK\r\nI: foo\r\n\r\nv=0\r\no=- name 23 IN IP4 0.0.0.0\r\ns=-\r\nc=IN IP4 1.2.3.4\r\nt=0 0\r\nm=audio 23 RTP/AVP 101 102 103 104 105 106 107 108 109 110\r\na=rtpmap:101 AMR/8000\r\na=rtpmap:102 AMR/8000\r\na=rtpmap:103 AMR/8000\r\na=rtpmap:104 AMR/8"
got rc=0
got audio_ip="1.2.3.4"
got audio_port=23
101 AMR/8000/1
102 AMR/8000/1
103 AMR/8000/1
104 AMR/8000/1
105 AMR/8000/1
106 AMR/8000/1
107 AMR/8000/1
108 AMR/8000/1
109 AMR/8000/1
110 AMR/8000/1
test_parse_response() test [4]:
body: "200 2 OK\r\nI: foo\r\n\r\nv=0\r\no=- name 23 IN IP4 0.0.0.0\r\ns=-\r\nc=IN IP4 1.2.3.4\r\nt=0 0\r\nm=audio 23 RTP/AVP 101 102 103 104 105 106 107 108 109 110 3\r\na=rtpmap:101 AMR/8000\r\na=rtpmap:102 AMR/8000\r\na=rtpmap:103 AMR/8000\r\na=rtpmap:104 AMR"
DLMGCP SDP: can parse only up to 10 payload type numbers
DLMGCP Failed to parse SDP parameter payload types (RTP/AVP)
got rc=-22
Implement IuCS (large refactoring and addition) osmo-nitb becomes osmo-msc add DIUCS debug log constant add iucs.[hc] add msc vty, remove nitb vty add libiudummy, to avoid linking Iu deps in tests Use new msc_tx_dtap() instead of gsm0808_submit_dtap() libmgcp: add mgcpgw client API bridge calls via mgcpgw Enable MSC specific CTRL commands, bsc_base_ctrl_cmds_install() still needs to be split up. Change-Id: I5b5b6a9678b458affa86800afb1ec726e66eed88
2016-05-20 19:59:55 +00:00
Done