128 lines
5.0 KiB
Plaintext
128 lines
5.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "b151b64d_f74ccfd0",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-11-14T12:31:31Z",
|
|
"side": 1,
|
|
"message": "So you seem to fix some code generation in this patch, but I don\u0027t see any .c/.h files changes. Is that because the as1nstruct is called dynamically during build time?",
|
|
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "34434083_8f1b8aa9",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000147
|
|
},
|
|
"writtenOn": "2022-11-14T12:47:13Z",
|
|
"side": 1,
|
|
"message": "Yes. Here is the diff of the generated files with this patch: https://gitea.osmocom.org/osmith/osmo-iuh-generated-files/commit/80129270353912bad8e74cb1f0b13ee742559562",
|
|
"parentUuid": "b151b64d_f74ccfd0",
|
|
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3b4cb193_b5916b6b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-11-14T15:09:12Z",
|
|
"side": 1,
|
|
"message": "ACK. IIUC you didn\u0027t detect any code change required after this change in the users of the lib? In any case it may make sense to apply the renaming only for fields count \u003e 1 (so that if there\u0027s 2 or more fields colliding, the first one is kept the old way).",
|
|
"parentUuid": "34434083_8f1b8aa9",
|
|
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "85a0a3b1_648ed6e3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000147
|
|
},
|
|
"writtenOn": "2022-11-14T15:30:14Z",
|
|
"side": 1,
|
|
"message": "\u003e ACK. IIUC you didn\u0027t detect any code change required after this change in the users of the lib?\n\nyes\n\n\u003e In any case it may make sense to apply the renaming only for fields count \u003e 1 (so that if there\u0027s 2 or more fields colliding, the first one is kept the old way).\n\nThen we would actually change what the define does. Let\u0027s say you use the handy ENHANCEDRELOCATIONCOMPLETEREQUESTIES_RANAP_EXTENDEDRNC_ID_PRESENT define from the example in the commit message, then before this patch it means \"(1 \u003c\u003c 1)\". After this patch, if we keep the name of the define for the first entry and rename the second one, it will mean \"(1 \u003c\u003c 0)\".\n\nI think it\u0027s best to cause an error if this really has been used somewhere and we did not catch it since the behavior may not have been what the user intended in the first place.",
|
|
"parentUuid": "3b4cb193_b5916b6b",
|
|
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f67e31ea_1fa3837a",
|
|
"filename": "asn1/utils/asn1tostruct.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 84,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-11-14T12:31:31Z",
|
|
"side": 1,
|
|
"message": "Did you think about simply adding a suffix to it? like a counter if count !\u003d 1?",
|
|
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "37a3bf1a_6ba209a1",
|
|
"filename": "asn1/utils/asn1tostruct.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 84,
|
|
"author": {
|
|
"id": 1000147
|
|
},
|
|
"writtenOn": "2022-11-14T12:47:13Z",
|
|
"side": 1,
|
|
"message": "If somebody needs to actually use them / or debug the generated code for whatever reason, I think it\u0027s more useful to have the name of the field instead of a number. Because then you would need to look up the number again to know which field it actually is.",
|
|
"parentUuid": "f67e31ea_1fa3837a",
|
|
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "03f8c5f3_44c3c42a",
|
|
"filename": "asn1/utils/asn1tostruct.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 84,
|
|
"author": {
|
|
"id": 1000147
|
|
},
|
|
"writtenOn": "2022-11-15T10:37:05Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "37a3bf1a_6ba209a1",
|
|
"revId": "f49cfa030f324f8c2ea6bfaaaf6ac6ab219fc102",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |