osmo-hnbgw/e6201765cf67eb01e5f3066072d...

56 lines
2.0 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "1c23e796_fd0acca4",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000005
},
"writtenOn": "2022-08-09T15:59:18Z",
"side": 1,
"message": "this patch should fix build server fallout until the packaging of libosmo-pfcp works properly, by disabling PFCP by default.",
"revId": "e6201765cf67eb01e5f3066072ddf1b5e6970961",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "d2c6db5a_29017343",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2022-08-09T16:01:23Z",
"side": 1,
"message": "Do we really want to disable PFCP support at build time? Is that really going to be used and it is worth it to maintain that? I\u0027m fine with simply disabling it at runtime.",
"revId": "e6201765cf67eb01e5f3066072ddf1b5e6970961",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "7b3981cb_fbf31222",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2022-08-09T16:34:48Z",
"side": 1,
"message": "our existing apporoach is to try to minimize dependencies, see osmo-msc with default-off for smpp or Iu support.\n\nThe advantage of this approach is that it makes it easier for people to build a simple/typical setup from source, without cursing over all the dependencies.\n\nFor our package feeds it\u0027s not an issue as we can simply pass --enable-foo in the debian/rules.",
"parentUuid": "d2c6db5a_29017343",
"revId": "e6201765cf67eb01e5f3066072ddf1b5e6970961",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}