cellular-infrastructure
/
osmo-hnbgw
mirror of https://gerrit.osmocom.org/osmo-hnbgw
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000005 2023-06-13 02:03:37 +00:00 committed by Gerrit Code Review
parent 4831f2d237
commit ebaaaffc6d
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
da02e1fa388c0635cd3e37c87b385ab9fe2c8359
View File

@ -87,6 +87,24 @@
"parentUuid": "070ab3dd_c32d6af2",
"revId": "da02e1fa388c0635cd3e37c87b385ab9fe2c8359",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "12824e54_5c4e4246",
"filename": "src/osmo-hnbgw/hnbgw_l3.c",
"patchSetId": 3
},
"lineNbr": 281,
"author": {
"id": 1000005
},
"writtenOn": "2023-06-13T02:03:37Z",
"side": 1,
"message": "The two RESET related patches after this patch have been tweaked in the meantime: osmo-hnbgw will output ERROR logs during every RANAP RESET attempt asking the user to add a PLMN to its config file. I think that\u0027s loud enough and we don\u0027t need to warn on this marginal case.\n\nFYI, why this is pretty marginal:\n\nWe\u0027re not adopting some PLMN for good, this is just relevant to classify a particular incoming message.\n\nThe only effect this has is changing which CN link will pick up the new subscriber.\nWhen the UE indicates a TMSI that it got from a different PLMN, and if we used the TMSI, we would select a specific CN based on that.\nInstead we should not use the TMSI, and just select any CN by round-robin.\nThere is not actually any proper difference, only that there is no way to skip the round robin. The foreign TMSI might even have indicated the same CN that round robin happens to select.\n\nAny CN that is selected will then first ask the UE for its IMSI anyway; AFAIK it shouldn\u0027t even carry a TMSI to another PLMN in the first place?\n\nThis InitialUE message normally contains both the local PLMN a couple times over, as well as the previous PLMN the USIM camped on. So far things worked well by just comparing the PLMNs within one message, to classify the message itself as \"has previously been in another PLMN\".\n\nIn the meantime, some other reason has shown up to require an actual local PLMN to be configured in the cfg file.\n\nWe could happily continue to classify each individual message by the PLMNs contained in it, we trusted it enough until now. But instead, we now have first-hand info on the PLMN from the user via the cfg file, so rather use that.\n\n(and ideally also reject messages that indicate a mismatching local PLMN, to help the user find misconfigured HNBs; not implemented yet).\n\nSo it\u0027s a pretty marginal aspect and not critical for successful operation.\nThe code is here mainly because this is what osmo-bsc does",
"parentUuid": "d3fe4054_a35f4456",
"revId": "da02e1fa388c0635cd3e37c87b385ab9fe2c8359",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}