Update patch set 4

Patch Set 4: Code-Review+1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 1000010 <1000010@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 7ac42ce974dcbfd752ded6563b69bfc9d52e8e78
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}

fa97f88261608074f62d598dc36193a8800e72c3

@@ -34,6 +34,24 @@
       "parentUuid": "f53b9e7c_a6f89d49",
       "revId": "fa97f88261608074f62d598dc36193a8800e72c3",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "9722d324_28abfde8",
+        "filename": "src/osmo-hnbgw/hnbgw.c",
+        "patchSetId": 2
+      },
+      "lineNbr": 348,
+      "author": {
+        "id": 1000010
+      },
+      "writtenOn": "2023-06-13T14:31:07Z",
+      "side": 1,
+      "message": "\u003e I hope this is not called everytime we log a line :) \n\nSo the only user of this function is `hnb_context_name()`, which is employed by `LOGHNB`. This means that `talloc_asprintf()` *will* be called every time we log something using that macro, but only if the configured logging level lets the logging message pass.\n\nWith Neels we checked how `talloc_asprintf()` works under the hood, and it does not really look that bad. Most of the times it will use its internal stack allocated buffer when calling `asprintf()` and then simply memcpy() it to the allocated heap chunk.\n\nI never used this project and don\u0027t know how verbose it is with default logging configuration, but in general I don\u0027t think it\u0027s super critical. I would have voted CR-1 if this was osmo-bts, which may be running on low end embedded platforms. But I guess this project is expected to be running on some server with plenty of CPU and RAM? If at some point in the future we narrow down performance issues to this function, we can always revert back to using a static buffer, right?",
+      "parentUuid": "9d8261c8_54408599",
+      "revId": "fa97f88261608074f62d598dc36193a8800e72c3",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }