Update patch set 17

Patch Set 17:

(1 comment)

Patch-set: 17
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000074 2024-04-15 16:30:30 +00:00 committed by Gerrit Code Review
parent 0cdfe557f3
commit 6c536e115c
1 changed files with 18 additions and 0 deletions

View File

@ -316,6 +316,24 @@
"revId": "a92e9c966b20200950a8a4581b1c94e72b6f9954",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "d9185271_e54e9cd9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2024-04-15T16:30:30Z",
"side": 1,
"message": "\u003e Kindly state your reason for this statement, it seems unqualified to me.\n\nI already mentioned it in several places, even before you started writing any related code (Yes, I took the time to do so before you started coding by providing links to osmo_itq several times because I thought it would be helpful). The main loop should not be blocked. Running the nft command in blocking mode inside the main loop thread is not nice.\n\nSo having this merged means we end up with code blocking the main loop in current master, which is not desirable.\n\n\u003e every so often your CR uses stylistic means of downplaying a submitted patch without a sound base for it.\n\nIn line with the lately \"it\u0027s bikeshed\" and \"it\u0027s your opinion\" comments, even if I\u0027m not the only one stating it. I\u0027ll let others take care of this then, to avoid continuing with the \"downplaying\".",
"parentUuid": "3c4e0d94_7e987436",
"revId": "a92e9c966b20200950a8a4581b1c94e72b6f9954",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {