Update patch set 17

Patch Set 17:

(2 comments)

Patch-set: 17
CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}

18f74129adfe7c031d1217953864ea62740d61df

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "d598cb87_bb061283",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 17
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2024-04-09T18:52:32Z",
+      "side": 1,
+      "message": "ree",
+      "revId": "18f74129adfe7c031d1217953864ea62740d61df",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    }
+  ]
+}

a92e9c966b20200950a8a4581b1c94e72b6f9954

@@ -226,6 +226,24 @@
       "revId": "a92e9c966b20200950a8a4581b1c94e72b6f9954",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "782b39da_56396033",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 3
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 1000074
+      },
+      "writtenOn": "2024-04-09T18:52:32Z",
+      "side": 1,
+      "message": "Several pointers below:\n\n- I think that definetly we want to merge all this done in a separate thread from first step. I don\u0027t think it even makes sense to have it separated in a first step where everything happens in the same thread, since it\u0027s broken and distracts the whole thing.\n\n\u003e We don\u0027t have multi-threaded rate counters so far anywhere.\n\n- We do, in osmo-trx. In there since it\u0027s heavily multithreaded we do things a bit adhoc with separate structures and then copying them.\n\n\u003e The other idea that does not need libosmocore changes is this:\n\u003e have a separate \"volatile\" counter storage in the hnb_persistent struct;\n\u003e in the nft thread, do all parsing and all hnb lookups,\n\u003e and place parsed counters in that separate counter storage per hnbp.\n\u003e inter-thread signal (it_q is nice because it integrates in the select())\n\u003e to tell the main thread to shovel all hnb volatile counters into the rate_ctr;\n\u003e those volatile counters need a mutex (one global one, or maybe one per hnb).\n\nThat\u0027s similar to how osmo-trx does it, and I think it\u0027s how it should be done.\nAll other ways imho are calling for inconsistencies and stuff ending up broken.\n\nSo my opinion is: I\u0027m waiting to see a patch like the above described which I can review.",
+      "parentUuid": "8828a9f4_562a4b87",
+      "revId": "a92e9c966b20200950a8a4581b1c94e72b6f9954",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {