cellular-infrastructure
/
osmo-hnbgw
mirror of https://gerrit.osmocom.org/osmo-hnbgw
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
This commit is contained in:
Gerrit User 1000005 2024-03-23 01:33:43 +00:00 committed by Gerrit Code Review
parent 996ca5c657
commit 0716f5a34d
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
a92e9c966b20200950a8a4581b1c94e72b6f9954
View File

@ -708,6 +708,30 @@
},
"revId": "a92e9c966b20200950a8a4581b1c94e72b6f9954",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "e573d4d6_f1a6674a",
"filename": "src/osmo-hnbgw/nft_kpi.c",
"patchSetId": 3
},
"lineNbr": 249,
"author": {
"id": 1000005
},
"writtenOn": "2024-03-23T01:33:43Z",
"side": 1,
"message": "bpftrace says this:\n\nReservation: this is with only two hNodeBs connected, because our ttcn3 test suite has only two HNB slots.\nI\u0027ll try to have more hNodeBs to see the impact with longer response strings.\n...or i could just fabricate huge strings and test parsing them separately...\nanyway, this is what i see so far:\n\nUsing libjansson to parse a json response with four counters in it:\n\n (this is the part decoding the response string only)\n @decode_nft_response_us:\n [128, 256) 1 | |\n [256, 512) 26 |@@@@@@@@@@@@@@@@@@@@@ |\n [512, 1K) 10 |@@@@@@@@ |\n [1K, 2K) 62 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|\n \n (the overall reading+decoding from nft)\n @nft_kpi_read_counters_us:\n [1K, 2K) 1 | |\n [2K, 4K) 17 |@@@@@@@@@@@@ |\n [4K, 8K) 69 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|\n [8K, 16K) 11 |@@@@@@@@ |\n [16K, 32K) 1 | |\n\nUsing plain \u0027nftables\u0027 strings and decoding the same by manual string parsing:\n\n @decode_nft_response_us: \n [16, 32) 1 |@ |\n [32, 64) 22 |@@@@@@@@@@@@@@@@@@@@@@@ |\n [64, 128) 48 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|\n [128, 256) 30 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ |\n [256, 512) 1 |@ |\n\n @nft_kpi_read_counters_us: \n [1K, 2K) 7 |@@@@ |\n [2K, 4K) 12 |@@@@@@@ |\n [4K, 8K) 81 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|\n [8K, 16K) 1 | |\n\nThe string decoding part is about 10 times slower with libjansson.\n0.5 to 2 ms with libjansson, .03 to 0.3 ms with string parsing.\n\nagain, remains to be seen what happens when the lists get longer and hit exponential effects.",
"parentUuid": "a159e625_990cf2d7",
"range": {
"startLine": 249,
"startChar": 39,
"endLine": 249,
"endChar": 45
},
"revId": "a92e9c966b20200950a8a4581b1c94e72b6f9954",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}