Update patch set 2

Patch Set 2:

(1 comment)

Please reword attribute from "length" to "packet_length", imho length is too generic and if we add more params later it may become confusing.
Other than that looks good to me, please rename and I'll merge.

Patch-set: 2
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
Gerrit User 1000074 2021-06-10 18:34:50 +00:00 committed by Gerrit Code Review
parent e5740791f1
commit c7e5f86f2c
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "546222f3_d41ee72d",
"filename": "sysmocom/defaults.conf",
"patchSetId": 2
},
"lineNbr": 206,
"author": {
"id": 1000074
},
"writtenOn": "2021-06-10T18:34:50Z",
"side": 1,
"message": "since a default value is not needed, I\u0027d drop it from here, to simplify stuff",
"revId": "785816a860c08fae3d269337d8948ea157ac35f3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": true
}
]
}