Update patch set 2
Patch Set 2: For me, this case is the same as the srs-enb pre-init scripts. I agree with you that the best solution is to add these new features to OGT the way you propose (creating specific classes that add this support/features) and that's what we should do in the future. Right now we're under heavy development, with a lot of changes and testing, so the idea of the pre/post init script is very good to us, because it allows to run utilities/scripts that will help us to debug the system. I see two big advantages with this: we can do it faster with a script that adding this new feature to OGT and some of this utilities may be temporal and don't make sense to add them to OGT(for example the dmesg before and after the launch of the srs-enb). My proposal is to add the pre/post run scripts feature to the srs-ms and srs-enb. Then we can list and discuss the feature that each script adds and decide whether to add it to OGT or not (sometimes may be not needed because it's temporal, sometimes won't be worth it, because it's too unstable to add it and most of the times we will add them) Does it sound good to you? Patch-set: 2 CC: Gerrit User 1000186 <1000186@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
Gerrit User 1000204
Gerrit Code Review
parent
705a43a579
commit
b2fa016c42